number of records in binary file is in decimal

[csstudent123]

Hi. My size of binary file is 1920 KB and my struct size is 124 kb. now to find number of records in file I divided 1920/124 and it gives me 15.4.... do I add 1 to 15.4 and make it 16 or do i take it as 15?

[Zhuge]

I hope you are dealing with exact values here, otherwise this won't work.

But otherwise, think for a second. If you took it as 16 records, you would need 16×124KB=1984KB of space at least, while the file is only 1920KB.

[csstudent123]

I am reading with 15 as total records but I am getting garbage values as output when I read in to struct pointer

customer* getRecords(customer* cust, char file[], ifstream& Read, int tot_rec){


    Read.open(file, ios::in | ios::binary);

    if(!Read){
        cout<<"read fail"<<endl;
        return NULL;
        }

    for(int i=0;i<tot_rec;i++){

        Read.read((char*)&cust[i], sizeof(customer));
        cout<<cust[i].id<<endl;/////
        //read.getline(cust[i].fname, name);
        cout<<cust[i].fname<<endl;/////
        //read.getline(cust[i].lname, name);
        cout<<cust[i].lname<<endl;
        //read.getline(cust[i].contactNum, number);
        cout<<cust[i].contactNum<<endl;

    }
    Read.close();

    return cust;

}

[MiiNiPaa]

How did you write it in the first place?
It looks like your structs are aligned by 128kb boundary.
(Did I read it right? YOur struct size is 124 kilobytes?)

[csstudent123]

its 124 bytes

[MiiNiPaa]

So your binary is 1920 bytes.

Show how this file was created.

[csstudent123]

its already given by my tutor...

[MiiNiPaa]

It looks like there was another 4 bytes of padding inside of structure.

I am getting garbage values as output when I read in to struct pointer

Do the first structure go out right?

[csstudent123]

nope, just gives out first ID or first fname ..rest all garbage values

[csstudent123]

fixed it..thanks...damn null character