Copy Constructor with an Array Crashing!!!

[JustinH]

I know everything works except my copy constructor! There are no errors. The program crashes when it goes to access the copy constructor. Anybody have an clue as to why the copy constructor isn't working?

#ifdef _MSC_VER
#define _CRT_SECURE_NO_WARNINGS
#endif
#include    <cstring>       // access to C str functions
#include    "String.h"      // access String class
using namespace std;

String::String( int size )// default constructor
{
    cout << "String(" << size << ")\n";
    str  = new char[ size ];

    cout << "\tstr at " << hex << ( void * ) str << '\n';
    *str = '\0';
}

String::String( const char *s )//constructor
{
    cout << "String(" << s << ")\n";
    str = new char[ strlen(s) + 1 ];

    cout << "\tstr at " << hex << ( void * ) str << '\n';
    strcpy(str, s);
}

String::String( const String &s)//copy constructor
{
	//s.str
	//str is what seing out or current object
	for(size_t i = 0; i <= strlen(s.str); i++)
	{
		str [i] = s.str[i];
	}
}

String::~String( )//deconstructor
{
	if (*str)
		delete[] str;
}

const String &String::operator =( const String &s ) //operator
{
    for(size_t i = 0; i <= strlen(s.str); i++)
	{
		str [i] = s.str[i];
	}
	return s;
}

ostream &operator <<( ostream &out,	//ostream out rule -- google
                     const String &rhs )  //operator
{
    for(size_t i = 0; i < strlen(rhs.str); i++)
	{
		out << rhs.str[i];
	}
	return out;
}

[TheIdeasMan]

Hi,

Just wondering if you are going past the end of the array by using the <= operator in the for loop. The normal idiom is:

for (a = 0; a < length; ++a ) {}

Do you have the same problem in the assignment operator?

[cire]

You don't allocate any memory in your copy constructor, as you do in your other constructors. Why is this?

Your destructor is almost certainly wrong. If it is valid to dereference str, str needs to be deleted.