my do while loop is right ...but it ends without me entering all the values in for output!!! as soon as i enter two inputs it ends!! so please help me find whats missing??
1. Write a program that reads 10 numbers. The program should report the total number of positive numbers entered. The average value of the positive numbers and the same for negative numbers. The program should also indicate which of the two categories (positive or negative) has the highest count. (Use do-while loop)
Sample run:
Please input 10 numbers:
3
-6
-12
-4
13
-12
-8
-2
133
1
There were 4 positive numbers and their average was 37.5
There were 6 negative numbers and their average was -7.33
There were more negative numbers than positive numbers
#include <iostream>
#include <iomanip>
usingnamespace std;
int main()
{
int counter_pos = 0,
counter_neg = 0,
input = 0,
sum_pos = 0,
sum_neg = 0;
double average_pos = 0,
average_neg = 0;
cout << "Please input 10 numbers : " << endl;
cin >> input;
do
{
if (input>= 0)
{
counter_pos++;
sum_pos += input;
}
elseif (input< 0)
{
counter_neg++;
sum_neg += input;
}
cin >> input;
} while (input >= 10);
{
if (counter_pos != 0)
average_pos = static_cast<double>(sum_pos) / counter_pos;
else
average_pos = 0;
if (counter_neg != 0)
average_neg = static_cast<double>(sum_neg) / counter_neg;
else
average_neg = 0;
}
cout << "There were " << counter_pos << " positive number(s), and their average was " << setprecision(2) << fixed << average_pos << "!" << endl;
cout << "There were " << counter_neg << " negative number(s), and their average was " << setprecision(2) << fixed << average_neg << "!" << endl;
if (counter_pos > counter_neg)
cout << "There were more positive numbers than negative numbers." << endl;
elseif (counter_pos < counter_neg)
cout << "There were more negative numbers than positive numbers." << endl;
else
cout << "There was the same amount of positive and negative numbers." << endl;
if (average_pos > average_neg)
cout << "positive numbers average is higher." << endl;
elseif (average_pos < average_neg)
cout << "negative numbers average is higher" << endl;
else
cout << "The average of the positive numbers is as high as of the negative ones." << endl;
return 0;
}
Your formatting was brutal, so I updated it. I didn't change the function of your code, just the way it looks (by cutting out superfluous whitespace). Check out the part where you read in input. The first read will always happen. Then you go into a do-while loop. A do-while will always execute once. Then, at the end you evaluate the condition which in this case is input >= 10. That means the loop will keep going as long as the number you input is greater than or equal to 10. This is not what you want. You don't care what the input is, you just want to get 10 inputs. I would suggest a for-loop.
1 2 3 4 5 6 7 8 9 10
//...
int numTermsIWant = 10;
for(int i = 0; int < numTermsIWant; ++i)
{
cout << "Please input a number : " << endl;
cin >> input;
//update counters and sums accordingly
}
//...
EDIT: The curly braces on line 34 and 44 are unnecessary. I think given the placement of the while in your code it may have confused you as to what that while actually belonged to. It belongs to the block that starts with do right above it.
What booradley60 was saying is that you need to use a separate variable to use as a counter to count the total numbers that have been input by the user so far regardless of what type of loop you use.
1 2 3 4 5 6
int counter = 0;
do {
//get number from user
//update counters and sums
++counter; //counts the current input
} while ( counter < 10);
The problem with your current code deals with the logic of it. Rather than checking to see if the user has entered less than ten numbers, it checks to see if the number the user has input is greater than ten.
