Code fix

[jasonwynn10]

hello, can someone fix this for me? I can't seem to find where the problem is.

#define WIN32_LEAN_AND_MEAN // prevent windows.h from including "kitchen sink"
#include <windows.h>
#include <iostream>
#include <string>
using namespace std;
int main( int argc, char **argv )
{
argv[0]="\C:\\Documents and Settings\\Jason\\My Documents\\Jason\\My Music\\LOOKING LIKE THIS.wav\\0";
argv[1];

LPCSTR Application = "C:\\Program Files\\Windows Media Player\\wmplayer.exe";
// Media file extension must be provided
// Paths are quoted
char Command[1024] = "\"C:\\Program Files\\Windows Media Player\\wmplayer.exe\""argv[0];
//Above this is what needs input.
STARTUPINFOA si = {0}; // zero struct
si.cb = sizeof(si);
PROCESS_INFORMATION pi = {0}; // zero struct
if( CreateProcessA(
Application,
Command,
NULL,
NULL,
FALSE,
NULL,
0,
NULL,
&si,
&pi) )
{cout << "Song playing\n";
WaitForSingleObject(pi.hProcess, INFINITE);
DWORD exitCode = 0;
GetExitCodeProcess(pi.hProcess, &exitCode);
CloseHandle(pi.hThread);
CloseHandle(pi.hProcess);}else
{DWORD errCode = GetLastError();
cerr << "song playing failed\nError code: " << errCode << "\n";}}

[Computergeek01]

Can we start with WHAT the problem is? Thank you for using code tags but how did you manage to destroy your formatting?

[booradley60]

#define WIN32_LEAN_AND_MEAN // prevent windows.h from including "kitchen sink"
#include <windows.h>
#include <iostream>
#include <string>

using namespace std;

int main( int argc, char **argv )
{
    argv[0]="\C:\\Documents and Settings\\Jason\\My Documents\\Jason\\My Music\\LOOKING LIKE THIS.wav\\0";
    argv[1];

    LPCSTR Application = "C:\\Program Files\\Windows Media Player\\wmplayer.exe";
    // Media file extension must be provided
    // Paths are quoted
    char Command[1024] = "\"C:\\Program Files\\Windows Media Player\\wmplayer.exe\""argv[0];

    //Above this is what needs input.
    STARTUPINFOA si = {0}; // zero struct
    si.cb = sizeof(si);
    PROCESS_INFORMATION pi = {0}; // zero struct

    if( CreateProcessA(Application,
                        Command,
                        NULL,
                        NULL,
                        FALSE,
                        NULL,
                        0,
                        NULL,
                        &si,
                        &pi)
        )
    {
        cout << "Song playing\n";
        WaitForSingleObject(pi.hProcess, INFINITE);
        DWORD exitCode = 0;
        GetExitCodeProcess(pi.hProcess, &exitCode);
        CloseHandle(pi.hThread);
        CloseHandle(pi.hProcess);
    }
    else
    {
        DWORD errCode = GetLastError();
        cerr << "song playing failed\nError code: " << errCode << "\n";
    }
}

I formatted your code into something more readable. What are you trying to do on line 16?

[jasonwynn10]

I'm trying to be able to input the file directory there. That is where it is failing and I don't know why.

[giblit]

What exactly are you trying to do with the arbitrary argv[0] on line 16?

[jasonwynn10]

input a file directory
Ex: \C:\\Program Files\\Windows Media Player\\wmplayer.exe\

[giblit]

Then why do you have the arbitrary argv[0]? Remove it and it will do what you are wanting.

Also line 11 does nothing.

[jasonwynn10]

I am trying to insert it in the console

[Computergeek01]

The trouble with that is argv[0] is generally the current directory and name of the process that is running. You want argv[1] for the first argument. Also, why aren't you just using std::string? You an concatenate the argument to your literal with the "std::string.append()" member function.

[jasonwynn10]

I don't use that because i don't know what that is or does

[Computergeek01]

You don't use what? std::string? Are you serious? Would you like one of us to Google that for you, or would you rather just take a dip into our beloved forums dated tutorial?

[jasonwynn10]

could you just explain it or use lmgtfy.com? Im a noob.

[giblit]

Did you seriously ask us to give you a lmgtfy link?

All you had to do was go on the reference on this site or search "std::string" at the top :P
http://www.cplusplus.com/reference/string/

[jasonwynn10]

maybe...

[jasonwynn10]

I still don't know what i'm doing...

[giblit]

std::string str1 = "hello";
std::string str2 = " world!";

std::string str3 = str1 + str2;

std::cout << str3 << std::endl;

http://www.cplusplus.com/reference/string/basic_string/
http://www.cplusplus.com/reference/string/basic_string/operator+=/
http://www.cplusplus.com/reference/string/basic_string/append/
http://www.cplusplus.com/reference/string/basic_string/operator+/

[jasonwynn10]

ok... sheesh!