Console app crashing after calling function

[natepup21]

Im new to debugging but it says the problem is on line 97 which is the verb menu function being called in the first switch statement case 0:


verb menu is one of the sub menus i want ,and it loads but then it crashes ...

#include <iostream>
#include <string>
#include "spanishverbs.h"
#include <windows.h>

#include <cmath>
#include <cstdlib>

using namespace std;


void nounmenu();

void verbmenu();





void mainmenu()
{
system("cls");
cout<<tospeak;
string menu[4]={"Verb Study and Quizzes ","Noun and pronouns","Sentences","Exit"};

  int  pointer =0;


//menu main menu

while(true) {
system("cls");


SetConsoleTextAttribute(GetStdHandle(STD_OUTPUT_HANDLE), 15);
cout << "SPANISH STUDY and QUIZZES\n\n";
for(int i=0;i < 4; ++i){
  if (i==pointer){

SetConsoleTextAttribute(GetStdHandle(STD_OUTPUT_HANDLE), 11);
cout<<menu[i]<<endl;
}

else {




SetConsoleTextAttribute(GetStdHandle(STD_OUTPUT_HANDLE), 15);

cout<<menu[i]<<endl;
}
}
while(true){
if (GetAsyncKeyState(VK_UP) !=0 )

{


pointer-=1;
if (pointer == -1)

{
pointer=3;


}
break;
}



else if(GetAsyncKeyState(VK_DOWN)!=0)

{
pointer +=1;
if (pointer==4){
    pointer=0;
Sleep(500);

}
break;
}
else if(GetAsyncKeyState(VK_RETURN)!=0){

switch(pointer){




pointer=0;

case 0:



 verbmenu();


break;


case 1:




nounmenu();

break;
case 2:





break;

case 3:






break;

case 4:


break;


}

}

Sleep(500);
}
}
}




void verbmenu(){

int pointer=0;
string menu[3]={"Verb StudY","Verb Quizzes","Exit"};
while(true){
system("cls");
SetConsoleTextAttribute(GetStdHandle(STD_OUTPUT_HANDLE), 15);
cout<<"VERB MENU\n\n";



for (int i=0; i<4  ; ++i){





if(i==pointer){

SetConsoleTextAttribute(GetStdHandle(STD_OUTPUT_HANDLE), 11);
cout<<menu[i]<<endl;


}

else
{


SetConsoleTextAttribute(GetStdHandle(STD_OUTPUT_HANDLE), 15);
cout<<menu[i]<<endl;


}
}


while (true){

    if (GetAsyncKeyState(VK_UP)!=0){
            pointer-=1;
            if(pointer==-1)

            {
Sleep(500);
                pointer=2;
            }
            break;
            }
            else if(GetAsyncKeyState(VK_DOWN)!=0){

                    pointer+=1;
                if (pointer==2)

                {
                    Sleep(500);
                    pointer=0;

                }
                break;
            }
            else if(GetAsyncKeyState(VK_RETURN)!=0)

            {
switch(pointer){

pointer =0;

case 0 :

    {
        cout<<"hello0";
    }

break;

case 1:

    {

        cout<<"hello 1";
    }
    break;




case 2:{
  mainmenu();

}

break;



            }

            }


}

// FIRST  while TRUE STATEMENT





}

}
void nounmenu(){






}

int main (){


 mainmenu();
return 0;


}

[Chervil]

At line 151, an array of 3 items is declared:

    string menu[3]

Then at line 159, there is a loop,

    for (int i=0; i<4  ; ++i){

when i reaches the value 3, at line 178, an out of bounds array access is done,

    cout<<menu[i]<<endl;

which results in the crash.

By the way, the formatting of the code is horrible, a bit less vertical space and consistent indentation would help a lot with legibility.

[Yay295]

I cleaned up your code a bit.

#include <iostream>
#include <string>
#include "spanishverbs.h"
#include <windows.h>


using namespace std;


void verbmenu ( );

void nounmenu ( );


void mainmenu ( )
{
    system ( "cls" );

    cout << tospeak;

    string menu[4] = { "Verb Study and Quizzes", "Noun and Pronouns", "Sentences", "Exit" };
    
    int pointer = 0;


    while ( true )
    {
        system ( "cls" );


        SetConsoleTextAttribute ( GetStdHandle ( STD_OUTPUT_HANDLE ) , 15 );

        cout << "SPANISH STUDY and QUIZZES\n\n";


        for ( int i = 0; i < 4; ++i )
        {
            if ( i == pointer )
                SetConsoleTextAttribute ( GetStdHandle ( STD_OUTPUT_HANDLE ) , 11 );

            else
                SetConsoleTextAttribute ( GetStdHandle ( STD_OUTPUT_HANDLE ) , 15 );

            cout << menu[i] << '\n';
        }


        while ( true )
        {
            if ( GetAsyncKeyState ( VK_UP ) )
            {
                if ( --pointer == -1 ) pointer = 3;

                break;
            }

            else if ( GetAsyncKeyState ( VK_DOWN ) )
            {
                if ( ++pointer == 4 )
                {
                    pointer = 0;

                    Sleep ( 500 );
                }

                break;
            }


            else if ( GetAsyncKeyState ( VK_RETURN ) )
            {
                switch ( pointer )
                {
                    pointer = 0;

                    case 0:
                        verbmenu ( );
                        break;
                    case 1:
                        nounmenu ( );
                        break;
                    case 2:
                        break;
                    case 3:
                        break;
                    case 4:
                        break;
                }
            }

            Sleep ( 500 );
        }
    }
}

void verbmenu ( )
{
    int pointer = 0;

    string menu[3] = { "Verb Study", "Verb Quizzes", "Exit" };


    while ( true )
    {
        system ( "cls" );

        SetConsoleTextAttribute ( GetStdHandle ( STD_OUTPUT_HANDLE ) , 15 );

        cout<<"VERB MENU\n\n";


        for ( int i = 0; i < 3; ++i )
        {
            if ( i == pointer )
                SetConsoleTextAttribute ( GetStdHandle ( STD_OUTPUT_HANDLE ) , 11 );

            else
                SetConsoleTextAttribute ( GetStdHandle ( STD_OUTPUT_HANDLE ) , 15 );

            cout << menu[i] << '\n';
        }


        while ( true )
        {
            if ( GetAsyncKeyState ( VK_UP ) )
            {
                if ( --pointer == -1 )
                {
                    pointer = 2;

                    Sleep ( 500 );
                }

                break;
            }

            else if ( GetAsyncKeyState ( VK_DOWN ) )
            {
                if ( ++pointer == 2 )
                {
                    pointer = 0;

                    Sleep ( 500 );
                }

                break;
            }

            else if ( GetAsyncKeyState ( VK_RETURN ) )
            {
                switch ( pointer )
                {
                    pointer = 0;

                    case 0:
                    case 1:
                        cout << "hello " << pointer;
                        break;
                    case 2:
                        mainmenu ( );
                        break;
                }
            }
        }
    }
}

void nounmenu ( )
{
}

int main ( )
{
    mainmenu ( );
}

Can you give us more information on the crash? Does it crash when it tries to run verbmenu(), or inside verbmenu()? What error message do you get?
Looks like Chervil found the problem.

You seem to have a lot of repeated code. You could probably combine some of it.

[natepup21]

Thank you both of you ,but that was the problem the for ( int i = 0; i < 4; ++i )
in the verbmenu function i changed the 4 to 3 and it works thanks .