Need help with issue

[twesna]

kk

[wildblue]

lines 201 through 241 run regardless of what the result was, that's why all three messages come up. Seems like you might want to tie those in to the if/else structure you have on lines 194-199.

[Maharaja]

You can use a switch statement like:

switch (WhoWon)
	{
		case 'p':
		msgWIN=rand()%5;
		if(msgWIN==0)
			cout <<"Congradulations you won against the computer! "<<endl;
		else if (msgWIN==1)
			cout <<"OMG you just won, hip hip hurrayyyyyyyyyyy! "<<endl;
		else if (msgWIN==2)
			cout <<" Winner Winner Winner!"<<endl;
		else if (msgWIN==3)
			cout << "You win!"<<endl;
		else if (msgWIN==4)
			cout <<"You just won against Sheldon Cooper!"<<endl;
        break;
	}

also lines 194-199 are unnecessary

[twesna]

thanks for all of you feedback!!!! it was very helpful

however I have another question, when the user enters help when prompted to do so, the help instructions show up but immediately right after an error/abort message pops up!

[Maharaja]

added a loop in the beginning. As far as I noticed there's no other issues

#include <iostream>
#include <cstdlib>
#include <ctime>
#include <string>

using namespace std;

int main()
{

	char again = 'y';
	while (again == 'y')

	{
        string userpick;
        int CompChoice,usernumber = -1,msgLOSE, msgWIN, msgTIE;
        char WhoWon;

		srand(unsigned(time(NULL)));
			CompChoice = rand() % 5 ;
				cout<<"Let's play a game! "<<endl<<endl;




    while (usernumber == -1)
    {
    cout<<"\nChoose rock, paper, scissors, lizard, spock or help: ";
    cin >>userpick;
    if (userpick == "rock")
		usernumber = 0;
	else if (userpick == "paper")
		usernumber = 1;
	else if (userpick == "scissors")
		usernumber = 2;
	else if (userpick == "lizard")
		usernumber = 3;
	else if (userpick == "spock")
		usernumber = 4;
	else if (userpick == "help")
	{
		cout <<"Scissors cuts paper"<<endl;
		cout<<"Scissors decapitate lizard"<<endl;
		cout<<"Paper covers rock"<<endl;
		cout<<"Paper disproves Spock"<<endl;
		cout<<"Rock crushes scissors"<<endl;
		cout<<"Rock crushes lizard"<<endl;
		cout<<"Spock vaporizes rock"<<endl;
		cout<<"Spock smashes scissors"<<endl;
		cout<<"Lizard poisons Spock"<<endl;
		cout<<"Lizard eats paper"<<endl;
	}
    }

    if (usernumber==0)
	{
		if (CompChoice == 0)
		{
			WhoWon = 't';
				cout <<"Computer chooses rock."<<endl<<endl;
		}
		else if (CompChoice == 1)
		{
			WhoWon = 'c';
				cout <<"Computer chooses paper."<<endl<<endl;
		}
		else if (CompChoice == 2)
		{
			WhoWon = 'p';
				cout <<"Computer chooses scissors."<<endl<<endl;
		}
		else if (CompChoice == 3)
		{
			WhoWon = 'p';
				cout <<"Computer chooses lizard."<<endl<<endl;
		}
		else if (CompChoice == 4)
		{
			WhoWon = 'c';
				cout <<"Computer chooses Spock."<<endl<<endl;
		}
	}

	if (usernumber==1)
	{
		if (CompChoice ==0)
		{
			WhoWon = 'p';
				cout <<"Computer chooses rock."<<endl<<endl;
		}
		else if (CompChoice == 1)
		{
			WhoWon = 't';
				cout <<"Computer chooses paper."<<endl<<endl;
		}
		else if (CompChoice == 2)
		{
			WhoWon = 'c';
				cout <<"Computer chooses scissors."<<endl<<endl;
		}
		else if (CompChoice == 3)
		{
			WhoWon = 'c';
				cout <<"Computer chooses lizard."<<endl<<endl;
		}
		else if (CompChoice == 4)
		{
			WhoWon = 'p';
				cout <<"Computer chooses Spock."<<endl<<endl;
		}
	}

	if (usernumber==2)
	{
		if (CompChoice ==0)
		{
			WhoWon = 'c';
				cout <<"Computer chooses rock."<<endl<<endl;
		}
		else if (CompChoice == 1)
		{
			WhoWon = 'p';
				cout <<"Computer chooses paper."<<endl<<endl;
		}
		else if (CompChoice == 2)
		{
			WhoWon = 't';
				cout <<"Computer chooses scissors."<<endl<<endl;
		}
		else if (CompChoice == 3)
		{
			WhoWon = 'p';
				cout <<"Computer chooses lizard."<<endl<<endl;
		}
		else if (CompChoice == 4)
		{
			WhoWon = 'c';
				cout <<"Computer chooses Spock."<<endl<<endl;
		}
	}

	if (usernumber==3)
	{
		if (CompChoice ==0)
		{
			WhoWon = 'c';
				cout <<"Computer chooses rock."<<endl<<endl;
		}
		else if (CompChoice == 1)
		{
			WhoWon = 'p';
				cout <<"Computer chooses paper."<<endl<<endl;
		}
		else if (CompChoice == 2)
		{
			WhoWon = 'c';
				cout <<"Computer chooses scissors."<<endl<<endl;
		}
		else if (CompChoice == 3)
		{
			WhoWon = 't';
				cout <<"Computer chooses lizard."<<endl<<endl;
		}
		else if (CompChoice == 4)
			WhoWon = 'p';
				cout <<"Computer chooses Spock."<<endl<<endl;
	}

	if (usernumber==4)
	{
		if (CompChoice ==0)
		{
			WhoWon = 'p';
				cout <<"Computer chooses rock."<<endl<<endl;
		}
		else if (CompChoice == 1)
		{
			WhoWon = 'c';
				cout <<"Computer chooses paper."<<endl<<endl;
		}
		else if (CompChoice == 2)
		{
			WhoWon = 'p';
				cout <<"Computer chooses scissors."<<endl<<endl;
		}
		else if (CompChoice == 3)
		{
			WhoWon = 'c';
				cout <<"Computer chooses lizard."<<endl<<endl;
		}
		else if (CompChoice == 4)
		{
			WhoWon = 't';
				cout <<"Computer chooses Spock."<<endl<<endl;
		}
	}


switch (WhoWon)
{
		case 'p':
            msgWIN=rand()%5;
            if(msgWIN==0)
                cout <<"Congradulations you won against the computer! "<<endl;
            else if (msgWIN==1)
                cout <<"OMG you just won, hip hip hurrayyyyyyyyyyy! "<<endl;
            else if (msgWIN==2)
                cout <<" Winner Winner Winner!"<<endl;
            else if (msgWIN==3)
                cout << "You win!"<<endl;
            else if (msgWIN==4)
                cout <<"You just won against Sheldon Cooper!"<<endl;
            break;
        case 'c':
            msgLOSE=rand()%5;
            if(msgLOSE==0)
                cout <<"You lost to the computer! "<<endl<<endl;
            else if (msgLOSE==1)
                cout <<"You were pwned! "<<endl<<endl;
            else if (msgLOSE==2)
                cout <<"You lose! "<<endl<<endl;
            else if (msgLOSE==3)
                cout <<"Sucka you just lost!"<<endl<<endl;
            else if (msgLOSE==4)
                cout <<"You just got destroyed by the computer!"<<endl<<endl;
            break;
        case 't':
            msgTIE=rand()%3;
            if (msgTIE==0)
                cout <<"It's a tie"<<endl<<endl;
            else if (msgTIE==1)
                cout <<"You tied the computer!"<<endl<<endl;
            else if (msgTIE==2)
                cout <<"O no, look like it's a draw!"<<endl<<endl;
                break;
}


cout << "Do you wish to play again (y/n)? " <<endl;
cin >> again;
}
	}

[twesna]

okk, I extremely appreciate your help!

[iQChange]

@twensa Are you brazillian?