Messed Up Program (File handling)

[abeginner23235616]

Okay, So it was not my intention to paste the whole program and offend you guys.
But I am helpless.
Basically, I am trying to make a personal diary in which there are three profiles:

1.Admin
2.User
3.New User

The program is not completed yet(obviously :p). The problem is , whenever a user
saved his details and tries to login. It is unable to search the id and password from the file.

I know, the program is little long, so I have highlighted the following parts.
-> the NewUser class
-> the password checking functions.
-> the main() function

#include<iostream>
#include<fstream>
#include<stdio.h>
#include<conio.h>
#include<string>
using namespace std;

class Admin{

public:
Admin(){




}

void Read(){

}

void Write(){


}

};

class NewUser{

public:
    string password,id;
void menu(){
cout<<"Please give an id\n";

cin>>id;

cout<<"Please give your password\n"<<id<<endl;
password="";
char c = ' ';

while(c != 13) //Loop until 'Enter' is pressed
   {
   c = getch();
   if(c!=13){
   password += c;
   cout << "*";}
   }

cout<<password<<endl;
}


};

class User{

public:

char id[10], password[20];
void Read(){

}

void Write(){


}

void menu(){

cout<<"Please select your menu\n";
int m;
cin>>m;

switch(m){
case 1:

    Read();

    break;

case 2:

    Write();

    break;

default:

    cout<<"wrong option\n";
}
}
};

void CheckingPrimaryFiles(){

ifstream ifs("user.txt",ios::app|ios::binary);

if(!ifs)
{

    ofstream of("user.txt",ios::binary|ios::app);
    of.close();
}

ifs.close();

ifstream a("Admin.txt");
if(!a){
    ofstream asd("Admin.txt");
    cout<<"FIRST TIME EXECUTION:\nPlease set a password\n";
    //char password[20],test[20];
    string password = "";
char c = ' ';

while(c != 13) 
   {
   c = getch();
   if(c!=13){
   password += c;
   cout << "*";}
   }
   asd<<password;

    asd.close();
}
a.close();
}


int PasswordChecker(int a,string password="",string id=""){
//char p[20],test[20];
ifstream ifs("Admin.txt");
ifstream obj("user.txt",ios::binary|ios::app);
NewUser us;
if(a==0){
    int i=0;
    string check;
    ifs>>check;
    if(check==password)
    return 1;
else
    return 0;

}

else
{
    while(obj.read((char*)&us, sizeof(NewUser))){
                cout<<"\nrunning\n";
        if(id==us.id){

            cout<<"Please give your password\n";

            string pass = "";
            char c = ' ';

            while(c != 13) 
        {
        c = getch();
        if(c!=13){
            pass += c;
            cout << "*";}
            }
                 if(pass==us.password)
                 {
                     return 1;

                 }else
                 return 0;

        }else
        continue;

    }
    return 0;
}

return 0;
}

int getPassword(int a,string id=""){
    if(a==0){
     //char password[20],test[20];
    string password = "";
char c = ' ';

while(c != 13) 
   {
   c = getch();
   if(c!=13){
   password += c;
   cout << "*";}
   }

    }
      if(PasswordChecker(a,id))
           return 1;
      else
      return 0;
}

int main(){

    CheckingPrimaryFiles();
    string id;
    cout<<"Please choose profile\n";
   /*CASE 1 IS FOR THE ADMIN, CASE 2 IS FOR THE USER, CASE 3 IS FOR THE NEW_USER*/

    int profile;
    cin>>profile;
    switch(profile){
    //admin
case 1:

    cout<<"Please give the password\n";
    if(getPassword(0)){
            cout<<"Welcome Tanmay\n";
        Admin admin;

    }
    else
        cout<<"wrong password\n";
        break;
    //User
case 2:

    cout<<"Please provide id\n";


   cin>>id;
    if(getPassword(profile,id)){
        User user;
        user.menu();

    }else
    cout<<"wrong id and password\n";
    break;
    //New user
case 3:
//cout<<"Please give your id \n";
ofstream n;
n.open("user.txt",ios::app|ios::binary);

NewUser newuser;
newuser.menu();

n.write((char*)&newuser,sizeof(newuser));[/u]



    }

return 0;
}

[cire]

n.write((char*)&newuser,sizeof(newuser));

Don't do this. newuser is not a primitive type. This is not safe.

I would strongly suggest that you quit trying to treat your text files as binary files. ios::app which means "write to the end of the file" makes no sense to supply to an ifstream which is a file opened only for input.

[abeginner23235616]

Thanks I found my mistake, I actually placed newuser (the instance ) instead of the class name.

[Chervil]

That may be another mistake. But the one pointed out by cire is the main problem.

[abeginner23235616]

I have removed them, but now I have faced another problem.


http://www.cplusplus.com/forum/general/134108/

Please help me out.

Thanks in advance

[cire]

You have the same problems already enumerated here. One wonders why you bothered starting a new thread.

[abeginner23235616]

Oh sorry. I was a little ignorant.
But as you said, i removed all the ios::app from the input streams.
But I am still stuck. (its able to read the id though.)

[cire]

But as you said, i removed all the ios::app from the input streams.

That was the least of your problems.

cire wrote:

n.write((char*)&newuser,sizeof(newuser));

Don't do this. newuser is not a primitive type. This is not safe.

For the same reason, don't to this: while(obj.read((char*)&us, sizeof(NewUser))){

[abeginner23235616]

what alternative do I have instead of them?
I am sorry, I am an amateur as far as file handling is concerned.

[Avilius]

Store data in the file that the program can use to effectively reconstruct the object without using instance local data such as pointers.