Whats wrong with these lines in my program?

[p33n kenan]

I have a copple of lines in this code that aren't compiling because they give errors. I got help from some guy on the internet and he told me I had to make my code like this. But it isn't working so thats when I got here.

here are the lines:
std::array<RecAbbo, 100> arr;

s = safe(arr.begin(), arr.end());

in.getline( Abbo[i].name, 20 ).ignore( std::numeric_limits< std::streamsize >::max(), '\n' );

in.getline( Abbo[i].surname, 20 ).ignore( std::numeric_limits< std::streamsize >::max(), '\n' );



Here is the total Program so you can see where it goes:

#include <iostream>
#include <cstdlib>
#include <string.h>
#include <fstream>
#include <limits>
#include <string>
#include <array>

using namespace std;

struct RecAbbo{
		std::string name;
		std::string surname; 
		int games;
		int won;
		int same;
		int lost;
		int money;
	}Abbo[100];
	
template<class It>
	
void addp();
void sort();
void sear();
void stat();
void game();
void play(int pl1,int pl2);
void menu();

template<class It>
int safe(It begin, It end);
template<class It>
int writetostruct(It begin, It end);

int main(){
	
	std::array<RecAbbo, 100> arr;
	fstream in,out;
	in.open("data.txt", ios::in);
	out.open("data.txt", ios::out);
	menu();
	in.close();
	out.close();
	}

void menu(){
	bool exit=false;
	int choise;
	cout<<"welcome \n";
	while (exit == false){
		cout<<"==================================================== \n";
		cout<<"please choose \n";
		cout<<"1. add person \n";
		cout<<"2. sort all accounts\n";
		cout<<"3. search a certain person \n";
		cout<<"4. see the avarage games and statics \n";
		cout<<"5. create random game \n";
		cout<<"0. exit program \n";
		cout<<"==================================================== \n";
		cin>>choise;
		cout<<"==================================================== \n";
		switch (choise){
			case 1:
				addp();
				break;
			case 2: 
				sort();
				break;
			case 3: 
				sear();
				break;
			case 4: 
				stat();
				break;
			case 5: 
				game();
				break;
			case 0: 
				exit=true;
				break;
			default: 
				cout<<"please choose one of the numbers given \n";
				break;
			}
		}
	}
void addp(){
	
	int i,s;
	while(Abbo[i].name.empty() != 0 )
		i++;
	cout<<"name: ";
	cin>>Abbo[i].name;
	cout<<"surname: ";
	cin>>Abbo[i].surname;
	Abbo[i].games = 0;
	Abbo[i].won = 0;
	Abbo[i].same = 0;
	Abbo[i].lost = 0;
	Abbo[i].money = 0;
	s = safe(arr.begin(), arr.end());
}
	
void sort(){
	
}

void sear(){
	
}

void stat(){
	int avaragew,avarages,avaragel,avarageg,i=0;
	while (i < 0){
		avaragew = avaragew + Abbo[i].won;
		i++;
	}
	i = 0;
	while (i < 0){
		avarages = avarages + Abbo[i].same;
		i++;
	}
	i = 0;
	while (i < 0){
		avaragel = avaragel + Abbo[i].lost;
		i++;
	}
	i = 0;
	while (i < 0){
		avarageg = avarageg + Abbo[i].games;
		i++;
	}
	avaragew = avaragew/100;
	avarages = avarages/100;
	avaragel = avaragel/100;

	i = 0;
	cout<<"avarage games won				:"<<avaragew<<"%\n";
	cout<<"avarage games with same points			:"<<avarages<<"%\n";
	cout<<"avarage games lost				:"<<avaragel<<"%\n";;
	cout<<"total games played				:"<<avarageg<<" games \n";
}

void game(){
	char name1[20],name2[20],surname1[20],surname2[20];
	int i1, i2, i = 0;
	bool check = false, check2 = false ;
	while (check == false){	
		i1 = rand() % 100;
		i2 = rand() % 100;
		while (check2 == false) 
			if (i1 == i2){
				i2 = (i2 + rand() % 100) - 100;
			} else {
				if (Abbo[i1].name.empty() == 0 || Abbo[i2].name.empty() == 0){
					check2 = false;
				} else {
					check2 = true;
					check = true;
				}
			}
		}
	while (i < 20){
			name1[i] = Abbo[i1].name[i];
			name2[i] = Abbo[i2].name[i];
			surname1[i] = Abbo[i1].surname[i];
			surname2[i] = Abbo[i2].surname[i];
			
			i++;
	}
	Abbo[i1].games++;
	Abbo[i2].games++;
	cout<<"       player 1:     player 2: \n";
	cout<<"game: "<<name1<<surname1<<" VS :"<<name2<<surname2<<endl;
	play(i1,i2);
}
template<class It>
int safe(It begin, It end){
	fstream out;
	out.open("data.txt", ios::out);
	for (It it = begin; it != end; ++it){
		out << (*it).name << " \n";         
		out << (*it).surname << " \n";
		out << (*it).games << " " << (*it).won << " " << (*it).same << " " << 
		(*it).lost << " "<< (*it).money << "\n";
		
	}
	out.close();
	return 0;
}
template<class It>
int writetostruct(It begin, It end){
	fstream in;
	in.open("data.txt", ios::in);
	for (int i=0;i<100; i++){
		in >> std::skipws;  
		in.getline( Abbo[i].name, 20 ).ignore( std::numeric_limits< std::streamsize >::max(), '\n' ); 
		in.getline( Abbo[i].surname, 20 ).ignore( std::numeric_limits< std::streamsize >::max(), '\n' );
		in >> Abbo[i].games >> Abbo[i].won >> Abbo[i].same >> 
        Abbo[i].lost >> Abbo[i].money;
    }
    in.close();
    return 0;
}

void play(int pl1, int pl2){
int i, p1,p2,mode,p1money = 50, p2money = 50;
	bool x = true,z = true;
	while (x){
	cout<<"for easy mode press 1 "<<endl;
	cout<<"for normal mode press 2 "<<endl;
	cout<<"for hard mode press 3 "<<endl;
	cout<<"for beast mode press 4 "<<endl;
	cout<<"choise: ";
	cin>>mode;
	switch (mode)
	{
		case 1:
			i = rand() %100;
			cout<<"number between 1 and 100"<<endl;
			x=false;
			break;
		case 2:
			i = rand() %500;
			cout<<"number between 1 and 500"<<endl;
			x=false;
			break;
		case 3:
			i = rand() %2500;
			cout<<"number between 1 and 2500"<<endl;
			x=false;
			break;
		case 4:
			i = rand() %10000;
			cout<<"number between 1 and 10000"<<endl;
			x=false;
			break;
		default:
			cout<<"please choose again"<<endl;
			break;
	}
	while(z){
		cout<<"player 1: ";
		cin>>p1;
		if(p1 << i)
		cout<<"number is higher"<<endl;
		if(p1 >> i)
		cout<<"number is lower"<<endl;
		cout<<"player 2: ";
		cin>>p2;
		if(p2 << i)
		cout<<"number is higher"<<endl;
		if(p2 >> i)
		cout<<"number is lower"<<endl;
		if (p1 == i){
			cout<<"player 1 has won!!"<<endl;
			Abbo[pl1].won++;
			Abbo[pl2].lost++;
			Abbo[pl1].money = Abbo[pl1].money + p1money;
			z = false;
			} else {
			p1money=p1money-5;
		}
		if (p2 == i){
			cout<<"player 2 has won!!"<<endl;
			Abbo[pl2].won++;
			Abbo[pl1].lost++;
			Abbo[pl2].money = Abbo[pl2].money + p2money;
			z = false;
			} else {
			p2money=p2money-5;
		}
		if (p1money == 0 || p2money == 0){
			Abbo[pl1].same++;
			Abbo[pl2].same++;	
			}
		}
	}
}	

[coder777]

What exactly is the line number and the error message?


In case of the getline problem: It's the wrong one. Use it like so:

getline( in, Abbo[i].surname)

That's the getline for std::string


Line 102: arr is not defined. I guess you want to use Abbo like so:

s = safe(Abbo, Abbo + i);

Line 90: you need to initialize i = 0 otherwise you'll have an invalid/random number

Line 38 is useless. Remove it (you need C++11 for that)

[iQChange]

So you post the errors lines but doesn't post the errors itself ?

[p33n kenan]

I'm sorry, didn't think about that. Here you go anyway:

line 38:
structure.cpp:38: error: ‘array’ is not a member of ‘std’
structure.cpp:38: error: expected primary-expression before ‘,’ token
structure.cpp:38: error: ‘arr’ was not declared in this scope

line 65:
structure.cpp:65: error: no matching function for call to ‘addp()’

line 102:
structure.cpp:102: error: ‘arr’ was not declared in this scope

line 198:
structure.cpp:198: error: no matching function for call to ‘std::basic_fstream<char, std::char_traits<char> >::getline(std::string&, int)’

line 199:
structure.cpp:199: error: no matching function for call to ‘std::basic_fstream<char, std::char_traits<char> >::getline(std::string&, int)’

[coder777]

For line 65: remove line 21

The rest: see above