Help with counting Characters !

[yacinebenz]

Hi I'm working on a program that determine the number of Characters, Operators, Uppercase letters, and Numerical digits. The following code seems correct to me but steel doesn't work propriety, someone can help me?

#include <iostream>
#include <string>
#include <fstream>
#include <cstdlib> 
using namespace std ;


int main() {
	char text;
	int Characters = 0;
	int  Operators = 0;
	int Uppercase_letters = 0;
	int Numerical_digits = 0;

	ifstream inFile;
	inFile.open("input_for_p3.txt");

 // Checking if the input file exists. If he do not , the program stop
	if (inFile.fail()) {
		cout << "No input file found!" << endl ;
		cin.get(); 
		return 0;

		while (!inFile.eof()) {

		inFile >> text ;
		if (text  >= 'A' && text <= 'Z') {
			Uppercase_letters++; 
		}
		else if (text >= '0' && text <= '9') { 
        Numerical_digits++; 
        } 

		else if (text =='+' || '-' || '/' || '*' || '%')  { 
        Operators++; 
        } 
        
		else
         {
             Characters++; 
         }

       } 
		cout << Uppercase_letters << endl;
		cout << Numerical_digits << endl;
		cout << Operators << endl;
		cout << Characters++ << endl;
		}
	cin.get(); 
	}

	

[long double main]

You have pretty much all of your code inside the if (inFile.fail()) block.

There should be a } after the return 0; on line 22.
(Then get rid of the one on line 48.)

Also, instead of

while (!inFile.eof()) {
    inFile >> text ;

use this:

while (inFile >> text) {
    // ... 

[yacinebenz]

I still do not get the correct answer. this is my input file

This is a possible factorial function in a programming language called LISP

(defun factorial (n)
(if (< n 2)
1
(* n (factorial (1- n)))))

and this is the output

5
3
105
0

[j3Rz8vqX]

The third part of your if conditional branching needs to re-compare against "text" every time.

else if (text =='+' || '-' || '/' || '*' || '%')  { //<---Modify this then it will work 

Other than that everything else is fine.

The count is good, it just simply never makes it past the third if condition.

[yacinebenz]

how am I suppose to modify that ?

[j3Rz8vqX]

Hint: Added a few more text(s):

else if (text =='+' || text == '-' || text == '/' || '*' || '%')  { //<---Go! all the way!