Ongoing Yahtzee program issues

[Mylar]

I posted a Yahtzee program about two days ago and modified to work properly.
The program will roll 5 dice on command and then ask the user if they wish to reroll. Answering "y" makes the 5 dice reroll. However, Answering "n" will bring up a message asking if the user wants to roll each dice individually. Saying no to that terminates the program, but saying yes initiates a selective reroll and then loops the program back to ask if the user wants to reroll all 5 dice at once.

It is a project that has been coded to meet requirements, such as creating a file, using arrays, loops, and functions.

Understandably, it is hard to keep track of everything going on in this program. I can't really shrink it down. The code will compile as is.

#include <iostream>
#include <fstream>   //for files
#include <stdlib.h>  //for rand/srand
#include <time.h>    //for time
using namespace std;
int rollDice();
int straight = 0; // A counter to track how many straights have been rolled
void display(int num);
bool askToReroll();
bool singleReroll();
bool response1();
bool response2();
bool response3();
bool response4();
bool response5();
int valueT;
int valueU;
int valueV;
int valueW;
int valueX;


int main() {

  srand(time(NULL));
  int total;
  bool rollAgain;
  bool singleRoll;
  bool rollRepeat;
  bool roll1;
  bool roll2;
  bool roll3;
  bool roll4;
  bool roll5;

  cout << "Welcome to the Yahtzee challenge. See if you can roll 5 of a kind." << endl;

do{
   do {
   if (rollAgain == false && singleRoll == true) display(total);
   else {
   total = rollDice();
   display(total); }
   rollAgain = askToReroll();
   } while (rollAgain == true);

 singleRoll = singleReroll();
 if (singleRoll == true) {
 int t = valueT;
 int u = valueU;
 int v = valueV;
 int w = valueW;
 int x = valueX;

 int rollSingle(int t, int u, int v, int w, int x);
 int die[5] = {t, u, v, w, x};

 roll1 = response1();
 if (roll1 == true) {
 int t = 0;
   t += rand() % 6 + 1;
   cout << "New 1st number: " << t << endl;
   die[0] = t; }
  else {
  die[0] = valueT;
  cout << "1st number unchanged: " << t << endl; }

 roll2 = response2();
 if (roll2 == true) {
 int u = 0;
   u += rand() % 6 + 1;
   cout << "New 2nd number: " << u << endl;
   die[1] = u; }
  else {
  die[1] = valueU;
  cout << "2nd number unchanged: " << u << endl; }

 roll3 = response3();
 if (roll3 == true) {
 int v = 0;
   v += rand() % 6 + 1;
   cout << "New 3rd number: " << v << endl;
   die[2] = v; }
  else {
  die[2] = valueV;
  cout << "3rd number unchanged: " << v << endl; }

 roll4 = response4();
 if (roll4 == true) {
 int w = 0;
   w += rand() % 6 + 1;
   cout << "New 4th number: " << w << endl;
   die[3] = w; }
  else {
  die[3] = valueW;
  cout << "4th number unchanged: " << w << endl; }

 roll5 = response5();
 if (roll5 == true) {
 int x = 0;
   x += rand() % 6 + 1;
   cout << "New 5th number: " << x << endl;
   die[4] = x; }
  else {
  die[4] = valueX;
  cout << "5th number unchanged: " << x << endl; }

 int y = t+u+v+w+x;

   total = y;
}
// feed the program back into the AskToReroll function
// if the single roll has been completed
// otherwise, make a file and terminate 
// Creation of Yahtzee file

  ofstream out("Yahtzee.txt");
  out << "Thank you for taking the Yahtzee challenge." << endl;
  out.close();

  return 0;
}

 int rollDice() {
 int die[5] = {0};
 int t = 0;
   t += rand() % 6 + 1;
   cout << "1st number: " << t << endl;
   die[0] = t;
   valueT = t;

 int u = 0;
   u += rand() % 6 + 1;
   cout << "2nd number: " << u << endl;
   die[1] = u;
   valueU = u;

   int v = 0;
   v += rand() % 6 + 1;
   cout << "3rd number: " << v << endl;
   die[2] = v;
   valueV = v;

   int w = 0;
   w += rand() % 6 + 1;
   cout << "4th number: " << w << endl;
   die[3] = w;
   valueW = w;

   int x = 0;
   x += rand() % 6 + 1;
   cout << "5th number: " << x << endl;
   die[4] = x;
   valueX = x;

   int y = t+u+v+w+x;
   return t, u, v, w, x, y;
   }

  void yahtzee(int t, int u, int v, int w, int x, int y) {
  if (t==u && u==v && v==w && w==x && x==y)
  cout <<"Yahtzee! " << endl;
  int straight = straight + 1;

  }

  void display(int num) {
  cout << "Your total is: " << num << endl;
  cout << "You have rolled straights " << straight << " times." << endl;
  }

  bool askToReroll() {
  char yesno;
  cout << "Roll again? (y/n): ";
  cin >> yesno;

  if (yesno == 'y')
    return true;

  return false;

}

bool singleReroll() {
  char yesno;
  cout << "Pick the dice you wish to roll instead? (y/n): ";
  cin >> yesno;

  if (yesno == 'y')
    return true;


 return false;
 if (singleReroll() == 0) {return 0; }
}

// 5 boolean functions to roll the dice separately

bool response1() {
char yesno;
  cout << "Roll the 1st number again? (y/n): ";
  cin >> yesno;

  if (yesno == 'y')
    return true;

  return false;
}

bool response2() {
char yesno;
  cout << "Roll the 2nd number again? (y/n): ";
  cin >> yesno;

  if (yesno == 'y')
    return true;

  return false;
}

bool response3() {
char yesno;
  cout << "Roll the 3rd number again? (y/n): ";
  cin >> yesno;

  if (yesno == 'y')
    return true;

  return false;

bool response4() {
char yesno;
  cout << "Roll the 4th number again? (y/n): ";
  cin >> yesno;

  if (yesno == 'y')
    return true;

  return false;
}

bool response5() {
char yesno;
  cout << "Roll the 5th number again? (y/n): ";
  cin >> yesno;

  if (yesno == 'y')
    return true;

  return false;
}

The problem begins if you try to roll the dice individually twice or more. One The values do not remain unchanged between rolls.

Say a user rolls 1, 2, 3, 4, 5, and then wants to reroll dice 3. Then they get 1, 2, 6, 4, 5.

However, asking to do another individual reroll somehow makes all the numbers change regardless of what the user wants to do. I am not sure where my error is.

[MiiNiPaa]

I can't really shrink it down

ORLY?
response[1-5] can be combined into single function. Actually all "ask" functions can be made one.
You do not need 5 bools in your main, one is enough. Actually you do not need them at all.
Asking for a reroll 5 times is better made into loop or even another function.
If you will get rid of global state, you will get rid of respective errors too.

return t, u, v, w, x, y; is nonsense and can be simplified to return y;. Your compiler should scream and cry bloody tears at that.

Also your code is not compiling as-is. It has some glaring syntax errors in it.

EDIT: spent 15 minutes refactoring code. Now it has 75 lines and your bug dissapeared somewhere.

[Mylar]

When I said I couldn't shrink the code down, I meant that I had to be careful about simplifying the program so that it doesn't exclude certain features. It must meet these requirements:

- uses at least one if test (some form of if, if/else, else if)
- uses cin/cout
- contains at least one loop,
- houses at least one functions
- uses at least one arrays
- creates a file

Now, what you said about syntax errors puzzles me. This code worked for me in PuTTY on a full-screen display. However, I know some bits of code are lengthy and may not fit on one line if they are viewed in a smaller display. If that was the problem, I understand.

Can you give me a sampling of the modifications you made? You've given me an idea of what you did, but I would be thankful if I could actually see the new code for a reference.

And yes, the return line is gobbledygook. I did not know whether to delete it or not until I got a second opinion. This was tiresome to troubleshoot.

[MiiNiPaa]

It must meet these requirements:

It is actually hard to make program not meet those requirements.

Now, what you said about syntax errors puzzles me. This code worked for me in PuTTY on a full-screen display.

You are missing closing brackets in main() and response3() at least.

Can you give me a sampling of the modifications you made?

HEre:

bool ask(const std::string& question)
{
    std::cout << question;
    char answer;
    std::cin >> answer;
    return 'y' == std::tolower(answer);
}

int main()
{
    srand(time(nullptr));
    std::array<int, 5> dice;
    std::cout << "Welcome to the Yahtzee challenge. See if you can roll 5 of a kind." << std::endl;
    do {
        roll_all(dice);
        display(dice);
    } while(ask("Do you want to roll again?\n"));
    while (ask("Do you want to roll individually?\n")) {
        individual_roll(dice);
        display(dice);
        while(ask("Do you want to roll again?\n")) {
            roll_all(dice);
            display(dice);
        }
    }
    show_result(std::accumulate(dice.begin(), dice.end(), 0));
    std::ofstream out("Yahtzee.txt");
    out << "Thank you for taking the Yahtzee challenge." << std::endl;
}

[Mylar]

Thank you.