Beginner Help

[syranol]

I am practicing with functions and I made a simple calculator that calculates addition,subtraction,multiplication and division. When I tried to output the result, I was unable to receive the correct value. I highly suspects that my problem is within the function userinput.

Here is my code.

using namespace std;

#include <iostream>
#include <string>

// We are making a simple calculator using multple functions.

int userinput(int x,int y,int z);
int add(int x,int y);
int subtraction(int x,int y);
int multiply(int x,int y);
int division(int x,int y);

int main()
{
    int first,second,choice,z;
    
    cout << "Please select your option, ";
    cout << "add - 1, minus - 2, multiply - 3, division - 4" << endl;
    cin >> choice;
    cout << "Enter first number: ";
    cin >> first;
    cout << "Enter second number: ";
    cin >> second;
    cout << "You choosed option " << choice << ", and your result is " 
    << z << ".";
    z = userinput(choice,first,second);
    return 0;
}

int userinput(int x, int y, int z) //Compile results and return the answer
{
    int result;
    
    if ( x == 1)
    {
        result = add(y,z);
    }
    else if ( x == 2)
    {
        result = subtraction(y,z);
    }
    else if ( x == 3)
    {
        result = multiply(y,z);
    }
    else
    {
        result = division(y,z);
    }
    
    return result;
}
int add(int x,int y)
{
    int z;
    
    z = x + y;
  
    return z;
}
int subtraction(int x,int y)
{
    int z;
    
    z = x - y;
    
    return z;
}
int multiply(int x, int y)
{
    int z;
    
    z = x * y;

    return z;
}
int division(int x,int y)
{
    int z;
    
    z = x / y;
    
    return z;
}

[long double main]

You're outputting the value of z before you actually calculate it.

Try moving line 27 above line 25.

[syranol]

Thanks! I was too focused on the UserInput function to notices it. :[

[Mizfizz]

Also as you're a Begginer you mite not know this

But never use namespace std in big programmes it causes errors
If you continue with it you'll get a habit every time you use something from
The standard libary use std::

The reason it's bad it can cause errors from two namespaces search it up