Issue with returning variables with if statments

[FredYates]

Ive been getting an odd error with this code when I try to compile it, as well as Im not quite sure as how to return my variable "compType" as a char type.


Main

#include <iostream>
#include "Shape.h"
#include <iomanip>
#include <cmath>

using namespace std;



void inputShape( char shape)
{
	cout << "Select a Shape (1) sphere (2) cylinder (3) cone (q) quit: "<< endl;
	cin >> shape;

	if ( shape == SPHERE)
	{
		
		void inputDimension (double&);
		{
			double radius = 0.0;
			cout << "Enter radius: " << endl;
			cin >> radius;
	
		}

	}
	else if (shape == CYLINDER)
	{

			void inputDimension (double&, double&);
		{
			double radius = 0.0;
			cout << "Enter radius: " << endl;
			cin >> radius;

			double height = 0.0;
			cout << "Enter height: " << endl;
			cin >> height;
	
		}

		
	}
	else if (shape == CONE)
	{

		void inputDimension (double&, double&);
		{
		double radius = 0.0;
			cout << "Enter radius: " << endl;
			cin >> radius;

			double height = 0.0;
			cout << "Enter height: " << endl;
			cin >> height;
		}

	}
	else if ( shape == QUIT)
	{
		cout << "Good bye!" << endl;
	}
	else
	{
		cout << "Invalid Entry, Good bye!" << endl;
}


void inputDimension (double&);
{
	double radius = 0.0;
	cout << "Enter radius: " << endl;
	cin >> radius;
	
}


void inputDimension (double&, double&); 
{

	double radius = 0.0;
	cout << "Enter radius: " << endl;
	cin >> radius;
	
	double height = 0.0;
	cout << "Enter height: " << endl;
	cin >> height;
	
}

char inputCompType();
{
	int compType;
	cout << "Select a Computation (1) volume (2) surface area: " << endl;
	cin >> compType;

	if( compType == 1)
		compType = VOLUME;
	else if ( compType == 2)
		compType = SURFACE_AREA;

	
}


void performComputation (char, double);
{
	
	


}


void performComputation (char, char, double, double);

{


}



int main();

{
	char shape = '0';
	char compType = '0';
    double radius = 0.0;
    double height = 0.0;
   
	// Call inputShape function to request the first shape
	char inputShape();

	
     // type or ‘q’ and return result to the shape variable 

	 // Loop until the user specifies QUIT for the shape type
	
	
	
 
		// if Spheres:
	if ( inputShape() == SPHERE)
	{
		// Call the appropriate inputDimension function
		// to request the radius
		void inputDimension(double&);


		// Call the inputCompType function to request 
		// the computation type and return result to 
		// the compType variable
		char inputCompType();



		// Call the appropriate performComputation
		// function to compute and display the result
		void performComputation (char, double);



// end if Spheres 

	}	


// If Cylinders or Cones:
	 if (inputShape() == CONE || CYLINDER)
	{
		// Call the appropriate inputDimension function
		// to request the radius and height
		char inputCompType();


		// Call the inputCompType function to request 
		// the computation type and return result to 
		// the compType variable
		void inputDimension(double&, double&);

		// Call the appropriate performComputation
		// function to compute and display result

		void performComputation (char, char, double, double);

		// end if Cylinders or Cones
	}
	





	 // Call inputShape function to request the next shape 
	// type or ‘q’ and return result to the shape variable 

	 if ( inputShape() == QUIT)
	{
		cout << "Good bye!" << endl;
	}


 


     // end loop

     system("pause");
     return 0;
}

.H

const double PI = 3.141593;
const char SPHERE = '1';
const char CYLINDER = '2';
const char CONE = '3';
const char QUIT = 'q';
const char VOLUME = '1';
const char SURFACE_AREA = '2';

[kingkong200]

Well there is a fair amount of issues I see here. So I will start off with any time your say double& when you actually mean

void someFunction (double& something) {
something = 1; 
} 

int main () {
double something; 
someFunction (something); 
cout << something; 
return 0; 
} 

and the output if I remember this stuff correctly should be 1;

This being said passing a reference when it is a double or a int is pretty much pointless as passing copies takes up just as much time/memory as pointers to int and so forth.

The second thing is if you write a function don't keep rewritting it like at line 31, 48. You rewrote a function that already exists all you had to do was write a function prototype above input shape. Like so...

 
#include <libraries> 
using namespace std; 

void inputDimension (double something, double otherthing)

// then  in your inputshape function
if ( shape == SPHERE)
	{
		
		void inputDimension (double something, double otherThing); // this is all you need to use this function. 
		

	}

Also, don't change number of function arguments if inputDimension calls for two arguments then input two arguments. Otherwise, you have a different function or you can pass a hard coded argument and then ignore it. I point this out because you do so in line 19 where is should be similar to line 31 or write a different function with a different name that only uses one function argument. Yes, that statement is also direction at your two different performComputation functions...

Furthermore, I don't understand why you are using 1 as a char just keep as an int your making it harder on yourself.

Also, there are some problems in your main, for example:

 
char inputShape();

Quite simply this is error. Perhaps you might to have

char returnedStatement = inputShape()

However, you would have to change your type.

This is the same problem with your if statements such as

 
if ( inputShape() == SPHERE)

Your trying to make a comparison between a char and a void function. This also needs to changed.

Now to the question you were probably looking it depends on the point of function all I see is the assignment of some variables that weren't declared in the function.

I hope this helps and I pray this isn't a troll post....