Infix Calculator

Trying to make an infix calculator but can't figure out what is wrong with this code. Thanks in advance for help.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215


#include <iostream>
#include <cstdlib>
#include <string>
#include <vector>
#include <cmath>
#include <cctype>

using namespace std;

struct Token
{
	union 
	{
		char op;
		double val;
	};

	bool isOp;

	int rank; 
	bool isBracket;
	int bracket_loc;

};
char rankings[2][3]= { {'^', '*', '+'}, {NULL, '/', '-' } };

char brackets[]= { '(' , ')' , '{', '}', '[', '[', '<' , '>'};

bool isOperand(char c)
{
	return (c == '(' || c == ')' || c == '+' || c == '-' || c == '*' || c == '/' || c == '<' || c== '>' || c == '{'
		|| c== '}' || c== '[' || c == ']' || c == '^');
}

double solve (char op, double lhs, double rhs)
{
	switch (op)
	{
		case '^':
			return pow (lhs,rhs);
		case'*':
			return lhs*rhs;
		case '/':
			return lhs/rhs;
		case '+':
			return lhs+rhs;
		case '-':
			return lhs-rhs;
		default:
			cout << "invalid operator" << endl;
			break;
	}
}

template<typename T>
	T get(vector <T> &a)
	{
		T ret= a.back();
		a.pop_back();
		return ret;
	}

	Token val_t(Token &a, int b)
	{
		a.val=b;
		a.isOp=false;
	}
	Token op_t(Token &a, char b)
	{
		a.op=b;
		a.isOp=true;
		for (int i=0; i<2; i++)
		{
			for (int j=0; j<3; j++)
			{
				if (b==rankings[i][j])
				{
					a.rank=j;
				}
			}
		}
		for (int i=0; i<8; i++)
		{
			if (b==brackets[i])
			{
				a.isBracket=true;
				a.bracket_loc=i;
			}
		}
}

bool isNum(string &a, int i)
{
	if (isdigit(a[i]) || a[i]=='.' || (a[i]=='-' && isdigit(a[i+1]) && (!isdigit(a[i-1]) || i==0)  ) )
	{
		return true;
	}
	return false;
	
}

vector <Token> tokenize (string &a)
{
	vector<Token> ret;
	int i=0;
	while (i<a.size())
	{
		if (isNum(a,i))
		{
			double temp= strtod(a.c_str() + i, 0);
			Token buffer;
			ret.push_back(val_t(buffer, temp));

			while (isNum(a,i))
			{
				i++;
			}

		}
		
		else if (isOperand(a[i]) && isNum(a,i-1) && isNum(a,i+1))
		{
			Token buffer;
			ret.push_back(op_t(buffer,a[i]) );
			i++;
		}
		else if (isOperand(a[i]) && (!isOperand(a[i-1]) || (!isOperand(a[i+1]) || i+1==a.size()) ) )
		{
			cout << "Syntax Error" << endl;
			ret.clear();
			break;
		}
		else 
		{
			cout << "Skipping Unknown Character  " << a[i] << endl;
			i++;
		}

	}
	return ret;

}



int main ()
{
	

	begin: 
	string equation;
	cout << "Please Input equation" << endl;
	while (getline(cin,equation))
	{
		
		vector <Token> tokens= tokenize(equation);

		if(tokens.empty())
		{
			goto begin;
		}

		vector<double> values;
		vector<char> op;

		for (int i=0; i<tokens.size(); i++)
		{
			if (tokens[i].isBracket)
			{
				int temp= tokens[i].bracket_loc;

				if (tokens[i].bracket_loc%2==1)
				{
					cout << "Syntax error" <<endl; 
					goto begin;
				}

				while (tokens[i].bracket_loc != temp+1 )
				{
					int rhs=get(values);
					int lhs=get(values);
					char sign = get(op);

					values.push_back(solve(sign,lhs,rhs));

				}
				i++; // Skips end bracket
			}

			else if (isOperand(tokens[i].op))
			{
				op.push_back(tokens[i].op);

				if ( (tokens[i].rank >= tokens[i+1].rank) && (i==0 || (tokens[i].rank>tokens[i-1].rank)) )
				{
					int rhs=get(values);
					int lhs=get(values);
					char sign = get(op);

					values.push_back(solve(sign,lhs,rhs));
				}
			}
		}
		while (!op.empty() )
		{
			int rhs=get(values);
			int lhs=get(values);
			char sign = get(op);

			values.push_back(solve(sign,lhs,rhs));
		}
	}
}
Last edited on
in tokenize(), your test for an operand is wrong. isOperand works, but all that other stuff in the test is breaking the check.
Which part of the test is wrong? And would also like to know on how to improve. Thanks kbw..
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
vector <Token> tokenize (string &a)
{
	vector<Token> ret;
	int i=0;
	while (i<a.size())
	{
		if (isNum(a,i))
		{
			// extract operand
		}		
		else if (isOperand(a[i]) && isNum(a,i-1) && isNum(a,i+1))
		{
			// extract operation, we don't nedd the operand checks here
		}
		else if (isOperand(a[i]) && (!isOperand(a[i-1]) || (!isOperand(a[i+1]) || i+1==a.size()) ) )
		{
			// you mark this as an error, do you really need an extra check here?
		}
		else 
		{
			// you mark this as an error, but you should accept white space
		}
	}
	return ret;
}
Thanks.. Will revise it later. Is that the only mistake?
Tried it already but it still gets an error. Cannot figure out why though. Help will be greatly appreciated
Topic archived. No new replies allowed.