Rational numbers

[largedimples]

Can someone please help!! I have two errors and one warning (listed below)and I am having a hard time correcting them. Any advice will be appreciated!!

#include <iostream>
#include <fstream>
#include <cmath>
using namespace std;

class rational
{
public:
rational(int num, int den);
rational(int num);
rational();

int getnum();
int getden();
void input(istream& in);
void print(ostream& out);
bool less(rational r);

rationalAdd(rational r);

private:
int numerator;
int denomerator;

};

int rational::getnum()
{
return numerator;
}


int rational::getden()
{
return denomerator;
}

rational::rational(int num, int den)
{
numerator = num;
denomerator = den;
}

rational::rational(int num)
{
numerator = num;
denomerator = 1;
}

rational::rational()
{
numerator = 1;
denomerator = 1;
}

int rational::rationalAdd(rational r)
{
rational l;
int a = l.getnum();
int b = l.getden();
int c = r.getnum();
int d = r.getden();
rational result = ((a * d + b * c) / (b * d));
return result;
}

void rational::input(istream& in)
{
int numerator;
int denomerator;
char slash;
cin >> numerator >> slash >> denomerator;
return;
}


void rational::print(ostream& out)
{
cout<<numerator<<"/"<<denomerator;
}


int main()
{
int a, b, c, d;
cout << "Enter a numerator: " << endl;
cin >> a;
cout << "Enter a denominator: " << endl;
cin >> b;
cout << "Enter another numerator: " << endl;
cin >> c;
cout << "Enter another denominator: " << endl;
cin >> d;
rational num1(a, b);
rational num2(c, d);
num1.Add(num2);
num1.print(cout);
system("pause");
return 0;
}

(96): error C2039: 'Add' : is not a member of 'rational'
(64): error C2440: 'return' : cannot convert from 'rational' to 'int'
No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
(19): warning C4183: 'rationalAdd': missing return type; assumed to be a member function returning 'int'

[Dufresne]

Everything explained clearly in error messages.

96): error C2039: 'Add' : is not a member of 'rational'

There's no function named 'Add' in class 'rational' . You have rationalAdd function instead.

and please use code tags.

[tition]

Also, your function int rational::rationalAdd(rational r) doesn't return the sum of the two rational numbers but instead a number with denominator 1, proportional to the desired number (but not equal).

[wmheric]

Unfortunately not every programmer knows one can format forum (esp. C++ forum) posts to make codes more easy to read...and more easy to find which line is which...

#include <iostream>
#include <fstream>
#include <cmath>
using namespace std;

class rational
{
public:
rational(int num, int den);
rational(int num);
rational();

int getnum();
int getden();
void input(istream& in);
void print(ostream& out);
bool less(rational r);

rationalAdd(rational r);

private:
int numerator;
int denomerator;

};

int rational::getnum()
{
return numerator;
}


int rational::getden()
{
return denomerator;
}

rational::rational(int num, int den) 
{
numerator = num;
denomerator = den;
}

rational::rational(int num)
{
numerator = num;
denomerator = 1;
}

rational::rational()
{
numerator = 1;
denomerator = 1;
} 

int rational::rationalAdd(rational r)
{
rational l;
int a = l.getnum();
int b = l.getden();
int c = r.getnum();
int d = r.getden();
rational result = ((a * d + b * c) / (b * d));
return result;
}

void rational::input(istream& in)
{
int numerator;
int denomerator;
char slash;
cin >> numerator >> slash >> denomerator;
return;
}


void rational::print(ostream& out)
{
cout<<numerator<<"/"<<denomerator;
}


int main() 
{
int a, b, c, d;
cout << "Enter a numerator: " << endl;
cin >> a;
cout << "Enter a denominator: " << endl;
cin >> b;
cout << "Enter another numerator: " << endl;
cin >> c;
cout << "Enter another denominator: " << endl;
cin >> d;
rational num1(a, b);
rational num2(c, d);
num1.Add(num2);
num1.print(cout);
system("pause");
return 0;
}

and indentation...


On line 64, you are returning a rational

and as tition mentioned, the RHS of = on line 63 gives you an int, this is not intended.
Instead figure out how you get both the num and the den of the result, then return the result by value.