Code isn't working

closed account (o2ASLyTq)
Hello!

Well, I have an issue again, the thing is that in the second loop I have written s = wtf.at(x-1+i); Now the things is that the program crashes because I got x and i in the same bracket, if I remove x or i the program works perfectly but I get the wrong answer, I need to have both x and i in the bracket, otherwise the answer is wrong. Why isn't it working :/ ?


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
#include <iostream>
#include <sstream>
#include <string>

using namespace std;

int main()
{
	string wtf = "7316717653133062491922511967442657474235534919493496983520312774506326239578318016984801869478851843858615607891129494954595017379583319528532088055111254069874715852386305071569329096329522744304355766896648950445244523161731856403098711121722383113622298934233803081353362766142828064444866452387493035890729629049156044077239071381051585930796086670172427121883998797908792274921901699720888093776657273330010533678812202354218097512545405947522435258490771167055601360483958644670632441572215539753697817977846174064955149290862569321978468622482839722413756570560574902614079729686524145351004748216637048440319989000889524345065854122758866688116427171479924442928230863465674813919123162824586178664583591245665294765456828489128831426076900422421902267105562632111110937054421750694165896040807198403850962455444362981230987879927244284909188845801561660979191338754992005240636899125607176060588611646710940507754100225698315520005593572972571636269561882670428252483600823257530420752963450";
	string s;
	int answer=0, temp;
	int a[5];

	for (int x=1; x<=(wtf.length()); x++)
	{

		for (int i=0; i<5; i++)
		{
			s = wtf.at(x-1+i);
			a[i] = atoi(s.c_str());
		}

		temp = a[0]* a[1]* a[2]* a[3]* a[4];

		if (temp>answer)
			answer = temp;
	}

	cout << "\n\n" << answer << "\n\n";

	return 0;
}


For those that I curious, I am trying to solve the 8th problem from projecteuler.
Last edited on
You are not checking whether the digits are consecutive. Also the loop should be like this :
for (int x=1; x<=(wtf.length() -5 ); x++);
Since you don't want to go beyond the string lenth while getting the 5 digits.
at() will return an exception out_of_range when you try to access such a character. e.g. when x=999 and i=2
closed account (o2ASLyTq)
Well, any ideas how I can get a consecutive loop / if-statement?

I did modify the code a bit however.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
#include <iostream>
#include <sstream>
#include <string>

using namespace std;

int main()
{
	string wtf = "7316717653133062491922511967442657474235534919493496983520312774506326239578318016984801869478851843858615607891129494954595017379583319528532088055111254069874715852386305071569329096329522744304355766896648950445244523161731856403098711121722383113622298934233803081353362766142828064444866452387493035890729629049156044077239071381051585930796086670172427121883998797908792274921901699720888093776657273330010533678812202354218097512545405947522435258490771167055601360483958644670632441572215539753697817977846174064955149290862569321978468622482839722413756570560574902614079729686524145351004748216637048440319989000889524345065854122758866688116427171479924442928230863465674813919123162824586178664583591245665294765456828489128831426076900422421902267105562632111110937054421750694165896040807198403850962455444362981230987879927244284909188845801561660979191338754992005240636899125607176060588611646710940507754100225698315520005593572972571636269561882670428252483600823257530420752963450";
	string s;
	int answer=0, temp=0;
	int a[5];

	for (int x=1; x<=(wtf.length()-4); x++)
	{

		for (int i=0; i<5; i++)
		{
			s = wtf.at(x-1+i);
			a[i] = atoi(s.c_str());

			if(i==4)
				temp = a[0]* a[1]* a[2]* a[3]* a[4];
			if (temp>answer)
				answer = temp;
		}
	}

	cout << "\n\n" << answer << "\n\n";

	return 0;
}
Topic archived. No new replies allowed.