What's wrong with my code?

closed account (o2ASLyTq)
Hello!

This is my first post and I am wondering, what's wrong with the code written below? I get an error message that says "R6010 -abort() has been called"

I am actually trying to write the biggest palindrome out of a three digit number. I know there probably are easier ways but I haven't learned those codings and I am just trying to solve this problem from the knowledge that I already have. So I am not intrested in using reverse or something like that, just want to know what I have done wrong?

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
 
#include <iostream>
#include <sstream>

using namespace std;

int main()
{
	int answer;
	for (int x=0; x<1000; x++)
	{
		for (int i=0; i<1000; i++)
		{
			string xi;
			stringstream out;
			out << x*i;
			xi = out.str();

			if ((xi.length())==5 && xi.at(5)==xi.at(1) && xi.at(4)==xi.at(2))
				answer = x*i;

			if ((xi.length())==6 && xi.at(6)==xi.at(1) && xi.at(5)==xi.at(2) && xi.at(4)==xi.at(3))
				answer = x*i;
		}
	}

	cout << endl << "The biggest palindrome for a three digit number is: " << answer << endl << endl;

	return 0;
}


Greetings!
Last edited on
ne555 (10692)
array's index starts in 0, so they end in size-1
closed account (o2ASLyTq)
I don't know if this is what you meant but I solved it anyway. I forgot that the length is 5 and the biggest pos = 4 and not 5, so I had to decrease the pos with 1 number on all of them.

However the whole things gave a wrong answer, here is the right one if somebody is intrested:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
 
#include <iostream>
#include <sstream>

using namespace std;

int main()
{
	int random, answer=0;
	for (int x=0; x<1000; x++)
	{
		for (int i=0; i<1000; i++)
		{
			string xi;
			stringstream out;
			out << x*i;
			xi = out.str();

			if ((xi.length())==5 && xi.at(4)==xi.at(0) && xi.at(3)==xi.at(1))
			{
				random = x*i;
				if (random>answer)
					answer = random;
			}

			if ((xi.length())==6 && xi.at(5)==xi.at(0) && xi.at(4)==xi.at(1) && xi.at(3)==xi.at(2))
			{
				random = x*i;
				if (random>answer)
					answer = random;
			}
		}
	}

	cout << endl << "The biggest palindrome for a three digit number is: " << answer << endl << endl;

	return 0;
}
Last edited on
S G H (2638)
@dawoodr:
That's exactly what he meant.
To access the first item, you should use index 0.
To access the fifth item, you should use index 4.
Accessing an item you have no access to, will crash your program.
Topic archived. No new replies allowed.