Please Check the Code and he1pme

[ishii]

Kindly Check the Code Given Below and add comments where necessary and also Use of Hungarian Notation where its necessary......


Code is for User Login



#include <iostream>
using std::cout;
using std::cin;
using std::endl;
#include <fstream>
using std::ifstream;
#include <string>
using std::string;
string readString(ifstream&);
int main(int argc, char *argv[])
{
char UserID[80];
char Pass[80];
string line_in;
string::size_type pos;
ifstream fp_in;
int count = 0;
string UserID_Pass[100][2];
fp_in.open("Users.txt");

if(fp_in == NULL)
{
cout << "Could not open user file, exiting."<<"\n";
return -1;
}

while(!fp_in.eof())
{
line_in=readString(fp_in);
if(line_in.length() > 0)
{
pos = line_in.find("\t",0);
if( pos != string::npos)
{
UserID_Pass[count][0] = line_in.substr(0,pos);
UserID_Pass[count][1] = line_in.substr(pos+1);
count++;
}
}
}
fp_in.close();
if(!count > 0)
{
cout << "User List is Empty, exiting" <<"\n";
return -2;
}
int logged_in=0;
while(!logged_in)
{
cout << "Enter User ID: ";
cin >> UserID;
cout << "Enter Password: ";
cin >> Pass;
int found = 0;

for(int x=0;x<count && !found;x++)
{

if(UserID_Pass[x][0].compare(UserID) == 0)
{
found = 1;
if(UserID_Pass[x][1].compare(Pass) == 0)
{
found = 1;
logged_in = 1;
}
else
{
cout << "Invalid Password!" <<"\n";
}
}
}
if(!found)
{
cout << "Invalid Username!" <<"\n";
}
}
cout << "Logged in Successfully!" <<"\n";
return 0;
}
string readString(ifstream& reader)
{
char buffer[256];
reader.getline(buffer,256);
string str1 = buffer;
return str1;
}

[S6k9GNh0]

#include <iostream>
#include <fstream>
#include <string>

using namespace std; //If you using a majority of the std namespace, there's really a point in using this. 

string readString(ifstream& reader) 
{
	char buffer[256];
	reader.getline(buffer,256);
	string str1 = buffer;
	return str1;
}

int main(int argc, char *argv[]) 
{
	char UserID[80];
	char Pass[80]; //You have strings! Use C++ or C based strings!
	string line_in;
	string::size_type pos;
	ifstream fp_in;
	int count = 0; 
	string UserID_Pass[100][2];
	fp_in.open("Users.txt"); 

	if(fp_in == NULL) 
	{
		cout << "Could not open user file, exiting."<<"\n";
		return -1;
	}

	while(!fp_in.eof()) 
	{ 
		line_in=readString(fp_in); 
		if(line_in.length() > 0) 
		{
			pos = line_in.find("\t",0); 
			
			if( pos != string::npos) 
			{ 
				UserID_Pass[count][0] = line_in.substr(0,pos);
				UserID_Pass[count][1] = line_in.substr(pos+1);
				count++;
			}
		}
	}
	
	fp_in.close();
	if(!count > 0)
	{
		cout << "User List is Empty, exiting" <<"\n";
		return -2;
	}
	
	int logged_in=0;
	while(!logged_in) 
	{ 
		cout << "Enter User ID: ";
		cin >> UserID;
		cout << "Enter Password: ";
		cin >> Pass;
		int found = 0;

		for(int x=0;x<count && !found;x++) 
		{ 

			if(UserID_Pass[x][0].compare(UserID) == 0) 
			{ 
				found = 1;
				if(UserID_Pass[x][1].compare(Pass) == 0) 
				{ 
					found = 1;
					logged_in = 1;
				}
				
				else 
				{
					cout << "Invalid Password!" <<"\n";
				}
			}
		}
		
		if(!found) 
		{
			cout << "Invalid Username!" <<"\n";
		}
	}
	
	cout << "Logged in Successfully!" <<"\n";
	return 0; 
}

NOTE: Just posting code and I'll add as I see errors and wronging in the code!