Random Num Generator

[CloudIsland]

Hello,
I am trying to make a random number generator to simulate a critical hit if the number generated is from 0-critical amount. However, every time i run the code, despite being within the parameters set by the if statements, it always runs through as a critical hit and never a regular hit.

#include <iostream>
#include <iomanip>
#include <ctime> 
#include <cstdlib> 
using namespace std;

int main(){

	srand((unsigned)time(0));
	int R;
	double critical, damage, hit;
	critical = 30.00;
	damage = 10.00;

// Attempt 1
R = (rand()%100);
cout << R << endl;

if (R>=0||R<=critical){
	cout << "Critical hit! 2x damage" << endl;
	hit = damage*2;
	cout << hit << endl;
}

else if (R>critical){
	cout << "Regular hit. 1x damage\n" << endl;
	hit = damage;
	cout << hit << endl;
}

// Attempt 2
cout << endl;
R = (rand()%100);
cout << R << endl;

if (R>=0||R<=critical){
	cout << "Critical hit! 2x damage" << endl;
	hit = damage*2;
	cout << hit << endl;
}

else if (R>critical){
	cout << "Regular hit. 1x damage\n" << endl;
	hit = damage;
	cout << hit << endl;
}

// Attempt 3
cout << endl;
R = (rand()%100);
cout << R << endl;

if (R>=0||R<=critical){
	cout << "Critical hit! 2x damage" << endl;
	hit = damage*2;
	cout << hit << endl;
}

else if (R>critical){
	cout << "Regular hit. 1x damage\n" << endl;
	hit = damage;
	cout << hit << endl;
}

// Attempt 4
cout << endl;
R = (rand()%100);
cout << R << endl;

if (R>=0||R<=critical){
	cout << "Critical hit! 2x damage" << endl;
	hit = damage*2;
	cout << hit << endl;
}

else if (R>critical){
	cout << "Regular hit. 1x damage\n" << endl;
	hit = damage;
	cout << hit << endl;
}
}

There are four attempts to save time in getting a good result. Please help.

Thanks,
CloudIsland

[condor]

What's for condition R>=0 in each if (R>=0||R<=critical) ? As you defined R it will result a number between 0 and 99 so this condition is superfluous. Delete it please.

[MikeyBoy]

if (R>=0||R<=critical)

Look it this condition. Can you think of any values of R that would cause it to ever be false?

[condor]

@MikeyBoy

if you want to keep the condition R >= 0 then if (R>=0||R<=critical) must be modified:

if (R>=0 && R<=critical) and also rests superfluous but works!...Please try both cases and see.

[MikeyBoy]

I think you want to direct that to the OP, not me :)

[condor]

Obviously, if I'm wrong is my fault, of course!

[CloudIsland]

@condor
@MikeyBoy

Thanks mates, I guess thats why you don't program at 2am aha. Took out the R>=0 and everything works perfectly!