C++

Forum

 
Need help with ifstream insertion with white space delimited data

zmarchbank (20)
I'm doing a project that takes in a input file with Quarterback statistics. It has their name, team, completions, sacks, touchdowns, etc. It has 16 different variables in all (17 if you count first/last name as two). So I'm trying to read them and I can't figure out how to jump to the new line after it's read the file and put the information in the variables I've created.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
 
#include <iostream>
#include <fstream>

using namespace std;

ifstream din;

void openFile()
{
    string filename;
    cout << "Enter name of file with QB statistics" << endl;
    cin >> filename;

    din.open(filename.c_str());
    if (din.fail())
       {
        cout << "Failed to open file. Aborting program" << endl;
        return;
       }


}

int main()
{
    openFile();
    int count = 0;
    int games, attempts, completions, yards, lng, tds, ints, sacks, sackYL;
    float attperg, compct, yrdsgame, rating;
   string first_name, last_name, team, pos;
   din >> first_name >> last_name >> pos >> games >> attempts >> attperg >> completions >> compct >> yards >> yrdsgame >> lng >> tds >> ints >> sacks >> sackYL >> rating;
   while (count < 5)
   {
      cout << first_name << " " << last_name << " " << pos << " " << games << " " << attempts << " " << attperg << " " << completions << " " << compct << " " << yards << " " << yrdsgame << " " << lng << " " << tds << " " << ints << " " << sacks << " " << sackYL << " " << rating << endl;
      din >> first_name >> last_name >> pos >> games >> attempts >> attperg >> completions >> compct >> yards >> yrdsgame >> lng >> tds >> ints >> sacks >> sackYL >> rating;
      count++;
   }
   din.close();
    return 0;
}


That's the program I've written. The loop keeps displaying the first line of the file over and over. How can I get it to go to the second line, then the third, then fourth, etc? I need it to display all the lines of the file until it reaches the end of the file. I've looked everywhere but can't seem to find the answer. Thanks in advance.
ENIGMAx (84)
Have you tried using something like getline()?

http://www.cplusplus.com/reference/string/string/getline/
AdrianH (82)
Not sure what you mean. This works fine. (though I would recommend that you

1. don't use a global variable for your file handle.
2. return the file handle and do the test in main().

Not doing so will cause a problems that will occur if there is something wrong when opening the file. That or use a try/catch statement.)

Using the following input file:

abc def 1 2 3 4 5 6 7 8 9 10 11 12 13 14
def def 2 2 3 4 5 6 7 8 9 10 11 12 13 15
ghi def 3 2 3 4 5 6 7 8 9 10 11 12 13 16
jkl def 4 2 3 4 5 6 7 8 9 10 11 12 13 17
mno def 5 2 3 4 5 6 7 8 9 10 11 12 13 18
pqr def 6 2 3 4 5 6 7 8 9 10 11 12 13 19
stu def 7 2 3 4 5 6 7 8 9 10 11 12 13 20


I had no problems. Maybe you should post your input file.

AFAICT, there is nothing that would cause you din line from working properly as it doesn't care about line breaks, it breaks on one or more consecutive whitespaces when reading from text file, which include linefeeds, carriage returns, spaces and tabs.

Last edited on
AdrianH (82)
I would probably also recommend removing the din outside of the loop and swap the cout/din inside the loop as there is no need for that extra code.
zmarchbank (20)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
 
Charlie Batch		QB	PIT	2	70	35.0	45	64.3	475	237.5	43	1	4	3	12	64.9
Sam Bradford		QB	STL	16	551	34.4	328	59.5	3702	231.4	80	21	13	35	233	82.6
Tom Brady		QB	NE	16	637	39.8	401	63.0	4827	301.7	83	34	8	27	182	98.7
Drew Brees		QB	NO	16	670	41.9	422	63.0	5177	323.6	80	43	19	26	190	96.3
Jason Campbell		QB	CHI	6	51	8.5	32	62.7	265	44.2	45	2	2	6	49	72.8
Matt Cassel		QB	KC	9	277	30.8	161	58.1	1796	199.6	46	6	12	19	101	66.7
Kirk Cousins		QB	WAS	3	48	16.0	33	68.8	466	155.3	77	4	3	3	27	101.6
Jay Cutler		QB	CHI	15	434	28.9	255	58.8	3033	202.2	60	19	14	38	250	81.3
Andy Dalton		QB	CIN	16	528	33.0	329	62.3	3669	229.3	59	27	16	46	229	87.4
Ryan Fitzpatrick	QB	BUF	16	505	31.6	306	60.6	3400	212.5	68	24	16	30	161	83.3
Joe Flacco		QB	BAL	16	531	33.2	317	59.7	3817	238.6	61	22	10	35	227	87.7
Nick Foles		QB	PHI	7	265	37.9	161	60.8	1699	242.7	46	6	5	20	131	79.1
Josh Freeman		QB	TB	16	558	34.9	306	54.8	4065	254.1	95	27	17	26	161	81.6
Blaine Gabbert		QB	JAC	10	278	27.8	162	58.3	1662	166.2	80	9	6	22	158	77.4
Robert Griffin-III	QB	WAS	15	393	26.2	258	65.6	3200	213.3	88	20	5	30	217	102.4
Matt Hasselbeck		QB	TEN	8	221	27.6	138	62.4	1367	170.9	37	7	5	14	103	81.0
Chad Henne		QB	JAC	10	308	30.8	166	53.9	2084	208.4	81	11	11	28	169	72.2
Brian Hoyer		QB	ARI	2	53	26.5	30	56.6	330	165.0	53	1	2	4	30	65.8
Colin Kaepernick	QB	SF	13	218	16.8	136	62.4	1814	139.5	57	10	3	16	112	98.3
Kevin Kolb		QB	ARI	6	183	30.5	109	59.6	1169	194.8	46	8	3	27	159	86.1
Byron Leftwich		QB	PIT	2	53	26.5	25	47.2	272	136.0	37	0	1	3	24	54.9
Matt Leinart		QB	OAK	2	33	16.5	16	48.5	115	57.5	20	0	1	1	9	44.4
Thaddeus Lewis		QB	CLE	1	32	32.0	22	68.8	204	204.0	23	1	1	3	14	83.3
Ryan Lindley		QB	ARI	6	171	28.5	89	52.0	752	125.3	28	0	7	12	91	46.7
Jake Locker		QB	TEN	11	314	28.5	177	56.4	2176	197.8	71	10	11	25	151	74.0
Andrew Luck		QB	IND	16	627	39.2	339	54.1	4374	273.4	70	23	18	41	246	76.5
Eli Manning		QB	NYG	16	536	33.5	321	59.9	3948	246.8	80	26	15	19	136	87.2
Peyton Manning		QB	DEN	16	583	36.4	400	68.6	4659	291.2	71	37	11	21	137	105.8
Colt McCoy		QB	CLE	3	17	5.7	9	52.9	79	26.3	21	1	0	4	25	85.2
Greg McElroy		QB	NYJ	2	31	15.5	19	61.3	214	107.0	30	1	1	11	71	79.2
Matt Moore		QB	MIA	2	19	9.5	11	57.9	131	65.5	37	1	0	2	9	96.6
Cam Newton		QB	CAR	16	485	30.3	280	57.7	3869	241.8	82	19	12	36	244	86.2
Carson Palmer		QB	OAK	15	565	37.7	345	61.1	4018	267.9	64	22	14	26	199	85.3
Christian Ponder	QB	MIN	16	483	30.2	300	62.1	2935	183.4	65	18	12	32	184	81.2
Terrelle Pryor		QB	OAK	3	30	10.0	14	46.7	155	51.7	38	2	1	0	0	70.8
Brady Quinn		QB	KC	10	197	19.7	112	56.9	1141	114.1	57	2	8	21	123	60.1
Philip Rivers		QB	SD	16	527	32.9	338	64.1	3606	225.4	80	26	15	49	311	88.6
Aaron Rodgers		QB	GB	16	552	34.5	371	67.2	4295	268.4	73	39	8	51	293	108.0
Ben Roethlisberger	QB	PIT	13	449	34.5	284	63.3	3265	251.2	82	26	8	30	182	97.0
Tony Romo		QB	DAL	16	648	40.5	425	65.6	4903	306.4	85	28	19	36	263	90.5
Matt Ryan		QB	ATL	16	615	38.4	422	68.6	4719	294.9	80	32	14	28	210	99.1
Mark Sanchez		QB	NYJ	15	453	30.2	246	54.3	2883	192.2	66	13	18	34	209	66.9
Matt Schaub		QB	HOU	16	544	34.0	350	64.3	4008	250.5	60	22	12	27	216	90.7
John Skelton		QB	ARI	7	201	28.7	109	54.2	1132	161.7	40	2	9	15	98	55.4
Alex Smith		QB	SF	10	218	21.8	153	70.2	1737	173.7	55	13	5	24	137	104.1
Matthew Stafford	QB	DET	16	727	45.4	435	59.8	4967	310.4	57	20	17	29	212	79.8
Ryan Tannehill		QB	MIA	16	484	30.2	282	58.3	3294	205.9	80	12	13	35	234	76.1
Tyrod Taylor		QB	BAL	7	29	4.1	17	58.6	179	25.6	25	0	1	3	30	62.3
Michael Vick		QB	PHI	10	351	35.1	204	58.1	2362	236.2	77	12	10	28	153	78.1
Brandon Weeden		QB	CLE	15	517	34.5	297	57.4	3385	225.7	71	14	17	28	186	72.6
Russell Wilson		QB	SEA	16	393	24.6	252	64.1	3118	194.9	67	26	10	33	203	100.0


That's my input file. I'm not sure what the problem is. This is the output I'm getting:

Enter name of file with QB statistics
qb.txt
Charlie Batch QB 0 -824961602 0 1994048101 -3.95516e-005 2686916 2.20125e+033 26
86712 2686656 4287504 0 0 2.20126e+033
Charlie Batch QB 0 -824961602 0 1994048101 -3.95516e-005 2686916 2.20125e+033 26
86712 2686656 4287504 0 0 2.20126e+033
Charlie Batch QB 0 -824961602 0 1994048101 -3.95516e-005 2686916 2.20125e+033 26
86712 2686656 4287504 0 0 2.20126e+033
Charlie Batch QB 0 -824961602 0 1994048101 -3.95516e-005 2686916 2.20125e+033 26
86712 2686656 4287504 0 0 2.20126e+033
Charlie Batch QB 0 -824961602 0 1994048101 -3.95516e-005 2686916 2.20125e+033 26
86712 2686656 4287504 0 0 2.20126e+033

Process returned 0 (0x0)   execution time : 2.423 s
Press any key to continue.


Edit: Removed the din from outside the loop. Thank you for the advice!
Last edited on
zmarchbank (20)
Figured it out. Forgot to add teams to the din input stream. Thank you guys so much for your help!
AdrianH (82)
Great. Please mark as answered.
Topic archived. No new replies allowed.