While statement not terminating

[Ghilliedrone]

#include "profile.h"
#include "default.h"
#include "Global.h"
#include "c_screen.h"
void profile::gen_prof()
{
	c_screen cObj;
	player_cpu = 0;
	player_weapon = 0;
	player_weapon2 = 0;

	srand(time(NULL));
	player_health = rand() %  20 + 10; //10-30
	player_armor = rand() % 30 + 10; //10 -40
	player_attack = rand() %  10 + 5;//5-15
	player_defence = rand() % 5 + 5;//5-10
	player_magic_power = rand() % 10 + 5;//5-15
	player_magic_gauge = rand () % 20 + 20;//20-40
	

	std::cout<<"What is your name?\n";
	std::getline(std::cin,name);
	cObj.ClearScreen();

	while (player_weapon>3||player_weapon<1){
		//couts here
		std::cin>>player_weapon;
		cObj.ClearScreen();
	}


	while (player_cpu > 3||player_cpu < 1){
                //couts here
		std::cin>>player_cpu;
		cObj.ClearScreen();
	}

	if (player_cpu == 1)
		player_armor +=10;	
	else if (player_cpu == 2){
		while (player_weapon2 >3||player_weapon2 <1){
                        //couts here
			std::cin>>player_weapon2;
			cObj.ClearScreen();
		}
	}
	else if (player_cpu == 3){
		player_attack += 10;
	}
}

When I test this code the program starts to loop at the first while and never stop, no matter what I enter. Is there something I'm doing wrong? If you need to know the variables I'm inputting are global variables in another file(Global.h)

[theranga]

the loop itself seems fine, i think the problem is in cscreen::ClearScreen().

[Ghilliedrone]

Removing that statement didn't do anything.

[theranga]

Does it actually ask you for your weapon?

[theranga]

This is my code:

#include <iostream>
#include <cstdlib>
using namespace std;

void clearScreen ()
{return;} // do nothing

int main ()
{
    int player_weapon=0;

    clearScreen ();
    while (player_weapon<1 || player_weapon>3)
    {
         cout << "Enter a valid weapon: ";
         cin >> player_weapon;
         clearScreen();
    }

    system ("pause");
    return 0;
}

When I run this, it works fine. But, if I change clearScreen to be:

void clearScreen ()
{while(true);} // infinite loop 

it doesn't do any output, it just infinite loops.

[Ghilliedrone]

That doesn't really help. When my code reaches the while, it keeps asking for the players weapon choice. Even if you choose in its selection, it repeats anyways. The ClearScreen class doesn't affect other classes like this one.

[theranga]

Sorry but I actually have no idea why it does that.

[Ghilliedrone]

I fixed it, i need ' ' around the numbers being compared

[theranga]

oh right.

is player_weapon a char?

[mutexe]

input from the command line will be.