- Forum
- General C++ Programming
- Tic Tac Toe Program
Tic Tac Toe Program
Pages: 12
pleaseeee tell me ur opinon and ur suggestions
I borrowed from jason's code to my code like : board[3][3] , Thanks Jason :)
NEW CODE :
I borrowed from jason's code to my code like : board[3][3] , Thanks Jason :)
NEW CODE :
|
|
Last edited on
Having spaghetti code is the problem :)
It is a good practice to avoid using gotos as much as possible to avoid disjointed code.
Did you try to even compile the code?
you need int main()
you can't have a variable name the same as the data type'
change all of your 'and's and 'or's to && and ||
and ect.
It is a good practice to avoid using gotos as much as possible to avoid disjointed code.
Did you try to even compile the code?
|
|
you need int main()
win win[2][9]you can't have a variable name the same as the data type'
change all of your 'and's and 'or's to && and ||
and ect.
Last edited on
okay will do now :D sry still beginner
about main()
yea my compile can compile it with no bugs
new code ... i hope it compiles with no errors :D
about main()
yea my compile can compile it with no bugs
new code ... i hope it compiles with no errors :D
Last edited on
your game plays ok.
but you most remember that readability is of utmost importance.
You format is consistent, but with the lack of white space it's very hard for somebody recognize your logic and suggest changes.
I have reformatted you code:
but you most remember that readability is of utmost importance.
You format is consistent, but with the lack of white space it's very hard for somebody recognize your logic and suggest changes.
I have reformatted you code:
Last edited on
Thanks for advice Jason and i hope i use ur advice well and thanks for reformatting my code :) i replaced mine code with yours :D
Last edited on
I found a little bug ,if you enter a non-integral number the program prints Enter (...) ERROR infinitely and you should also have some way to exit the program
Last edited on
yea i know , and if you entered a string that would happen too , cuz the variables are integers so you can't enter decimal or string , actually i can't resolve this problem cuz if i changed int to float still you can enter string and the same would happen .
When I made tic-tac-toe in the console I avoided that problem by making them input to a char variable then checking if it was valid, and if so assign the proper values to two integers. I.e if the char was
'1' the integer would then be 1 because it would check what the char was. |
|
Last edited on
Well , nice idea :D iam going to make it soon i will post the new code
btw try the game and criticize it please :D
and WHY I CAN'T POST THE CODE Q_Q
always get ERROR:CONTENT LONG
btw try the game and criticize it please :D
and WHY I CAN'T POST THE CODE Q_Q
always get ERROR:CONTENT LONG
Last edited on
Last edited on
this part is really funny: line 74-82
if you want a random number between 1 and 3 all you need to do is
(rand() % 3) + 1;
this gives you theoretically 33 percent chance to get either one of them, notice that what your doing your more likely to get 1 or 2 then three.
youll get 2 if the rand()%10 returns you 2,6,7,8 but youll get 3 only if it returns 3,9, (this is caused because of the flooring when dividing ints). funny stuff. also you dont need to seed all the time, you only need to do it once! this is a constantly accessible function and you are seeding way to many times, so basically you only need to seed once in the beginning of main and that should be enough.
|
|
if you want a random number between 1 and 3 all you need to do is
(rand() % 3) + 1;
this gives you theoretically 33 percent chance to get either one of them, notice that what your doing your more likely to get 1 or 2 then three.
youll get 2 if the rand()%10 returns you 2,6,7,8 but youll get 3 only if it returns 3,9, (this is caused because of the flooring when dividing ints). funny stuff. also you dont need to seed all the time, you only need to do it once! this is a constantly accessible function and you are seeding way to many times, so basically you only need to seed once in the beginning of main and that should be enough.
Last edited on
another tip,
all your functions share the
then why not make int array of infos and turns global? you did it with the two dimensional array of victories, then why not these?
all your functions share the
return foo(infos *info , int turns)then why not make int array of infos and turns global? you did it with the two dimensional array of victories, then why not these?
Thanks for tips bro :) if you find any more stupid things please mention it
Last edited on
we should all make tic tac toes and have them play against each other lol
btw lord ahmad, if you want to really really improve your code.
consider changing the way you store the board.
i mean, instead of having an array of 10 infos, maybe have a two dimensional array of chars representing the board?
char board[3][3];
where board[x][y] can be either 'X','O',or ' '.
anyways your way good too just not for this particular task, since you dont really need to know the past history of moves, so you dont really need to save who did what moves, theoretically you only need the current position on the board and whos turn it is. And that should be what the computer AI is based on.
I also noticed your PutInOrder(...) function, the games seems to work without this function in the main loop but it has a bug. Try fixing the bug without having to sort the entire history of moves all the time,( you probably just forgot to update the members of info somewhere ). Because you see, programming is like medicine, you want to treat the source of the problem and not the symptom. If you write code2 to fix bugs of code then you might need code3 to fix the bugs of code2 and then you'll just need code4 to fix the bugs in code3 and so on, so its always better to just fix the bugs without adding new code segments.
btw lord ahmad, if you want to really really improve your code.
consider changing the way you store the board.
i mean, instead of having an array of 10 infos, maybe have a two dimensional array of chars representing the board?
char board[3][3];
where board[x][y] can be either 'X','O',or ' '.
anyways your way good too just not for this particular task, since you dont really need to know the past history of moves, so you dont really need to save who did what moves, theoretically you only need the current position on the board and whos turn it is. And that should be what the computer AI is based on.
I also noticed your PutInOrder(...) function, the games seems to work without this function in the main loop but it has a bug. Try fixing the bug without having to sort the entire history of moves all the time,( you probably just forgot to update the members of info somewhere ). Because you see, programming is like medicine, you want to treat the source of the problem and not the symptom. If you write code2 to fix bugs of code then you might need code3 to fix the bugs of code2 and then you'll just need code4 to fix the bugs in code3 and so on, so its always better to just fix the bugs without adding new code segments.
Last edited on
Jason , there is a bug in your game
try to play against cpu and put '5' then '1' and u will see
char board[3][3] !! Wonderful idea :D I used it in my new code
thanks Tiny I have done what you said and I fixed PutInOrder bug there is no more this function
try to play against cpu and put '5' then '1' and u will see
char board[3][3] !! Wonderful idea :D I used it in my new code
thanks Tiny I have done what you said and I fixed PutInOrder bug there is no more this function
Last edited on
Just a very small thing:
and & or are valid C++11 code- although everyone is much more used to && and ||
| jasonXcoder wrote: |
|---|
| change all of your 'and's and 'or's to && and || |
and & or are valid C++11 code- although everyone is much more used to && and ||
NEW CODE PLEASEEEEE TELL ME UR OPINION
(Its up in the topic :D)
You are right TheIdeasMan :D
(Its up in the topic :D)
You are right TheIdeasMan :D
Last edited on
ok, the new code looks great, and very appealing to play too. good job.
some improvements to your code without actually changing anything in the design.
1: line 300 -
2: line 174 -
you could just do
3: function counter(), line 26 -
its unnecassary to turn wf into x, you could just pass wf inside, or called the argument in the function x. like this.
the argument name in the function defenition dont have to match the argument name in the function call.
4: line 153 - the outer while(true) is unnecessary
5: line 167 - the check if l!=1 is unnecessary
6: true programmers start counting at zero!
all your arrays are one size bigger then what they are supposed to be, on the possitive side you can start counting like a human being from 1, but then again we are not humans, we be programmers++.
some improvements to your code without actually changing anything in the design.
1: line 300 -
//Table(); is not necassary. you do Table later anyway.2: line 174 -
|
|
b = a = f; I love concatenating assignment.3: function counter(), line 26 -
|
|
its unnecassary to turn wf into x, you could just pass wf inside, or called the argument in the function x. like this.
|
|
the argument name in the function defenition dont have to match the argument name in the function call.
4: line 153 - the outer while(true) is unnecessary
5: line 167 - the check if l!=1 is unnecessary
6: true programmers start counting at zero!
|
|
all your arrays are one size bigger then what they are supposed to be, on the possitive side you can start counting like a human being from 1, but then again we are not humans, we be programmers++.
Pages: 12