Bubblesort Template

[NoobUser]

I keep getting this error no matter how much I change sort. This are 3 separate files header, CPP, and main.

#ifndef _MYFLOAT_H
#define _MYFLOAT_H
#include  <iostream>
using namespace std;
template <class X> void BS(X nums, int size);
class myFloat
{
    float x;
    float y;
public:
    myFloat ();
    myFloat (float, float);
    void setX(float);
    void setY(float);
    float getX();
    float getY();
    ostream friend & operator<<(ostream &, myFloat);
    bool operator>(myFloat);
};
#endif

#include "myfloat.h"

myFloat::myFloat()
{
    x = 0;
    y = 0;
}
myFloat::myFloat(float a,float b)
{
    x = a;
    y = b;
}
void myFloat::setX(float a)
{
    x=a;
}
void myFloat::setY(float b)
{
    y=b;
}
float myFloat::getX()
{
    return x;
}
float myFloat::getY()
{
    return y;
}
ostream & operator<<(ostream &out, myFloat i)
{ 
    out << " x = " << i.getX() << " y = " << i.getY() << endl;
    return out;
}
bool myFloat::operator>(myFloat)
{
    if (x > y)
    return true;
    else
    return false;
}
template <class X>
void BS(X nums, int size)
{
    for(int x=1; x<size; x++)
    for(int b= 0; b< size - x; b++){
    if(nums[b] > nums[b + 1]){
    swap(nums[b], swap[b+1]);
}
}
}
#include "myfloat.h"
#include <iostream>
#include <string>
using namespace std;

int main()
{ 
    myFloat x;
    myFloat y;

    x.setX(5);
    y.setX(9);
	
    cout << x << y;
    BS(x,y);
    cout << x << y;
 system("pause");
	return 0;
}

error LNK2019: unresolved external symbol "void __cdecl BS<class myFloat>(class myFloat,class myFloat)" (??$BS@VmyFloat@@@@YAXVmyFloat@@0@Z) referenced in function _main

[Rehan FASTian]

Where is myname.h?
you don't need to include myfloat.h because you're working on the same .cpp file.

[Rehan FASTian]

Post your Errors

[Bourgond Aries]

I think you must inline the functions in a templated class.

[Nobun]

The error you posted is generated becouse, in line 5, you declared only the prototype of "template <class X> void BS" (the function will be defined in line 62, instead).

I suggest to remove line 5 and to move the declaration of template function from line 62 to line 5...

However, after doing so, your code probably will be again open to problems... I am not sure about it, but I don't think that code will work properly

X nums, infact, will be passed as value... so I don't think you can really treat "nums" as an array.

Probably you would prefer to pass X * nums instead (passing nums as a pointer will allow you to treat nums as an array).

However, also after doing this, I see a possible code vulnerability... that

 if(nums[b] > nums[b + 1])

can generate a segmentation fault problem (or index out of range, of similar)... BEFORE EVEN TRY TO COMPARE an element with the following one, you must be sure that actually exists another element, else even the "if" instruction alone will return a memory error message (like the ones I mentioned).