linkd List

[alexander07]

The assignment is to store 5 names with the ID Number using linklist but the problem with my code
is that the last name is start repeating
Example Run
Entre un Nombre
juan
Entre un Nombre
jose
Entre un Nombre
carlos
Entre un Nombre
jesus
Entre un Nombre
alexander
ID:5 Nombre :alexander
ID:4 Nombre :alexander
ID:3 Nombre :alexander
ID:2 Nombre :alexander
ID:1 Nombre :alexander

/ main.ccp
#include<iostream>
#include<cstdio>
using namespace std;
#include "lista.h"


int main() {
    lista cadenas;
    char respuesta[50];
    char nombre[50];
    
    
    
   
   for(int i=1;i<=5;i++){      
         cout<<"Entre un Nombre"<<endl;
         cin>>nombre;
         cadenas.listaCreate(i,nombre);
   }
  cadenas.mostrar(); 
    
    
    return 0;
};

/ source.ccp


#include<cstdlib>
#include<iostream>


#include "lista.h"

using namespace std;

lista::lista(){
    head=NULL;
    current=NULL;
    
};
void lista::listaCreate(int ID, char *tmp){
    struct nodo*ptr;
    ptr=(struct nodo*)malloc(sizeof(struct nodo));
    
    ptr->data=ID;
    ptr->name=tmp;
    if(head==NULL){
        head=ptr;
        head->next=NULL;
    }
    else
    {
        
        ptr->next=head;
        head=current=ptr;
     }
   
  
  
    
   
};

 

void lista::mostrar(){
    struct nodo*ptr = head;
    
   
    while(ptr !=NULL){
        cout<<"ID:"<<ptr->data <<" Nombre :"<<ptr->name<<endl;
        ptr=ptr->next;
     
         }
};

/lista.h

#ifndef LISTA_H
#define LISTA_H


class lista 
{
    private:
        struct nodo
        {
            int data;
            char *name;
            struct nodo*next;

        };

        nodo*head;
        nodo*current;

    public:
        lista();
        void listaCreate(int x,char *y);
        void mostrar();
};

#endif

[ne555]

`ptr->name=tmp;' is copying the pointers. You want to copy the content instead.
I suggest you to use `std::string' and `std::list'

[alexander07]

Can you be a little more specific or give a example

[ne555]

1 2 3 4 5 6 7 8

#include <iostream> int main(){ char array[] = {"hello"}; char *ptr; ptr = array; ptr[0] = 'x'; std::cout << array << '\n'; }

xello

[alexander07]

Thanks a lot you resolve my problems I change everything to string
Hire my code

#include<iostream>
#include<cstdio>
using namespace std;
#include "lista.h"



int main() {
lista cadenas;
string nombre;




for(int i=1;i<=2;i++){
cout<<"Entre un Nombre"<<endl;
cin>>nombre;
cadenas.listaCreate(i,nombre);
}
cadenas.mostrar();





return 0;
};

#include<cstdlib>
#include<iostream>


#include "lista.h"

using namespace std;

lista::lista(){
head=NULL;
current=NULL;

};
void lista::listaCreate(int ID, string tmp){
struct nodo*ptr;
ptr=(struct nodo*)malloc(sizeof(struct nodo));

ptr->data=ID;
ptr->name=tmp;

if(head==NULL){
head=ptr;
head->next=NULL;

cout << head->name << " Data has been created\n";
}
else
{
struct nodo*ptmp;
ptmp=(struct nodo*)malloc(sizeof(struct nodo));

ptmp = head;
ptmp->next = NULL;
cout << ptmp->name << " Temp data created.";

head = ptr;
cout << ptr->name << "New data created.";
ptr->next=ptmp;


}

};


#ifndef LISTA_H
#define LISTA_H


class lista
{
private:
struct nodo
{
int data;
std::string name;
struct nodo*next;

};

nodo*head;
nodo*current;

public:
lista();
void listaCreate(int x,std::string y);
void mostrar();



};

#endif