Need help displaying an average for each entry

[tcshowmore]

I have to display an average for each student that is entered can someone please help with fixing my code

void StudentData::displayAverageScore() {

double totalScore = 0;

double totalEx1 = 0, totalEx2 = 0, totalEx3 = 0, averageScore = 0;

for(int i = 0; i < entries.size(); i++) {

totalEx1 += entries[i].getEx1();// accumulate totals

totalEx2 += entries[i].getEx2();

totalEx3 += entries[i].getEx3();

 if(totalScore != 0) averageScore = (totalEx1 + totalEx2 + totalEx3) / 3; // don't divide by 0

 cout << "Average Score For Exams: " << setprecision(1) << fixed << averageScore << endl << endl;

}



}

[Aceix]

In this code, totalscore is always 0 therefore the if statemenf will never be executed.

Aceix.

[Smac89]

This ^

[MiiNiPaa]

USe not accumulator, but current entry data: averageScore = (entries[i].getEx1() + /*...*/) / 3;

[tcshowmore]

Thanks for the help getting the average to work , but I still need help getting it to average for each student entered. If the full code would help I can post it

[Aceix]

Why not.

Aceix.

[tcshowmore]

#include <iostream>
#include <string>
#include <vector>
#include <fstream>
#include <iomanip>
using namespace std;

class Student { // keep this class simple and to a minimum

public:
	Student(string firstN, string lastN, double ex1, double ex2, double ex3);
	string getFirstN();
	string getLastN();
	double getEx1();
	double getEx2();
	double getEx3();
private:
	string firstN;
	string lastN;
	double ex1;
	double ex2;
	double ex3;

};

Student::Student(string fn, string ln, double e1, double e2, double e3) {

	firstN = fn;
	lastN = ln;
	ex1 = e1;
	ex2 = e2;
	ex3 = e3;

}

string Student::getFirstN() {

	return firstN;

}

string Student::getLastN() {

	return lastN;

}

double Student::getEx1() {

	return ex1;

}

double Student::getEx2() {

	return ex2;

}

double Student::getEx3() {

	return ex3;

}

class StudentData {
	public:
		StudentData();
		void loadDataFromFile();
		void addStudent();
		void deleteStudent();
		void displayStudentData();
		void displayAverageScore();
		void saveAndExit();

	private:
		vector<Student> entries;// vector of Student objects
};

StudentData::StudentData() {} // default constructor

	void StudentData::loadDataFromFile() {

	string firstN, lastN;
	double ex1, ex2, ex3;

	ifstream studentData;

	studentData.open("studentData.txt"); // open the file

	if(studentData.is_open()) 
	{

		while( studentData >> firstN >> lastN >> ex1 >> ex2 >> ex3 )
		{ 
		Student student(firstN, lastN, ex1, ex2, ex3); // create aStudent object
		entries.push_back(student);

		}

	}
	cout << entries.size() << " Total students entered "<< endl << endl;
	studentData.close();

}

void StudentData::addStudent() {

	string fn, ln;
	double s1, s2, s3;
	char ans;

		do

	{

		cout << " Enter First Name: ";
		cin >> fn;
		cout << " Enter Last Name: ";
		cin >> ln;
		cout << " Enter Score 1: ";
		cin >> s1;
		cout << " Enter Score 2: ";
		cin >> s2;
		cout << " Enter Score 3: ";
		cin >> s3;

		Student temp(fn,ln,s1,s2,s3);
		entries.push_back(temp);

		cout << " Would you like to enter another record? Y or N : ";
		cin >> ans;

		ans = tolower(ans);
		cout << endl << endl;

		}while(ans == 'y');

}

void StudentData::deleteStudent()

{

int index = 0;

cout << "There are " << entries.size() << " records at this time. " ;

if(entries.size() == 0)

{

cout << " No records can be removed. " << endl << endl;

return;

}

else

{

cout << "The names are: " << endl << endl;

for(int i = 0; i < entries.size(); i++)

cout << i + 1 << '\t' << entries[i].getFirstN() << " " << entries[i].getLastN() << endl;

cout << endl << " Enter the number of the file that you wish to delete: 1 through " << entries.size();

cin >> index;

if(index <= 0 || index > entries.size())

{

cout << " The number you entered is not within the proper range." << endl;

 

}

index = index - 1;

for(int i = index; i < entries.size() - 1; i++)

entries[i] = entries[i+1];

entries.pop_back();

}

cout << " There are now " << entries.size() << " records." << endl;

}

void StudentData::displayStudentData(){
	   cout << " There are " << entries.size() << " at this time. " << endl << endl;
    if(entries.size() > 0)
    {
        cout << " RecNum\tFName\tLName\tScore1\tScore2\tScore3\t" << endl;
        for(int i = 0; i < entries.size(); i++)
            cout << " " <<  (i + 1) << "." << '\t' << entries[i].getFirstN()
                                           << '\t' << entries[i].getLastN()
                                           << '\t' << entries[i].getEx1()
                                           << '\t' << entries[i].getEx2()
                                           << '\t' << entries[i].getEx3() << endl;
    }
    cout << endl;
}



void StudentData::displayAverageScore() {

double totalScore = 0;

double getEx1 = 0, getEx2 = 0, getEx3 = 0, averageScore = 0;

for(int i = 0; i < entries.size(); i++) {

getEx1 += entries[i].getEx1();// accumulate totals

getEx2 += entries[i].getEx2();

getEx3 += entries[i].getEx3();

 if(averageScore = (getEx1 + getEx2 + getEx3) / 3); // don't divide by 0

 cout << "Average Score For Exams: " << setprecision(1) << fixed << averageScore << endl << endl;

}



}

void StudentData::saveAndExit() {

ofstream outFile;

outFile.open("studentData.txt");

if(outFile.is_open())

{

for(int i = 0; i < entries.size(); i++)

outFile << entries[i].getFirstN() << '\t'

<< entries[i].getLastN() << '\t'

<< entries[i].getEx1() << '\t'

<< entries[i].getEx2() << '\t'

<< entries[i].getEx3() << endl;

cout << entries.size() << " The records were saved to studentData.txt" << endl << endl;

}

} 

int main() { // test program

StudentData entries; // 
int option;

do {

cout << "----------Menu Options--------------" << endl;

cout << " 1. Load a students records " << endl;

cout << " 2. Enter students name and scores " << endl;

cout << " 3. Display students information " << endl;

cout << " 4. Remove a students information " << endl;

cout << " 5. Display Exam Averages " << endl;

cout << " 6. Save and Exit " << endl;

cout << " Enter your choice 1, 2, 3, 4 ,5 " << endl;

cin >> option;

 

cin.clear();

cin.ignore(50, '\n');

cout << endl;

switch(option) {

case 1:

entries.loadDataFromFile(); // add an entry object to the log

break;

case 2:

entries.addStudent(); // add an entry object to the log

break;

case 3:

entries.displayStudentData(); // display all records

break;

case 4:

entries.deleteStudent();

break;

case 5:

entries.displayAverageScore(); // display average MPG

break;

case 6:

entries.saveAndExit(); // save to file and exit program

break;

default:

cout << "Please enter 1, 2, 3, 4, 5, or 6 : " << endl << endl;

}

} while(option!= 6);

cout << endl;

return 0;

}

[tcshowmore]

These are the direction

1.a loadStudents method that loads a set of student records from a text file into a Student objects and adds each student object to the course vector. Record structure: lName fName ex1 ex1 ex3, separated by spaces or tabs.
2.an addStudent method to add a Student to the Course vector.
3.a displayStudents method that prints a list of all the students names and scores
4.a removeStudent method that removes a Student from the Course vector.
5.a displayAverages method that displays all of the Student's names and their exam averages.
6.a storeData method that stores each student record to a text file and exits the program