URGENT!! Validate Date - user defined functions.

[sam20390]

I am writing an program to validate the date. When I run the program, even the invalid dates (13/32/999) gets validated. Please help!!

#include <iostream>
#include <conio.h>

using namespace std;

void getDate( int&, int&, int&);  
int ckDate( int, int, int);
void displayMsg( int);

int main(){
	int month;
	int day;
	int year;
	int check;

	while(cin){
		getDate(month, day, year);
		check = ckDate(month, day, year);
		displayMsg(check);
	}

	_getch();
	return 0;
}

void getDate(int& m, int& d, int& y){
	cout << "Enter a date (mm/dd/yyyy): ";
	cin >> m >> d >> y;
}

int ckDate (int m, int d, int y){
	int check = 0;

		switch(check){
			case 1:
				if (y < 999 && y > 10000)
				{
					check = 1;
				}	
			break;

			case 2:		
				if (m < 1 || m > 12)
				{
					check = 2;
				}
			break;

			case 3:
				while (m == 1 || m == 3 || m == 5 || m == 7 || m == 8|| m == 10 || m == 12)
					if  (d < 1 || d > 31)
					{
						check = 3;
					}
			break;

			case 4:
				while (m == 4 ||m == 6 || m == 9 || m == 11)
					if (d < 1 || d > 30)
					{
						check = 4;
					}
				break;

			case 5:
				while (m == 2){
					if (y % 400 == 0)
					{
						if (y % 100 == 0 && y % 4 == 0)
						{
							if (d < 1 && d > 29)
							{
								check = 5;
							}
						}
					}
					else if (d < 1 && d > 28)
					{
						check = 6;
					}
				}
			break;
			
			default: 
				check = 0;
		}

	return check;
}

void displayMsg(int check){
	
	if (check == 0)
	{
		cout << "Good Date\n";
	}
	else if (check == 1)
	{
		cout << "Bad Year\n";
	}
	else if (check == 2)
	{
		cout << "Bad Month\n";
	}
	else if (check == 3)
	{
		cout << "Bad Day not 1-31\n";
	}
	else if (check == 4)
	{
		cout << "Bad Day not 1-30\n";
	}
	else if (check == 5)
	{
		cout << "Bad Day not 1-29\n";
	}
	else if (check == 6)
	{
		cout << "Bad Day not 1-28\n" ;
	}
}

[FSchwartz]

How does the valid variable get a value before you pass it to displayMsg()?

[sam20390]

Thats where I'm getting the error from. Also I'm getting error from check variable in ckDate().

[FSchwartz]

Also I'm getting error from check variable in ckDate().

How are you getting the error from the check variable into the valid variable? Have you learned the assignment statement in your C++ class yet?

[sam20390]

No. I meant I'm also getting error in ckDate() too. Not related to displayMsg().

[FSchwartz]

So ckDate() returns the check variable value. Where do you put it? (Or where do you save it?)

[sam20390]

to displayMsg(int check).

[FSchwartz]

int SomeFunction()
{
    int ReturnValue;

    /* Calculate ReturnValue some how. */

    return ReturnValue;
}

int main()
{
    int SomeVariable;

    SomeVariable = SomeFunction();

    /* Now SomeVariable has the value returned from SomeFunction in the ReturnValue variable. */
}

Do you see how that applies to your situation?

[sam20390]

I updated the code. Now I'm getting Good Date message even if I enter invalid date (0/22/2013)

[FSchwartz]

Updated it how? Show code.

What does it do for your original test case of 13/32/999?

[sam20390]

I updated the code in the original post. Good Date message when I enter 13/32/999

[FSchwartz]

In ckDate(), what value is the check variable start with?

So which case in the switch statement is going to be used?

So what value is the check variable going to end with?

So which output message will be displayed in displayMsg()?

By the way, in ckDate(), you have:

				if (y < 999 && y > 10000)
				{
					check = 1;
				}	

For which values of y will the if condition ever be true?

[sam20390]

I changed switch statements to if statements to simplify the ckDate()

int ckDate (int m, int d, int y){
	int check = 0;

				if (y < 999 && y > 10000)
					check = 1;
				
				if (m < 1 || m > 12)
					check = 2;

				while (m == 1 || m == 3 || m == 5 || m == 7 || m == 8|| m == 10 || m == 12)
					if  (d < 1 || d > 31)
					{
						check = 3;
					}
	
				while (m == 4 ||m == 6 || m == 9 || m == 11)
					if (d < 1 || d > 30)
					{
						check = 4;
					}
				
				while (m == 2){
					if (y % 400 == 0)
					{
						if (y % 100 == 0 && y % 4 == 0)
						{
							if (d < 1 && d > 29)
							{
								check = 5;
							}
						}
					}
					else if (d < 1 && d > 28)
					{
						check = 6;
					}
				}