EXE Has Stopped Working

[lmsmi1]

My executable does what it's supposed to, but after everything is completed, it "stops working" and a window pops up on the desktop saying that.

Here's the full code:

#include <iostream>
#include <string>
#include <windows.h>
#include <fstream>
#include <vector>
#include <sstream>

using namespace std;

void SetColor(unsigned short color) {
    HANDLE hcon = GetStdHandle(STD_OUTPUT_HANDLE);
    SetConsoleTextAttribute(hcon, color);
}

BOOL WINAPI SetConsoleIcon(HICON hIcon) {
    typedef BOOL (WINAPI *PSetConsoleIcon)(HICON);
	static PSetConsoleIcon pSetConsoleIcon = NULL;
	if(pSetConsoleIcon == NULL)
		pSetConsoleIcon = (PSetConsoleIcon)GetProcAddress(GetModuleHandle(("kernel32")), "SetConsoleIcon");
	if(pSetConsoleIcon == NULL)
		return FALSE;
	return pSetConsoleIcon(hIcon);
}

int CountWords(string strString)
{
  int nSpaces = 0;
  unsigned int i = 0;

  // Skip over spaces at the beginning of the word
  while(isspace(strString.at(i)))
    i++;

  for(; i < strString.length(); i++)
  {
    if(isspace(strString.at(i)))
    {
      nSpaces++;

      // Skip over duplicate spaces & if a NULL character is found, we're at the end of the string
      while(isspace(strString.at(i++)))
        if(strString.at(i) == '\0')
          nSpaces--;
    }
  }

  // The number of words = the number of spaces + 1
  return nSpaces + 1;
}

void GetTokens(string line) {
    int x = 0;
    string token;
    int y = CountWords(line);
    string tokens[y];
    stringstream ss(line);
    while (getline(ss, token, ' ')) {
        tokens[x] = token;
        x++;
    }
    if (tokens[0] == "color") {
        if (tokens[0] == "-lime") {
            SetColor(10);
        }
    }
}

int main(int argc, char* argv[])
{
    SetConsoleTitle("Cmd2");
    HICON hIcon = LoadIcon(GetModuleHandle(0),"MAINICON");
   	SetConsoleIcon(hIcon);

    if (argc<2) {
        cerr << "Cmd2";
    } else {

        string line;
        string cmd;
        string params;
        string token;
        string tokens[5];

        unsigned int a; // first for loop var.
        unsigned int b = 0; //
        unsigned int c = 0; // Spaces in the string to parse
        unsigned int x = 0;


        ifstream file;
        file.open(argv[1]); // Args start a 0, then go up by 1. argv[0] is the Program path.
        if(!file.is_open()) {
            file.close();
            cout << "Error opening file.";
        } else {
            while(!file.eof()) { // While the file isn't ended
                getline(file, line); // get the command's whole line
                if (!line.empty()) { // If the line isn't empty...
                    for (a = 0; a < line.length(); a++) { // Tranform string to lowercase
                        tolower(line.at(a));
                    }
                    while(isspace(line.at(b))) {
                        b++;

                        for(; b < line.length(); b++) {
                            if(isspace(line.at(b))) {
                                c++;

                                // Skip over duplicate spaces & if a NULL character is found, we're at the end of the string
                                while(isspace(line.at(b++))) {
                                    if(line.at(b) == '\0') {
                                        c--;
                                    }
                                }
                            }
                        }
                    }
                    string tokens[c+1]; // initialize the number of tokens to number of spaces + 1
                    stringstream ss(line);
                    while (getline(ss, token, ' ')) { // add tokens to array
                        tokens[x] = token;
                        x++;
                    }
                    if (tokens[0] == "color") { // check first token (0)
                        if (tokens[1] == "-lime") { // check second token (1)
                            SetColor(10); // do command for the tokenized string read
                            cout << "Command Completed Successfully.\n"; // tell user command was finished
                        }
                    }
                }
            }
            file.close(); // Close File
        }
    }
    getchar();
}

[ne555]

Run it trough a debugger to figure out the line where it crashes.

string tokens[c+1]; is illegal, dimension must be a constant

[lmsmi1]

Oh, silly me, DUH! *facepalm*

Now the program doesn't exit after enter is pressed with getchar();:

#include <iostream>
#include <string>
#include <windows.h>
#include <fstream>
#include <vector>
#include <sstream>

using namespace std;

void SetColor(unsigned short color) {
    HANDLE hcon = GetStdHandle(STD_OUTPUT_HANDLE);
    SetConsoleTextAttribute(hcon, color);
}

BOOL WINAPI SetConsoleIcon(HICON hIcon) {
    typedef BOOL (WINAPI *PSetConsoleIcon)(HICON);
	static PSetConsoleIcon pSetConsoleIcon = NULL;
	if(pSetConsoleIcon == NULL)
		pSetConsoleIcon = (PSetConsoleIcon)GetProcAddress(GetModuleHandle(("kernel32")), "SetConsoleIcon");
	if(pSetConsoleIcon == NULL)
		return FALSE;
	return pSetConsoleIcon(hIcon);
}

int main(int argc, char* argv[])
{
    SetConsoleTitle("Cmd2");
    HICON hIcon = LoadIcon(GetModuleHandle(0),"MAINICON");
   	SetConsoleIcon(hIcon);

    if (argc<2) {
        cerr << "Cmd2";
    } else {

        string line;
        string cmd;
        string params;
        string token;
        string tokens[5];

        unsigned int a; // first for loop var.
        unsigned int b = 0; //
        unsigned int c = 0; // Spaces in the string to parse
        unsigned int x = 0;


        ifstream file;
        file.open(argv[1]); // Args start a 0, then go up by 1. argv[0] is the Program path.
        if(!file.is_open()) {
            file.close();
            cout << "Error opening file.";
        } else {
            while(!file.eof()) { // While the file isn't ended
                b = 0;
                c = 0;
                x = 0;
                getline(file, line); // get the command's whole line
                if (!line.empty()) { // If the line isn't empty...
                    for (a = 0; a < line.length(); a++) { // Tranform string to lowercase
                        tolower(line.at(a));
                    }
                    while(isspace(line.at(b))) {
                        b++;

                        for(; b < line.length(); b++) {
                            if(isspace(line.at(b))) {
                                c++;

                                // Skip over duplicate spaces & if a NULL character is found, we're at the end of the string
                                while(isspace(line.at(b++))) {
                                    if(line.at(b) == '\0') {
                                        c--;
                                    }
                                }
                            }
                        }
                    }
                    c++;
                    string tokens[c]; // initialize the number of tokens to number of spaces + 1
                    stringstream ss(line);
                    while (getline(ss, token, ' ')) { // add tokens to array
                        tokens[x] = token;
                        x++;
                    }
                    if (tokens[0] == "color") { // check first token (0)
                        if (tokens[1] == "-lime") { // check second token (1)
                            SetColor(10); // do command for the tokenized string read
                            cout << "Command Completed Successfully.\n"; // tell user command was finished
                        }
                    }
                    if (tokens[0] == "pause") {
                        getchar();
                    }
                }
            }
            while (file.eof()) {
                file.close(); // Close File
            }
        }
    }
}