Strcmp and strcpy help required

[clarkd]

I can't seem to get it the name sorted, It prints in order it was entered.

 #include <iostream>
#include <stdlib.h>
#include <string.h>
using namespace std;

void Sorted_Names(char Total_Names[][16], int TotalNum)
{
	int i;
	bool Sorted;
	char Temp [16];
	
	do
		{
			Sorted = false;
			TotalNum--;
			for(i = 0; i < TotalNum; i++)
					if(strcmp (Total_Names[i], Total_Names[i + 1]) != 0)
					{
						strcpy (Temp [i], Total_Names[i]);
						strcpy(Total_Names[i], Total_Names[i + 1]);
						strcpy (Total_Names[i], Temp [i]);
						Sorted						= true;
							
					}
				else;
		}
			while(!Sorted);
}


void Enter_Name(int XY)
{
	int		i = 0;
	int		Num;
	char	Total_Names[20][16] = {};
	//char	Name;

	for(Num = 1; Num <= XY; Num++)
		{
			cout << "Enter the " << Num << " Name: ";
			cin >> Total_Names[Num - 1];
//			Total_Names[Num - 1] = Name;
		}
	cout << "\tOriginal Names" << endl;
	for (int i = 0; i < XY; i++)
		cout << '\t' << Total_Names[i] << endl;

	cout << "\n\tSorted Names" << endl;
	Sorted_Names(Total_Names, XY);
	for(int j = 0; j < XY; j++)
		cout << "\t" << Total_Names[j] << endl;
}

int main()
{
	int Ask_Num;

	cout << "How many Names You Wish to Enter (1 to 20): ";
	cin >> Ask_Num;
		if(Ask_Num <= 0)
			{
				cout << "Not Valid Number, Program Terminated" << endl;
				exit(0);
			}
		else if(Ask_Num > 20)
			{
				cout << "Not Valid Number, Program Terminated" << endl;
				exit(0);
			}
		//else if(Ask_Num >= 'A' || Ask_Num <= 'Z' || Ask_Num >= 'a' || Ask_Num <= 'z')
		//	{
		//		cout << "Not Valid Number, Enter a NUMBER: ";
		//		cin >> Ask_Num;
		//	}
		Enter_Name(Ask_Num);
}

[Disch]

if(strcmp (Total_Names[i], Total_Names[i + 1]) != 0)

strcmp will return:

0 - if both strings are identical
less than 0 - if the "right" string comes first
greater than 0 - if the "left" string comes first

Since you are only checking to see if the value is !=0, you are only looking to see if the strings are identical or not. You are not seeing which one would come first.

[clarkd]

I'm sorry I couldn't understand. I'm try to make sure that it start sorting/arranging names alphabetically.

if I understand of what you're saying is that I have to write two more of the if statements to check for greater or less than 0?


Also what if I turn the bool in the if statement to false and other true. would that help?

[plexus]

No. You just need two if() statements. One for strcmp() > 0 and one for strcmp() < 0.
If strcmp() == 0 you don't have to do anything.