Why won't it output to textfile

[EternalTactician]

I got it to input the numbers from a text file and i want output the average in another text file but it does not work. However when i output inside c++ its works.

#include <iostream>
#include <vector>
#include <fstream>
#include <string>
using namespace std;

int main(){


ifstream infile("C:\\infile.txt");
vector<int>vec;
double sum=0;
double average;


if(infile.is_open()){
while(infile.good()){
int line;
infile>>line;
vec.push_back(line);
}
int x=vec.size();

for(int i=0; i<vec.size(); i++){
sum=sum+vec[i];
}

int avg=0;
avg=sum/vec.size();



char lettergrade;
if (avg >= 93){
lettergrade = 'A';
}
else if ((avg >=85) && (avg <93)){
lettergrade = 'B';
}
else if ((avg >=77) && (avg <84)){
lettergrade = 'C';
}
else if ((avg >70) && (avg <76)){
lettergrade = 'D';
}
else {
lettergrade = 'F';
}


infile.close();


fstream outfile("C:\\outfile.txt");
outfile.open("C:\\outfile.txt");


outfile<<" Sum : "<<avg<<" "<<lettergrade<<endl;
cout<<"great sucess";
outfile.close();
cout<<endl;
cout<<endl;
cout<<endl;
}



else{
cout<<"Unable to open the file."<<endl;
}







return 0;

}

[EternalTactician]

btw i also tried removing line 51 it still does not work

[Marcos Modenesi]

This should work: replace from line 58 - 59 with:

ofstream outfile;
outfile.open("outfile.txt");

Don't know why, just checking my personal notes I see it worked for me before.

[EternalTactician]

tried ofstream too still does not work

[Marcos Modenesi]

But the difference is that when i declare ofstream variable, I don't bind it to any file, it's just

ofstream outfile;

instead of:

ofstream outfile("filename.txt");

[Marcos Modenesi]

This is what I'm running (and it works):

#include <iostream>
#include <vector>
#include <fstream>
#include <string>
using namespace std;

int main(){

    ifstream infile("infile.txt");
    vector<int>vec;
    double sum=0;
    double average;

    if(infile.is_open()){
        while(infile.good()){
            int line;
            infile>>line;
            vec.push_back(line);
        }
        int x=vec.size();

        for(int i=0; i<vec.size(); i++){
            sum=sum+vec[i];
        }

        int avg=0;
        avg=sum/vec.size();



        char lettergrade;
        if (avg >= 93){
            lettergrade = 'A';
        }
        else if ((avg >=85) && (avg <93)){
            lettergrade = 'B';
        }
        else if ((avg >=77) && (avg <84)){
            lettergrade = 'C';
        }
        else if ((avg >70) && (avg <76)){
            lettergrade = 'D';
        }
        else {
            lettergrade = 'F';
        }

        infile.close();

        ofstream outfile;
        outfile.open("outfile.txt");

        outfile << " Sum : " << avg << " " << lettergrade << endl;
        cout<<"great sucess";
        outfile.close();
        cout<<endl;
        cout<<endl;
        cout<<endl;
    }
    else {
        cout << "Unable to open the file." << endl;
    }

return 0;
}

[EternalTactician]

but don't you need to specify a location for the file like "C://outfile.txt"?

[Marcos Modenesi]

If you don't, then the file will be created in the same directory where the file with the code lives:

if it's in some place like

C:\User\MyC++Programs\

every needed archive will be looked for or created there, if no relative or absolute path is provided, you can try.

[EternalTactician]

still not working..

[Marcos Modenesi]

mmm... Then I can't help you. I suggest you paste my code and run it .
May be we should go back and try this:

Can you run this code?
Does it work??

#include <iostream>
#include <fstream>
using namespace std;

int main() {
    ofstream test;
    test.open("Testing.txt"); 
    test << "If you see this on the file, this works";
    cout << "Done" << endl;
}

[EternalTactician]

that's not working either

[Marcos Modenesi]

there we go... so does it ouput "done" on the screen?
Do you have permission to create files in the directory where you are trying to?

Now this is more interesting:

 
#include <iostream>
#include <fstream>
using namespace std;

int main() {
    ofstream test;
    test.open("Testing.txt");
    if (test.is_open()){
        test << "If you see this on the file, this works";
        cout << "Done" << endl;
    }
    else  {
        cout << "Could not open file Testing.txt" << endl;
    }
    return 0;
}

[EternalTactician]

okay i disabled my anti virus and everything works great

[Marcos Modenesi]

great!!

You should mark this topic as solved.