// How do I do assign card.substring here???
string value = card.substring(0, card.length() -1);
string suit = card.substring(card.length() -1);
cout << "Please enter a card notation: ";
cin >> card;
I wrote the if condition only to show that you should guarantee that card is not empty. You should not use such declarations inside the if code block because in this case names value and suit will be local relative to it.