structs and functions

[eblader]

hello there, I'm working on a program for my class
I'm using struct and functions
well here is my problem
I made a function that reads from a txt file and that I want to use the variables taken from it for my whole program, I kept on getting errors for the past two days...
been stuck in opening files for a long time, any kind of help is appreciated


headers

#include<iostream>
#include<string>
#include<fstream>
#include<conio.h>
#include<windows.h>
using namespace std;

my struct

struct CARD
{
string name;
string password;
string ID;

}card1, card2;

function prototypes

string LOGIN();
//void MENU();
int WITHDRAW();
int DEPOSIT();
string OPEN();

main function

LOGIN();
OPEN();
cout<<card1.ID<<" "<<card1.name<<" "<<card1.password;//just testing if values return
//MENU(); 

getting main data

string LOGIN()
{
	
	char c = ' ';
    string pass = "";
	cout<<"Enter ID: ";
	cin>>card1.ID;
	cout<<"Enter password: ";
	

	 while((c=getch())!=13) //password masking
           {
            if(c==8)
             {
                     if(pass.length()!=0)
                        {
                            if(true)
                              cout <<"\b \b";
                              pass.resize(pass.length()-1);
                         }
              }
            else if(c==0) 
              {
             getch(); 
             continue;
               }
           else
              {
             pass+=c;
             if(true)
                 cout <<'*';
              }
             }
			card1.password=pass;
	return card1.ID, card1.password;
}

the problem

string OPEN()
{
card1.ID+=".txt"; //file won't open unless there is a .txt at the end


ifstream myfile;
myfile.open(card1.ID.c_str());
	if (myfile.is_open())
	{
		cout<<"\nFile is open";
	}
	else
	{
		cout<<"\nNo such Account exists";
		Sleep(2000);
		system("cls");
		LOGIN();
	}
	
	for(int i=0;i<2;i++) //reading values
	{
		if (i==0)
			getline(myfile, card1.name);
		else if(i==1)
			getline(myfile, card1.password);
		else
			return card1.name, card1.password; 
	
	}
	
}

i have a txt with filename 192168 containg these data

John S. Smith //name
notebook //password
5000 // number

this window pos up and displays the message

Unhandled exception at 0x5AE14F98 (msvcr110d.dll) in ATM FINAL.exe: 0xC0000005: Access violation reading location 0xCCCCCCC0.

[binarybob350]

One problem I see in your OPEN function inside the for loop, the last iteration you want to read in the ID, not return. Since card1 is global you don't need to return anything from this function.

change

else
  return card1.name, card1.password;

to

else
  getline(myfile, card1.ID);

[eblader]

thanks for replying
but this window keeps on popping out

Unhandled exception at 0x5AE14F98 (msvcr110d.dll) in ATM FINAL.exe: 0xC0000005: Access violation reading location 0xCCCCCCC0.

[eblader]

works fine now, changed OPEN() from string to void, thank you binarybob for reminding me that they are global variables...
for a moment there I misread your name to binaryboob ;p

also removed the else

[binarybob350]

One other thing to point out, a function can only return one string.
The return at the end of LOGIN

return card1.ID, card1.password;

only returns the last string, in this case the password. card1.ID does nothing.

[eblader]

thank you very much

edit: changed it to void, still works fine