what is wrong with this program

# include <iostream>
using namespace std;
int main ()
{
int num1, num2, num3, num4, num5;
int num6, num7, num8, num9, num10;

cout<< "Please enter the 10 numbers " <<endl;
cin>> num1;
cin>> num2;
cin>> num3;
cin>> num4;
cin>> num5;
cin>> num6;
cin>> num7;
cin>> num8;
cin>> num9;
cin>> num10;

if (num1 > num2, num3, num4, num5, num6, num7, num8, num9, num10)

{ cout<< "The largest number is" <<num1 <<endl;
}
else
if (num2 > num1, num3, num4, num5, num6, num7, num8, num9, num10)
{ cout<< " The largest number" <<num2 <<endl;}
else
if (num3 > num1, num2, num4, num5, num6, num7, num8, num9, num10)
{cout<< " The largest number" <<num3 <<endl; }
else
if (num4 > num1, num2, num3, num5, num6, num7, num8, num9, num10)
cout<< " The largest number is " <<num4 <<endl;
else
if (num5 > num1, num2, num3, num4, num6, num7, num8, num9, num10)
cout<< "The largest number is " <<num5 <<endl;
else
if (num6 > num1, num2, num3, num4, num5, num7, num8, num9, num10)
cout<< "The largest number is " <<num6 <<endl;
else
if ( num7 > num1, num2, num3, num4, num5, num6, num8, num9, num10)
cout<< "The largest number is " <<num7 <<endl;
else
if ( num8 > num1, num2, num3, num4, num5, num6, num7, num9, num10)
cout<< "The largest number is " <<num8 <<endl;
else
if ( num9 > num1, num2, num3, num4, num5, num6, num7, num8, num10)
cout<< "The largest number is " <<num9 <<endl;
else
cout<< "The largest number is " <<num10 <<endl;


system ("pause");
return 0;
}
The if statement.

If you need to do multiple validations, you need to use logical operators(||, &&, !, etc.)

So with a brute force approach,
1
2
if(num1 > num2 && num1 > num3 && num1 > num4 && num1 > num5 && num1 >  num6 && num1 > num7 && num1 > num8 && num1 > num9 && num1 > num10){
}


But that is ugly and hard to read. So a little suggestion is to store those numbers in an array and use loops(I take it that you're a beginner so I am not suggesting better algorithms).
can you show me a sample of storing in an array
int array[size];
for(int i=0; i<size; ++i)
cin >> array[i];
And when you want to find the biggest value you use this function:
1
2
3
4
5
6
int max=0;
for(int i=0;i<10;i++)
{if(array[i]>max)
{max=array[i];
}}
cout<<"max= "<<max<<endl;
Topic archived. No new replies allowed.