critique my code please

[ryanpeppers]

im currently trying to get the hang of passing/returning structures to and from fuctions and also passing structure addresses.

am doing it right, guys?

#include <iostream>

using std::string;

struct person_struc
{
    string name;
    short age;
};

void displayPerson(const person_struc *p);
person_struc getPerson(short a, string na);

int main()
{
    short bge = 0;
    string Name;
    const int MAX = 3;
    person_struc* X = new person_struc [MAX]; // dynamically allocate a person_struct array the size of 3 (for three "people")
    for (int x = 0;  x < MAX; x++)
    {
        /////////input//////////
        std::cout << "enter name: ";
        std::getline(std::cin, Name);
        std::cout << "enter age: ";
        std::cin >> bge;
        //////////////////////
        std::cin.clear();/////////////////
        std::cin.ignore();// clear and "reset" cin for input values bge and Name
        X[x] = getPerson(bge, Name); /////// fill person_struct array with the Name and bge input values
    }
    std::cout << "\n\n";
    for (int y = 0; y < MAX; y++) //display person_struct array
    {
        displayPerson(&X[y]); //pass the address of the X array element ( y ) to displayPerson
        std::cout << "\n";
    }
    delete [] X; //delete person_struct array
    return 0;
}

void displayPerson(const person_struc *p)
{
    if ((p->name == "bob") && (p->age == 17))
    {
        std::cout << "i knew a " << p->name << " who was once " << p->age << "\n";
    }
    else
    {
        std::cout << "name  |\t" << p->name << "\n";
        std::cout << "age   |\t" << p->age << "\n";
    }
}

person_struc getPerson(short a, string na)
{
    person_struc S;
    S.name = na;
    S.age = a;
    return S;
}

[binarybob350]

It's Ok.

I would get rid of the getPerson method and change

X[x] = getPerson(bge, Name);

to

X[x].name = Name
X[x].age = bge;

Cuts down on extra assignments and structure copies.

Also, another way to write

displayPerson(&X[y]);

is

displayPerson( X+y );