Class function malfunctioning

[chungolongo]

Hey,

Been fiddling with this class called "name_pairs". It has two vectors, one holds names and the other the accompanying age.

Here is the code:

class name_pairs{
protected:
vector<string> name;
vector<int> age;

public:



void read_names(){
string s;
    getline(cin,s);
    name.push_back(s);
    read_age();
}

void read_age(){

    int a;
    cin >> a;
    age.push_back(a);
}

void print_np(name_pairs &np){
    for(int i = 0; i<=np.name.size();i++)
    cout << np.name[i] << ", " << np.age[i] << endl;
}

};

The idea behind read_names is that when a name is entered, one is prompted for an accompanying age. However, if I try this:

name_pairs np;
np.read_names();
np.read_names();

np.print_np(np);

It only stores the first name and age correctly. If I try entering:
Joe
18
Bob

Stops reading and prints:
Joe, 18
, 4078844

On the other hand, if I try feeding it:
16
17
18

It prints;
16, 17
, 18


Any hints would be much appreciated.

[jsmith]

For one thing your for() loop end condition is wrong; it should
be i < np.name.size().

[chungolongo]

For one thing your for() loop end condition is wrong; it should
be i < np.name.size().

Oops, thanks jsmith.


However, I have looked at the code again, and again and found no solution so I'm moving on, for now.

[seymore15074]

One question: are you familiar with STL maps?

[chungolongo]

are you familiar with STL maps?

No, not until you mentioned it. I'm reading the documentation, looks very promising. Thanks!

[chungolongo]

Had a look at map:

Hit the same problem, only being able to store the first pair. Producing same ouput as in the initial post.

[seymore15074]

Right, the problem has to do with mixing getline and operator>>. I'm just addressing the fact that you are manually trying to create a map. :)

Linky:
http://www.cplusplus.com/forum/articles/6046/

[chungolongo]

Right, the problem has to do with mixing getline and operator>>. I'm just addressing the fact that you are manually trying to create a map. :)

*Does happy dance*

Thanks alot mate! It's alive, it's alive!

Furthermore, I now know of a useful container. Twice blessed be I.