EDIT: TicTacToe with win/lose counter and AI

[civilVIU]

I have a beginners tic tac toe program. So far I have my program allowing two players to play, each taking turns until one wins, then asking if you want to play again, if yes, restarting the program.

What im trying to do now is add a counter to count the number of wins for X or for O, or the number of ties. I believe the code needed is correct, but the implementation in my code is wrong (i dont exactly know where to put it, so far i have it in my checkForGameEnd function)


Here is what i tried so far, to try and get the counter to count number of wins or ties. It counts the first win, but then stops counting.. (if i could get help on the counter first, then move on to the AI, that would be appreciated:)

#include <iostream>
#include <string>
#include <cctype>

using namespace std;

//routine to display the current tictactoe baord
void printBoard (string board);

//routine to let player X or O make a move and return the
//  updated board
string pickMove (string board, char player);

bool checkForGameEnd(string board);\

bool playGameAgain();

void newGameDevider();

const int boardSize = 9;

//count the number of filled positions
    int positionsFilled = 0;
    int xWins = 0;
    int oWins = 0;
    int ties = 0;
int main(){

    do {

        string board = "012345678";
        cout << endl;
        printBoard(board);

        cout << endl;
        cout << "(X) for Player X " << endl;
        cout << "(O) for Player O " << endl;
        cout << "Pick which player goes first: ";

        char choiceOfPlayer;
        cin >> choiceOfPlayer;

        if ((choiceOfPlayer == 'X') || (choiceOfPlayer == 'x'))
        {
            char currentPlayer = 'X';
            do {
                //let the current player make a move
                board = pickMove(board, currentPlayer);
                printBoard(board);

                //switch players
                if (currentPlayer == 'X') {
                    currentPlayer = 'O';
                }
                else {
                    currentPlayer = 'X';
                }
            } while (!checkForGameEnd(board));
        }
        else if ((choiceOfPlayer == 'O') || (choiceOfPlayer == 'o'))
        {
            char currentPlayer = 'O';
            do {
                //let the current player make a move
                board = pickMove(board, currentPlayer);
                printBoard(board);

                //switch players
                if (currentPlayer == 'O') {
                currentPlayer = 'X';
                }
                else {
                    currentPlayer = 'O';
                }
            } while (!checkForGameEnd(board));
        }



        }

    if (board[0] == board[1] && board[1] == board[2]) {
        if (board[0] == 'X') {
            xWins++;

        }
        else if (board[0] == 'O') {
            oWins++;

        }
    }
    if (board[3] == board[4] && board[4] == board[5]) {
        if (board[3] == 'X') {
            xWins++;

        }
        else if (board[3] == 'O') {
            oWins++;
        }

    }
    if (board[6] == board[7] && board[7] == board[8]) {
        if (board[6] == 'X') {
            xWins++;

        }
        else if (board[6] == 'O') {
            oWins++;
        }

    }
    if (board[0] == board[3] && board[3] == board[6]) {
        if (board[0] == 'X') {
            xWins++;

        }
        else if (board[0] == 'O') {
            oWins++;

        }
    }
    if (board[1] == board[4] && board[4] == board[7]) {
        if (board[1] == 'X') {
            xWins++;

        }
        else if (board[1] == 'O') {
            oWins++;
        }

    }
    if (board[2] == board[5] && board[5] == board[8]) {
        if (board[2] == 'X') {
            xWins++;

        }
        else if (board[2] == 'O') {
            oWins++;

        }
    }
    if (board[0] == board[4] && board[4] == board[8]) {
        if (board[0] == 'X') {
            xWins++;

        }
        else if (board[0] == 'O') {
            oWins++;

        }
    }
    if (board[2] == board[4] && board[4] == board[6]) {
        if (board[2] == 'X') {
            xWins++;

        }
        else if (board[2] == 'O') {
            oWins++;

        }
    }
    if (positionsFilled == boardSize) {
        ties++;
        cout << endl << "    X WINS: " << xWins << endl;
        cout << "    O WINS: " << oWins << endl;
        cout << "    TIES " << ties;
        cout << endl;
        cout << "**********************************************" << endl;
        cout << endl;

        } while (playGameAgain());
        return 0;
}

//routine to let player x or o make a move and return the updated board
//parameter 'player' contains 'x' or 'o', indicating whose turn it is

string pickMove(string board, char player) {
    //prompt the current player for their move
    cout << endl;
    cout << "Player " << player << "\'s turn" << endl;
    cout << "Pick an unclaimed board position 0-8: ";

    //read in the players choice
    int moveChosen;
    cin >> moveChosen;

    //if not in the range 0-8
    if (moveChosen > 8 || moveChosen < 0) {
        cout << moveChosen << " is an invalid choice, ";
        cout << "your choice must be in the range 0-8" << endl;
        board = pickMove(board, player);
    }
    //if player chooses a spot already taken
    else if (!isdigit (board[moveChosen])) {
        cout << moveChosen << " is an invalid choice, ";
        cout << "you must choose a spot that isnt already taken";
        cout << endl;
        board = pickMove(board, player);
    }
    //otherwise put the players choice on the chosen spot
    else {
        board [moveChosen] = player;
        cout << endl;

        //return the updated board
        return board;
    }
}

//routine to display the current tic tac toe board
void printBoard(string board) {
    //display the top row of the board
    cout << endl << endl;
    cout << "     " << board[0];
    cout << "    |    " << board[1];
    cout << "    |    " << board[2];
    cout << "     " << endl;

    //display the middle row of the board
    cout << "   -------+---------+-------- " << endl;
    cout << "     " << board[3];
    cout << "    |    " << board[4];
    cout << "    |    " << board[5];
    cout << "     " << endl;

    //display the bottom row of the board
    cout << "   -------+---------+-------- " << endl;
    cout << "     " << board[6];
    cout << "    |    " << board[7];
    cout << "    |    " << board[8];
    cout << "     " << endl;
}

//return true if the game is over, false otherwise

[civilVIU]

The rest of the code..(to many characters..)

bool checkForGameEnd (string board) {
    //check if all board positions are full, in which case game is over

    //count the number of filled positions
    int positionsFilled = 0;

    for (int pos = 0; pos < boardSize; pos++) {
        if ((board[pos] == 'X' || (board[pos] == 'O'))) {
            positionsFilled++;
        }
    }

    if (board[0] == board[1] && board[1] == board[2]) {
        if (board[0] == 'X') {
            cout << endl << "GAME OVER, PLAYER X WINS!" << endl;
            return true;
        }
        else if (board[0] == 'O') {
            cout << endl << "GAME OVER, PLAYER O WINS!" << endl;
            return true;
        }
    }
    if (board[3] == board[4] && board[4] == board[5]) {
        if (board[3] == 'X') {
            cout << endl << "GAME OVER, PLAYER X WINS!" << endl;
            return true;
        }
        else if (board[3] == 'O') {
            cout << endl << "GAME OVER, PLAYER O WINS!" << endl;
            return true;
        }
    }
    if (board[6] == board[7] && board[7] == board[8]) {
        if (board[6] == 'X') {
            cout << endl << "GAME OVER, PLAYER X WINS!" << endl;
            return true;
        }
        else if (board[6] == 'O') {
            cout << endl <<"GAME OVER, PLAYER O WINS!" << endl;
            return true;
        }
    }
    if (board[0] == board[3] && board[3] == board[6]) {
        if (board[0] == 'X') {
            cout << endl <<"GAME OVER, PLAYER X WINS!" << endl;
            return true;
        }
        else if (board[0] == 'O') {
            cout << endl << "GAME OVER, PLAYER O WINS!" << endl;
            return true;
        }
    }
    if (board[1] == board[4] && board[4] == board[7]) {
        if (board[1] == 'X') {
            cout << endl <<"GAME OVER, PLAYER X WINS!" << endl;
            return true;
        }
        else if (board[1] == 'O') {
            cout << endl << "GAME OVER, PLAYER O WINS!" << endl;
            return true;
        }
    }
    if (board[2] == board[5] && board[5] == board[8]) {
        if (board[2] == 'X') {
            cout << endl << "GAME OVER, PLAYER X WINS!" << endl;
            return true;
        }
        else if (board[2] == 'O') {
            cout << endl << "GAME OVER, PLAYER O WINS!" << endl;
            return true;
        }
    }
    if (board[0] == board[4] && board[4] == board[8]) {
        if (board[0] == 'X') {
            cout << endl << "GAME OVER, PLAYER X WINS!" << endl;
            return true;
        }
        else if (board[0] == 'O') {
            cout << endl << "GAME OVER, PLAYER O WINS!" << endl;
            return true;
        }
    }
    if (board[2] == board[4] && board[4] == board[6]) {
        if (board[2] == 'X') {
            cout << endl << "GAME OVER, PLAYER X WINS!" << endl;
            return true;
        }
        else if (board[2] == 'O') {
            cout << endl << "GAME OVER, PLAYER O WINS!" << endl;
            return true;
        }
    }
    if (positionsFilled == boardSize) {
        cout << endl << "GAME OVER, TIE GAME" << endl;
        return true;
    }





    //otherwise the game is not over
    return false;
}

bool playGameAgain(){
    char choice;
    cout << "Would you like to play again (Y or N) ?";
    cin >> choice;

    if ((choice == 'Y') || (choice == 'y')) {
        return true;
        cout << endl << endl;
    }
    else if ((choice == 'N') || (choice == 'n')) {
        return false;
    }

}

[coder777]

what compiler do you use? You have an issue with your curly brace.

On line 80 (1.part) there's a '}' which doesn't seem to belong to anything.
On line 162 (1.part) there's a '{', but no '}'.

This is a common issue with this style. I wonder why it's still in use

[civilVIU]

I use code blocks, not sure if its the best but its free..anyways, I tinkered with my code some more and finally have the program running and counting how many wins X or O has, and will continue to play again if you want it to.

Now I want to try and add a computer to play against, so Ill see what i come up with and post my errors(I just know ill get some...:P)

Thanks!