linked list delete function

[mortis11]

Hi,

My delete function isn't deleting anything. I want her to delete only the node that is selected. Here is a part of the code. I'm not seeing what is wrong.

class node{

        public:
        node(): next(NULL), prev(NULL){}
        virtual ~node();
        bool last() {return (next ? false : true);}
        bool first() {return !last();}
        bool alone() {return ((prev && next) ? false : true);}
        void add(node *node);
        void remove(node *node);

        protected:
        node *next;
        node *prev;
};

node::~node(){}

void node::remove(node *node){

        if(node->alone()){
                if(last()){
                node->prev->next = NULL;
                node->next = NULL;}
                else{
                prev->next= node->next;
                next->prev=node->prev;}
        delete node;
        }
}

[vlad from moscow]

You are using mutually exclusive conditions in the function. Neither node can be simuktaneously for example alone() and last().
It is obvious that your function is invalid.
Oh, sorry. you are applying this condition to different nodes.

But in any case the code invalid because if the node is alone what is the sense to check the current node whether it is last or not?!!!

I think that the function either shall has no parameters or be static.