Error checking, stuck in loop

[RastaWolf]

Hey Everyone,

I don't understand why I'm stuck in a while-loop when i'm trying to error check. It's line 13-17 where I'm stuck in the error checking loop.

Any advice? Thanks in Advance!

int main()
{
    Calculator x;
    double op1, op2;
    char op;
    char rep;
    do {
        cout << ">";
        cin >> op1 >> op >> op2;
        cout << x.calc(op1, op2, op) << endl;
        cout << "Again (y/n)? ";
        cin >> rep;
        while (rep != 'n'|| rep != 'y') {
            cout << "Error\n";
            cout << "Another (y/n)? ";
            cin >> rep;
        }
    } while(rep != 'n');
    return 0;
} 

[shacktar]

This statement is always true:

rep != 'n'|| rep != 'y'

[RastaWolf]

Why is that condition always true?, if you don't mind my newbie question.

If rep == n, it should break.

My intention is to check for invalid entries other than y and n...

[RastaWolf]

I figured it out! I will post my solution.

If there is a more efficient way of doing this, please let me know.

Thanks for the help!

int main()
{
    Calculator x;
    double op1, op2;
    char op;
    char rep;
    do {
        cout << ">";
        cin >> op1 >> op >> op2;
        cout << x.calc(op1, op2, op) << endl;
        cout << "Again (y/n)? ";
        cin >> rep;
        if (rep != 'n' && rep != 'y')
            do  {
            cout << "Error\n";
            cout << "Again (y/n)? ";
            cin >> rep;
            }
         while (rep != 'n' && rep != 'y');
    } while(rep != 'n');
    return 0;
}

[KyleMiles]

You are telling it to do the following when rep does not equal 'n' OR when rep does not equal 'y'. Basically, unless it equals both, the following will execute. Do while (rep != 'n' && rep != 'y') .