Not random enough

[Ch1156]

I have my battle program that i re wrote entirely and i cant seem to make the enemy choices random enough, it chooses the same thing like 4 or 5 times before going to a different one, how can i make it even more random?

I dont get any compiler errors or warings

#include <iostream>
#include <string>
#include <ctime>
#include <random>

using namespace std;

class Vars
{
    public:
        void Battle();
        Vars()
        {
            PHealth = 100;
            EHealth = 100;
        }
    private:
        int PHealth; //Player Health
        int EHealth; //Enemy Health
};

int main()
{
    string choice;
    Vars VO;

    cout << "Welcome to the battle arena" << endl;
    cout << "Please enter the number of the selection\n" << endl;
    cout << "\n";
    cout << "1. Begin" << endl;
    cin >> choice;

    if(choice == "1")
    {
        VO.Battle();
    }
}

void Vars::Battle()
{
    int Pchoice; //Player choice
    int Echoice; //Enemy Choice
    bool end = false;

    cout << "Choose your attack\n" << endl;
    cout << "1. Shotgun" << endl;
    cout << "2. Machine Gun" << endl;
    cout << "3. Knife" << endl;
    cin >> Pchoice;

    while(end != true)
    {
        time_t T;
        time(&T);
        srand(T);

        int time;

        time = rand() % 4;

        switch(Pchoice)
        {
            case 0:
                cout << "you used the Shotgun\n" << endl;
                Echoice;
                cin.get();
                break;
            case 1:
                cout << "You used the Machine Gun\n" << endl;
                Echoice;
                cin.get();
                break;
            case 2:
                cout << "You used the Knife\n" << endl;
                Echoice;
                cin.get();
                break;
        }

        switch(Echoice, time)
        {
            case 0:
                cout << "Enemy used Punch\n" << endl;
                Pchoice;
                cin.get();
                break;
            case 1:
                cout << "Enemy used Kick\n" << endl;
                Pchoice;
                cin.get();
                break;
            case 2:
                cout << "Enemy used Slap\n" << endl;
                Pchoice;
                cin.get();
                break;
            default:
                cout << "Enemy attack missed\n" << endl;
        }
    }
}

[naraku9333]

Your seeding the prng in the while loop, call srand only once.

[Ch1156]

im not exactly sure how to do that. I put the random stuff outside the while loop and the enemy just gives the same attack.

[abbottshaull]

Move the srand(T); statement out of the loop. Otherwise you re-initializing it again to pretty much the previous value and it is the reason why the random doesn't appear to be as random as you are thinking it should be.

That should make things appear more random.

Abbott