I can't find the error- a little help please

[Vagabond]

The problem is that it works perfectly without the password function.
However, as soon as you run the program with the password function the program behaves diferently.
ie: After you enter the corect password (1234), it goes to the selection screen(correct).
But now, after you enter your choise, it's not being displayed on the screen.

I'm not getting any complie errors. Any advice?

char ch156 = 156; // £ sign

int password();
int selectMenu ();
// code revoved to shorten it to less than 9000 chars 


HANDLE console = GetStdHandle(STD_OUTPUT_HANDLE);
COORD coord;

// Thanks to NULL on (http://www.cplusplus.com/articles/E6vU7k9E/) for your wisdom
string getpass(const char *prompt, bool show_asterisk = true)
{
     const char BACKSPACE = 8;
     const char RETURN = 13;
     int i = 0;

     string password;
     unsigned char ch = 0;

     coord.X = 13;
     coord.Y = 8;
     SetConsoleCursorPosition(console, coord);
     cout << prompt << endl;

     DWORD con_mode;
     DWORD dwRead;

     HANDLE hIn=GetStdHandle(STD_INPUT_HANDLE);

     GetConsoleMode( hIn, &con_mode );
     SetConsoleMode( hIn, con_mode & ~(ENABLE_ECHO_INPUT | ENABLE_LINE_INPUT) );

     while(ReadConsoleA( hIn, &ch, 1, &dwRead, NULL) && ch !=RETURN)
     {
          if(ch==BACKSPACE)
          {
               if(password.length()!=0)
               {
                    if(show_asterisk)
                         cout <<"\b \b";
                    password.resize(password.length()-1);
               }
          }
          else
          {
               password+=ch;
               if(show_asterisk)
               {
                    coord.X = 13 + i;
                    coord.Y = 8;
                    SetConsoleCursorPosition(console, coord);
                    cout <<'*';
                    i++;
               }
          }
     }
     coord.X = 0;
     coord.Y = 0;
     SetConsoleCursorPosition(console, coord);
     return password;
}

// MSDN - alternative to system("CLS");
void cls(HANDLE hConsole)
{
   COORD coordScreen = {0, 0};    // home for the cursor
   DWORD cCharsWritten;
   CONSOLE_SCREEN_BUFFER_INFO csbi;
   DWORD dwConSize;

   // Get the number of character cells in the current buffer.
   if( !GetConsoleScreenBufferInfo(hConsole, &csbi))
   {
      return;
   }
   dwConSize = csbi.dwSize.X * csbi.dwSize.Y;

   // Fill the entire screen with blanks.
   if( !FillConsoleOutputCharacter(hConsole,        // Handle to console screen buffer
                                   (TCHAR) ' ',     // Character to write to the buffer
                                   dwConSize,       // Number of cells to write
                                   coordScreen,     // Coordinates of first cell
                                   &cCharsWritten ))// Receive number of characters written
   {
      return;
   }

   // Get the current text attribute.
   if( !GetConsoleScreenBufferInfo(hConsole, &csbi))
   {
      return;
   }

   // Set the buffer's attributes accordingly.
   if( !FillConsoleOutputAttribute(hConsole,         // Handle to console screen buffer
                                   csbi.wAttributes, // Character attributes to use
                                   dwConSize,        // Number of cells to set attribute
                                   coordScreen,      // Coordinates of first cell
                                   &cCharsWritten )) // Receive number of characters written
   {
      return;
   }

   // Put the cursor at its home coordinates.
   SetConsoleCursorPosition(hConsole, coordScreen);
}

int main()
{
     double balance = 10000.00;
     char ch;
     int select;

    password();

     do
     {
          select = selectMenu();
          switch (select)
          {
               case 1://add code here for DepositMoney
                    balance = depositMoney(balance);

                    break;
               case 2: //add code here for widrawMoney
                    balance = widrawMoney(balance);

                    break;
               case 3://add code here for balanceInquiry;
                    balance = balanceInquiry(balance);

                    break;
               case 4://add code here forquitProgram();
                    quitProgram();
                    ch = 'N';
                    break;
          }
          if (ch != 'N')
          {
               ch = tryAgain();
          }
     }
     while (ch=='Y' || ch == 'y');

     return 0;
}

int password()
{
    const char *correct_password="1234";

    //main double boarder
    char ch201 = 201; char ch199 = 198; char ch196 = 196; char ch182 = 182;
    char ch205 = 205; char ch186 = 186; char ch187 = 187; char ch204 = 204;
    char ch185 = 185; char ch200 = 200; char ch188 = 188; char prev = ' ';

    //internal PIN border
    char ch218 = 218; char ch191 = 191;
    char ch179 = 179;
    char ch192 = 192; char ch217 = 217;

    //Password screen
     cls(console);
     // code revoved to shorten it to less than 9000 chars 
     cout << ch186; cout << "      Please enter your       " << ch186 << endl;
     cout << ch186; cout << "         4 digit PIN          " << ch186 << endl;
     cout << ch186; cout.width (31); cout << ch186 << endl;
     cout << ch186; cout << "          " << ch218 << ch196 << ch196 << ch196 << ch196 << ch196 << ch196 << ch196 << ch191 << "           " << ch186 << endl;
     cout << ch186; cout << "          " << ch179 << "       " << ch179 <<"           "  << ch186 << endl;
     cout << ch186; cout << "          " << ch192 << ch196 << ch196 << ch196 << ch196 << ch196 << ch196 << ch196 << ch217 << "           " << ch186 << endl;
     

     string password = getpass("",true); // Show asterisks
     if(password == correct_password)
    //Todo - 1: error message if password is wrong and limmit number of attemps to 3.
    //       2: After 3 attemps lock the user out and advise the to contact the bank.

     return 0;
}

int selectMenu ()
{
     int choice = 0;
     char ch201 = 201; char ch199 = 198; char ch196 = 196; char ch182 = 182;
     char ch205 = 205; char ch186 = 186; char ch187 = 187; char ch204 = 204;
     char ch185 = 185; char ch200 = 200; char ch188 = 188; char prev = ' ';
     //Select screen
     cls(console);
     cout << ch201; cout.fill (205); cout.width (31); cout << ch187 << endl;
     cout << ch186 << " Welcome to ABC Banking Group " << ch186 << endl;
     cout << ch204; cout.fill (205); cout.width (31); cout << ch185 << endl;
     cout.fill (prev);
     cout << ch186; cout.width (31); cout << ch186 << endl;
     cout << ch186; cout << "          Main Menu           " << ch186 << endl;
     cout << ch186; cout.width (31); cout << ch186 << endl;
     cout << ch204; cout.fill (196); cout.width (31); cout << ch185 << endl;
     cout << ch186; cout << "      1 - Depsit Money        " << ch186 << endl;
     cout << ch204; cout.fill (196); cout.width (31); cout << ch185 << endl;
     cout << ch186; cout << "      2 - Withdraw Money      " << ch186 << endl;
     cout << ch204; cout.fill (196); cout.width (31); cout << ch185 << endl;
     cout << ch186; cout << "      3 - Balance Inquiry     " << ch186 << endl;
     cout << ch204; cout.fill (196); cout.width (31); cout << ch185 << endl;
     cout << ch186; cout << "      4 - Quit and Exit?      " << ch186 << endl;
     cout << ch200; cout.fill (205); cout.width (31); cout << ch188 << endl;
     cin >> choice;

     do
     {
          if((!(choice >= 1)) || (!(choice <= 4)))
          {
               cout << " INVALID Choice! Please choose options 1 - 4 " << endl;
               cin >> choice;
          }
     }
     while((!(choice >= 1)) || (!(choice <= 4)));

     return choice;
}

[MaxLascombe]

I am not sure this will work, but on my computer, when I call a function, it only works when the function is placed before the function you are currently in. Try putting the password function before the others.

[coder777]

Guess that line 34 is the culprit. You switched echo off and never switched it on after you're done.

You should preserve con_mode in another variable and SetConsoleMode before you return

[Vagabond]

Thanks for that

I put this in line 81 and it works a treat
SetConsoleMode( hIn, con_mode );

The full code is at:
http://pastebin.com/3i5u4XGS