How can I find the largest number in loops?

[DetectiveRawr]

I'm making a program that determines the largest number from the 10 loops. How can I make it determine the largest from the 10 loops. Here's the program I'm doing. *NOTE* I mean loops as in after you build and run it, it will make you enter an number 10 times.

/* 2.20 Make a program that willl inputs a series of 10 numbers,and determines and prints the largest of the
numbers. */
#include<iostream>

using namespace std;

int main()
{
    int counter,number,largest;

    counter = 0;

    while ( counter <= 10 )
        {
            cout << "Enter a number: ";
            cin >> number;
        }
    return 0;
}

[i2Fluffy]

if(number > largest)
{           
 largest = number;         
}

And don't forget about the counter variable.

[DetectiveRawr]

*Bang my head against the wall*

[DetectiveRawr]

Still doesn't work I did this.

/* 2.20 Make a program that willl inputs a series of 10 numbers,and determines and prints the largest of the
numbers. */
#include<iostream>

using namespace std;

int main()
{
    int counter,number,largest;

    counter = 0;

    while ( counter < 10 )
        {
            cout << "Enter a number: ";
            cin >> number;

            if ( number > largest )
            {
                largest = number;

                cout << endl;
                cout << "The largest number is: " << largest;
            }

            counter++;
        }
    return 0;
}

[i2Fluffy]

put lines 22 and 23 after the while loop

[DetectiveRawr]

Umm It did work but the results. Ehhhh, the largest number is like 2242313. I entered it all the numbers 1,2,3. No other numbers than 1,2,3.

/* 2.20 Make a program that willl inputs a series of 10 numbers,and determines and prints the largest of the
numbers. */
#include<iostream>

using namespace std;

int main()
{
    int counter,number,largest;

    counter = 0;

    while ( counter <= 10 )
        {
            cout << "Enter a number: ";
            cin >> number;

            if ( number > largest )
            {
                largest = number;
            }
            counter++;
        }

    cout << endl;
    cout << "The largest number is: " << largest;

    return 0;
}

[Splux]

You haven't initialized your variable.

Now when you compare "number" to "largest", "largest" will have some crap value.

int largest = 0;

[DetectiveRawr]

Wow dude, thanks! It worked. :)

[DetectiveRawr]

How do you find 2 largest vales?

[TheIdeasMan]

Well, can you think about how to do that?

Hint - you need another variable.

[DetectiveRawr]

Hmm thanks Ideaman......

[DetectiveRawr]

Nope, I can't figure it out. :\

[TheIdeasMan]

What have you tried? Post your new code. You must have done something.

[DetectiveRawr]

/* 2.20 Make a program that willl inputs a series of 10 numbers,and determines and prints the largest of the
numbers. */
#include<iostream>

using namespace std;

int main()
{
    int counter,number,largest,large2;

    counter = 0;
    largest = 0;

    while ( counter <= 10 )
        {
            cout << "Enter a number: ";
            cin >> number;

            if ( number > largest )
            {
                largest = number;
            }
            
            if ( number > large2 )
            {
                large2 = number;
            }

            counter++;
        }

    cout << endl;
    cout << "The largest numbers is: " << largest << " and " << large2;

    return 0;
}

[TheIdeasMan]

OK same problem as before - you need to initialise your variables.

I like to declare, initialise and comment all on 1 line like this:

int counter = 0;  //count the numbers
int number = 0; // A particular number
int largest = 0; //The largest number
int large2 = 0 //The second largest number; 

It makes it much easier for someone else to understand what all your variables mean.

Now think about how to do this. If you find a new largest number, what happens to the old largest number?

[DetectiveRawr]

The old largest number will be the new largest number?

[TheIdeasMan]

Well, no.

Say you have found a number that is bigger than the existing largest number. This will be the new largest number. The old largest number go into which variable?

[DetectiveRawr]

Ummmm it will be replaced?

[TheIdeasMan]

[Sigh] Come on, it's pretty simple.

It's a bit like this:

You have two buckets numbered 1 and 2. Object A goes into bucket 1, where does Object B go?

I apologise if I sound rude, but it really is very simple.

[DetectiveRawr]

oh.... it goes into 2....