text file statistics help

[BroncoAG]

If I knew why it wasn't working I wouldn't be posting on here asking for help. I've been looking at it and changing it for the last 2 hours and I still can't figure it out.

[Texan40]

HINT: everything inside the for() loop will print every iteration, and there is something you are passing to cout that is making it jump to a new line

[BroncoAG]

Ok, so I changed the code and it now prints out the contents but it doesn't count anything any more. I don't know how to make it go from the while loop line 32 to the for loop line 42.

#include <iostream>
#include <fstream>
#include <cctype>
#include <cstring>
using namespace std;

int main()
{
    fstream file;
    int lower_count = 0;
    int upper_count = 0;
    int alpha_count = 0;
    int space_count = 0;
    int punct_count = 0;
    string filename;
    string line;


    cout << "Enter a file name" << endl;
    cin >> filename;

    file.open(filename.c_str(), ios::in);

    if(!file)
    {
        cout << "Couldn't open " << filename << endl;
        return 1;
    }
    else
    {

        while(file)
        {
            getline (file, line);
            cout << "-- File contents --" << endl;
            cout << line << endl;
            cout << "-- End --" << endl;
            break;
        }


        for (char c = file.get(); c !=EOF; c = file.get())
        {
            if (islower(c))
            {
                lower_count++;
            }
            if (isupper(c))
            {
                upper_count++;
            }
            if (isalpha(c))
            {
                alpha_count++;
            }
            if (ispunct(c))
            {
                punct_count++;
            }
            if (isspace(c))
            {
                space_count++;
            }
        }

    }
    file.close();


    cout << "File statistics:" << endl;
    cout << "Uppercase characters: " << upper_count << endl;
    cout << "Lowercase characters: " << lower_count << endl;
    cout << "Punctuation characters: " << punct_count << endl;
    cout << "Alphabetic characters: " << alpha_count << endl;
    cout << "Whitespace characters: " << space_count << endl;
}

[Lowest0ne]

Here's the method your teacher gave you to read the file:

for (char c = file.get(); c != EOF; c = file.get())
{
     //The variable "c" now contains the next character from the file
} 

So something like:

for (char c = file.get(); c != EOF; c = file.get())
{
     //The variable "c" now contains the next character from the file
     cout << c;
} 

[BroncoAG]

Thanks, I finally got it. When I used that it was displaying the characters on different lines. I finally got it to work. Thanks for your help.