Save not working

[Ch1156]

Ok im not sure if im doing the save right, it isnt working, it should save the progree but it isnt.

#include <iostream>
#include <string>
#include <ctime>
#include <random>
#include <fstream>

using namespace std;

class CLASS
{
    public:
        void Player();
        void TRex();
        void Upgrades();
        void Help();
        void Stats();
        void Save();
        void Load();
        CLASS()
        {
            PHealth = 100;
            TRHealth = 100;
            XP = 0;
            NumDef = 0;
            PKill = 0;
            file << XP << endl;
            file << NumDef << endl;
            file << PKill << endl;
        }
    private:
        int PHealth; //Player Health
        int TRHealth; //T-Rex Health
        int XP; //Experience points
        int NumDef; //Number of opponents defeated
        int PKill; //Number of times player was killed
        ofstream file;

};


int main()
{
    CLASS CO;

    string choice;

    cout << "\n";
    cout << "DINOSAUR ARENA" << endl;
    cout << "\n";
    cout << "Type in the number next to the choice" << endl;
    cout << "\n";
    cout << "1) Enter Game" << endl;
    cout << "2) Help" << endl;
    cout << "3) View Stats" << endl;
    cout << "4) Save game progress" << endl;
    cin >> choice;

    if(choice == "1")
    {
        CO.Player();
    }
    else if(choice == "2")
    {
        CO.Help();
    }
    else if(choice == "3")
    {
        CO.Stats();
    }
    else if(choice == "4")
    {
        CO.Save();
    }
    else
    {
        main();
    }
}


void CLASS::Help()
{
    cout << "HELP SECTION" << endl;
    cout << "\n";
    cout << "1) " << endl;
}


void CLASS::Stats()
{
    string choice;

    Load();

    cout << "\n";
    cout << "STATS" << endl;
    cout << "\n";
    cout << "Type in: back to go back to main menu." << endl;
    cout << "\n";
    cout << "Your total XP: " << XP << endl;
    cout << "Times you were killed: " << PKill << endl;
    cout << "Number of dinosaurs defeated: " << NumDef << endl;
    cin >> choice;

    if(choice == "Back" || choice == "back")
    {
        main();
    }
}


void CLASS::Save()
{
    ofstream file("stats.txt");

    file << XP << endl;
    file << PKill << endl;
    file << NumDef << endl;
}


void CLASS::Load()
{
    ifstream file("stats.txt");

    file >> XP;
    file >> PKill;
    file >> NumDef;
}


void CLASS::Player()
{
    string choice;

    cout << "\n";
    cout << "\n";
    cout << "What weapon will you use?" << endl;
    cout << "\n";
    cout << "1) Shotgun = 4 Damage" << endl;
    cout << "2) Pistol = 6 Damage" << endl;
    cout << "3) Knife = 5 Damage" << endl;
    cout << "\n";

    while(true)
    {
        cin >> choice;

        if(TRHealth <= 0)
        {
            cout << "You defeated the T-Rex!" << endl;
            XP += 30;
            NumDef += 1;
            file << XP << endl;
            file << NumDef << endl;
            cout << "XP gained: " << XP << endl;
            cout << "\n";
            cout << "\n";
            main();
            break;
        }

        if(PHealth <= 0)
        {
            cout << "You were killed!" << endl;
            cout << "XP gained: 0" << endl;
            cout << "\n";
            cout << "\n";
            PKill += 1;
            file << PKill << endl;
            main();
            break;
        }

        if(choice == "1")
        {
            cout << "\n";
            cout << "You used the shotgun!" << endl;
            cout << "Your health: " << PHealth << endl;
            cout << "\n";
            TRHealth -= 4;
            TRex();
        }
        else if(choice == "2")
        {
            cout << "\n";
            cout << "You used the pistol!" << endl;
            cout << "Your health: " << PHealth << endl;
            cout << "\n";
            TRHealth -= 6;
            TRex();
        }
        else if(choice == "3")
        {
            cout << "\n";
            cout << "You used the knife!" << endl;
            cout << "Your health: " << PHealth << endl;
            cout << "\n";
            TRHealth -= 5;
            TRex();
        }
    }
}


void CLASS::TRex()
{
    time_t T;
    time(&T);
    srand(T);

    int Time;

    Time = rand() % 4;

        switch(Time)
        {
            case 0:
                cout << "\n";
                cout << "T-Rex used Bite! = -6 Health" << endl;
                PHealth -= 6;
                cout << "T-rex Health: " << TRHealth << endl;
                cout << "\n";
                Player();
                break;

            case 1:
                cout << "\n";
                cout << "T-Rex used Chomp! = -5 Health" << endl;
                PHealth -= 5;
                cout << "T-rex Health: " << TRHealth << endl;
                cout << "\n";
                Player();
                break;

            case 2:
                cout << "\n";
                cout << "T-Rex used Stomp! = -4 Health" << endl;
                PHealth -= 4;
                cout << "T-rex Health: " << TRHealth << endl;
                cout << "\n";
                Player();
                break;
            default:
                cout << "\n";
                cout << "Trex's attack missed!" << endl;
                PHealth -= 0;
                cout << "T-rex Health: " << TRHealth << endl;
                cout << "\n";
                Player();
                break;
        }
}

[Ch1156]

bump

[naraku9333]

The file saving is fine, I suspect the problem is you call main in multiple locations.

[soranz]

Line 36 declares ofstream file; u don't u rly shouldn't keep declaring it in each member function...
On line 144 u want to do something like this:
file.open("stats.txt");
Then line 119 u have to close that file. This is true for each of those member functions or else u'll get some weird collisions with the stream still being open.

There's also file.open("stats.txt", ios::app); that u may need as it will allow u to open a file with existing text so that u can add more text to it without erasing everything by default.

Lines 26-28 don't rly do anything because 'file' is not open for writing yet.

[Ch1156]

Hmm, its still not adding my variables to the text file.

[naraku9333]

Every time you call main you recreate the CLASS object resetting all the values back to default.

[Ch1156]

Ah, i see, so how do i got back to main if i cant call it?

[naraku9333]

A loop in main around the if/else block should be all you need.