Error: Expected Primary-Expression

[Joshua Spears]

I am running into a problem with trying to compile and run my program. on line 192 and 200 im getting [Expected Primary-Expression before '=' token] and another error on 200 saying [Invalid operands of types 'double' and 'const char[5]' to binary operator 'operator<<'

p.s. Line 192 = 179
200 = 187

#include <iostream>
#include <iomanip>
#include <cmath>
#define FleetAvg = 25.0


double tripMileage;
double CostPerMile;
double TripCost;
double overallMPG;
double totalMiles = 0;
double totalGallons = 0;
double totalCost = 0;
double gallons;
double miles;
double price;
double MileageComp;

char ANSWER;


double getGallons();
double getMiles();
double getPricePerGallon();
double calcTripMileage (double miles, double gallons);
double calcTripCost (double price, double gallons);
double calcTripCostPerMile (double TripCost, double miles);
double calcOverallMPG (double totalMiles, double totalGallons);
void showOneTrip (double TripMileage, double TripCost, double TripCostPerMile);
void showTotals (double totalMiles, double totalGallons, double totalCost, double overallMPG);
void showMileageComparison (double overallMPG);


using namespace std;






double getGallons()
{

double gallons;

	cout << "Enter the number of gallons of fuel: ";
	cin >> gallons;
		
	while (gallons <= 0 || gallons > 40)
		{
			cout << "\n\n";
			cout << "Out of range: must be between 0 and 40 gallons. Re-enter: ";
			cin >> gallons;
			cout << "\n";
		}
}

double getMiles()
{
	
double miles;

	cout << "Enter the number of miles: ";
	cin >> miles;	
		
	while (miles <= 0 || miles > 800)
		{
			cout << "\n\n";
			cout << "Out of range: must be between 0 and 800 miles. Re-enter: ";
			cin >> miles; 
			cout << "\n";	 	 	 
		}
}

double getPricePerGallon()
{

double price;

	cout << "Enter the price per gallon: ";
	cin >> price;
	
	while (price <= 2 || price > 7)
		{
			cout << "\n\n";
			cout << "Out of range: must be between $2.00 and $7.00 dollars. Re-enter: ";
			cin >> price;
			cout << "\n";
		}
	return price;
}

double calcTripMileage (double miles, double gallons)
{

double tripMileage;

	if (gallons == 0)
		{
			tripMileage = 0;
		}
	else if (gallons > 0)
		{
			tripMileage = miles / gallons;
		}
	return tripMileage;
}

double calcTripCost (double price, double gallons)
{

 double TripCost;
 
 	TripCost = price * gallons;
	
	return TripCost;
}

double calcTripCostPerMile (double TripCost, double miles)
{

double CostPerMile;

	if (miles == 0)
		{
			CostPerMile = 0;
		}
	else if (miles > 0)
		{
			CostPerMile = TripCost / miles;
		}
	return CostPerMile;
	
}


double calcOverallMPG (double totalMiles, double totalGallons)
{

double overallMPG;

	if (totalGallons == 0)
		{
			overallMPG = 0;
		}
	else if (totalGallons > 0)
		{
			overallMPG = totalMiles/totalGallons;
		}
	return overallMPG;
				
}



void showOneTrip (double TripMileage, double TripCost, double TripCostPerMile)
{


	cout << "Trip Mileage:           " << fixed << showpoint << setprecision(2) << tripMileage << " MPG" << endl;
	cout << "Trip Cost:             $" << fixed << showpoint << setprecision(2) << TripCost << endl;
	cout << "Trip cost per mile:    $" << fixed << showpoint << setprecision(2) << CostPerMile << endl;
	
}


void showTotals (double totalMiles, double totalGallons, double totalCost, double overallMPG)
{

	cout << "Total Miles:     " << totalMiles << endl;
	cout << "Total Gallons:     " << totalGallons << endl;
	cout << "Total Cost:     " << totalCost << endl;
	cout << "Overall MPG:     " << overallMPG << endl;
}

void showMileageComparison (double overallMPG)
{
float MileageComp = overallMPG - FleetAvg;

		if (MileageComp > 0)
			{
				cout <<	 "Your vehicle's mileage is greater than the fleet average by " << MileageComp << "mpg.";
			}
		else if (MileageComp == 0)
			{
				cout << "Your vehicle's mileage is equal to the fleet average of " << FleetAvg << "mpg.";
			}
		else if (MileageComp < 0)
			{
				cout << "Your vehicle's mileage is is less than the fleet average by " << MileageComp << "mpg.";
			}
}


int main()

{
	cout << "     Fuel Usage Analysis";
	cout << "\n\n";
	
do 
{
		gallons = getGallons ();
		miles = getMiles ();	
		price = getPricePerGallon ();
			
		cout << "\n\n";
		showOneTrip (tripMileage, TripCost, CostPerMile);
		cout << "\n\n";
		
	calcTripMileage (miles, gallons);	 
	calcTripCost (price, gallons);
	calcTripCostPerMile (TripCost, miles);	   
	
		
	 totalMiles += miles;
	 totalGallons += gallons;
	 totalCost += TripCost;
	
		overallMPG = calcOverallMPG (totalMiles, totalGallons);
				
		cout << "Another? (y or n) ";
		cin >> ANSWER;
			
}

while((ANSWER == 'Y')||(ANSWER == 'y'));

cout << "\n\n";
	
	showTotals (totalMiles, totalGallons, totalCost, overallMPG);
	
cout << "\n\n";

	showMileageComparison (overallMPG);	   
	

return 0;

}

If anyone could help that would be great!

[firedraco]

Your defintion of FleetAvg is incorrect. For defines you simply do:

#define NAME VALUE

No = or ;.

However, I would suggest you use a constant value so that the compiler can help you more:

const double FleetAvg = 25.0;

[Joshua Spears]

firedraco (5150)

Jul 9, 2012 at 7:01pm



Your defintion of FleetAvg is incorrect. For defines you simply do:

#define NAME VALUE

No = or ;.

However, I would suggest you use a constant value so that the compiler can help you more:

const double FleetAvg = 25.0;

THANK YOU VERY MUCH!!!

but now I am not getting any numbers to run correctly. On the first run I am getting all 0's and the summary displays NaN and 0's. I think it has something to do with my variables in the functions but I don't know. Can anyone help with this problem?

[ThangDo]

I guess you forgot to assign value to FleetAvg in the define after taking out the = 25.0 part

you need this

#define FLEETAVG (25.0) 

[TheIdeasMan]

Hi Joshua,

I see this is a new thread based on the same problem, maybe you don't know, but it is better if you keep it all in one thread.

The problem is that some people write a whole of things in one thread, only to discover that others have written heaps into a different thread - which is rather confusing. I am not trying to have a go, as I say maybe you didn't realise.

Did you see the reply that I made to the other thread?

[Joshua Spears]

TheIdeasMan (277)

Jul 10, 2012 at 6:42am



Hi Joshua,

I see this is a new thread based on the same problem, maybe you don't know, but it is better if you keep it all in one thread.

The problem is that some people write a whole of things in one thread, only to discover that others have written heaps into a different thread - which is rather confusing. I am not trying to have a go, as I say maybe you didn't realise.

Did you see the reply that I made to the other thread?

I am sorry, I didn't realize the issue. I was just in a rush and I thought making a new post would help. And yes, I did see your post, THANKS FOR ALL THE HELP!!!