Amount of Code

[Fransje]

Hi all!
Can anybody advise me how to shorten the beneath code? because I always have the idea that my code is way to elaborate. Thanks!

#include <iostream>
#include <windows.h>

using namespace std;

char Convert(char);

int main()
{
    SetConsoleTitle("Converting Letters");
    char Character = 0;
    int Counter = 0;
    
    cout << "Welcome! Enter how many times you want to convert a letter: ";
    cin >> Counter;
    
    for(Counter; Counter > 0; Counter--)
    {
        cout << "Enter a letter: ";
        cin >> Character;
        cout << "The result is " << Convert(Character) << ".\n";
        Character = 0;
    }
    
    cin.get();
    cin.get();
}

char Convert(char Character)
{
    char newCharacter;
    
    switch(Character)
    {
        case 'a':
            newCharacter = 'A';
            return newCharacter;            
        case 'A':
            newCharacter = 'a';
            return newCharacter;
        case 'b':
            newCharacter = 'B';
            return newCharacter;            
        case 'B':
            newCharacter = 'b';
            return newCharacter;
        case 'c':
            newCharacter = 'C';
            return newCharacter;            
        case 'C':
            newCharacter = 'c';
            return newCharacter;
        //case 'd': ... and so on            
        default:
            cout << "Invalid input...\n";
            cin.get();
            cin.get();
            exit(0);
    }
}

[Moschops]

Your function, Convert, is taking a char and changing the case. So, why not use existing functions to help you?

How about:

char Convert(char Character)
{
  if (isupper(Character)
  {    return tolower(Character);  }
  else
  {    return toupper(Character); }

You will still need to check for bad input.

[ResidentBiscuit]

for(Counter; Counter > 0; Counter--) can change this to
for(; Counter > 0; Counter--)

Can get rid of line 22.

In your function, you can get rid of that variable, and just

return tolower(Character); OR
return toupper(Character);

Those functions are in <cctype>

Could also get rid of all those cin.get()s

EDIT:
Ninja'd by Moschops! :(

[Catfish2]

#include <algorithm>
#include <cctype>
#include <iostream>
#include <string>

// #include <cstdlib> // system()

char convert(char c)
{
	if (std::islower(c))
		return std::toupper(c);
	else
	if (std::isupper(c))
		return std::tolower(c);

	return c;
}

int main()
{
	std::string s;

	std::cout << "Enter a sentence..." << std::endl;
	std::getline(std::cin, s);
	std::transform(s.begin(), s.end(), s.begin(), convert);
	std::cout << "Result: " << s << std::endl;
//	std::system("PAUSE"); // if needed
}

[Fransje]

Thanks! I didn't know there were existing functions for this.