trying to clean up the code, how to....

[kmilnedc]

thank you to all those who have helped up to this point. so i've almost got it all converted from <Vector> to a readable <cstring>. But I ran into a wall when I got to the setSpaces() function. any help would be appreciated. thanks much.

to better explain myself, I've been doing this. changing this...

void readMadLib(char fileName[], char madLib[][32])
{
	ifstream inStream(fileName);
	
	while (inStream.fail())
	{
		getFileName(fileName);
		inStream.open(fileName);
	}
	
	char inputChar[256];
	
	while (inStream >> inputChar)
	{
	vector < char > word;  //this stores words
		
		for (char *p = inputChar; *p; p++)
			word.push_back(*p);
		madLib.push_back(word);  //sends word to next spot
	}	
	inStream.close();
}

to this...

int readMadLib(char fileName[], char madLib[][32])
{
   ifstream inStream(fileName);

   if (!inStream.fail())
   {
      int i = 0;
      while (inStream >> madLib[i])
      {
         i++;
      }
      inStream.close();
      return i;
   }
   return 0;
}

He is the code I have so far..

#include <iostream>
#include <iomanip>
#include <fstream>
#include <cstring>

using namespace std;

void getFileName(char fileName[])
{
   cout << "Please enter the filename of the Mad Lib: ";
   cin.getline(fileName, 256);
}

/*************************************************************
 *
 *
 **************************************************************/
int readMadLib(char fileName[], char madLib[][32])
{
   ifstream inStream(fileName);

   if (!inStream.fail())
   {
      int i = 0;
      while (inStream >> madLib[i])
      {
         i++;
      }
      inStream.close();
      return i;
   }
   return 0;
}

/*************************************************************
 *
 *
 **************************************************************/
bool isBrackets(char madLib[][32], int numWords)
{
   return (madLib[numWords][0] == '<' &&
           madLib[numWords][strlen(madLib[numWords]) - 1] == '>');
}

/*************************************************************
 *
 *
 **************************************************************/
void getMadLibPrompt(char madLib[][32], int i)
{

   char prompt[256];


    for(int j = 0; j < 32; j++)
  {
     if (madLib[i][j] == '_')
        madLib[i][j] = ' ';

     else if (madLib[i][j] == '>')
        madLib[i][j] = '\0';
  }
   madLib[i][1] = toupper(madLib[i][1]);

   for(int j = 0;j < 32; j++)
   {
      prompt[j] = madLib[i][j + 1];
   }

    cout << " \t";
    cout << prompt;
    cout << ": ";
    cin.getline(madLib[i], 256);


}

/*************************************************************
 *
 *
 **************************************************************/
void commandsAndPrompts(char madLib[][32], int numWords)
{
   for (int i = 0; i < (int)numWords; i++)
   {
      if (isBrackets(madLib, i))
      {
         switch (madLib[i][1])
         {

            case '#':
               strcpy(madLib[i], "\n");
               break;


            case '{':
               strcpy(madLib[i], " \"");
               break;

            case '}':
               strcpy(madLib[i], "\"");
               break;

            case '[':
               strcpy(madLib[i], " \'");
               break;

            case ']':
               strcpy(madLib[i], "\'");
               break;

            default:
               getMadLibPrompt(madLib, i);
               break;
         }
      }
   }
}

/*************************************************************
 *
 *
 **************************************************************/
void setSpaces(char madLib[][32])
{
   //   vector <char> quoteAndTickPushBack;
   for (int i = 0; i < char madLib[][32]; i++)
   {
      if (madLib[i][0] == '\n');
      else if (madLib[i][1] == '"' || madLib[i][1] == '\'')
      {
         if (madLib[i - 1][0] == '"')
         {
            quoteAndTickPushBack.clear();
            quoteAndTickPushBack.push_back('"');
            madLib[i - 1] = quoteAndTickPushBack;
         }

         else if (madLib[i - 1][0] == '\'')
         {
            quoteAndTickPushBack.clear();
            quoteAndTickPushBack.push_back('\'');
            madLib[i - 1] = quoteAndTickPushBack;
         }
      }

      else
      {
         switch((madLib[i + 1][0]))
         {
            case '\n':
            case '"':
            case '!':
            case ' ':
            case '\'':
            case ')':
            case ',':
            case '.':
            case ';':
            case '?':
            case ']':
            case '`':
            case '}':
               break;
            default:
               madLib[i].push_back(' ');
         }
      }
   }
}
/*************************************************************
 *
 *
 **************************************************************/
void display(char madLib[][32],int numWords)
{
   cout << endl;
   for (int i = 0; i < numWords; i++)

         cout << madLib[i];
}

/*************************************************************
 *
 *
 **************************************************************/
int main()
{
   char ans;

      do
      {
         char madLib[1024][32];
         char fileName[256];


         getFileName(fileName);    //good
         int numWords = readMadLib(fileName, madLib); //good
         commandsAndPrompts(madLib, numWords);
         //        setSpaces(madLib);
          display(madLib, numWords);

         char question[] = "Do you want to play again (y/n)? ";
         cout << question;
         cin >> ans;
         cin.ignore();
      }
      while (ans == 'y');
      cout << "Thanks for playing.\n";
      return 0;
}

[kmilnedc]

o-and if you see anything else that seems out of line, please let me know.

This is what the code should do.

takes a .txt file

Zoos are places where wild <plural_noun> are kept in pens or cages <#> so that <plural_noun> can come and look at them . There is a zoo <#> in the park beside the <type_of_liquid> fountain . When it is feeding time , <#> all the animals make <adjective> noises . The elephant goes <{> <funny_noise> <}> <#> and the turtledoves go <{> <another_funny_noise> . <}> My favorite animal is the <#> <adjective> <animal> , so fast it can outrun a/an <another_animal> . <#> You never know what you will find at the zoo . <#>

# = Newline character. No space before or after.
{ = Open double quotes. Space before but not after.
} = Close double quotes. Space after but not before.
[ = Open single quote. Space before but not after.
] = Close single quote. Space after but not before.
anything else = A prompt