HELP!!!! URGENT!!!

[kisukey]

This is my program and when i run it its works however the part when it says press Q or R isn't working. When i press R is just freezes n does nothing. Q works though.

Lab 1
//Constants
#define STARS "\t**************************************\n"
#define BOSS "\tKenneth\n"
#define PROTO "\tInternet Protocol Address Program\n"
#define EQUAL "\t=================================\n"
#define SLASH "\t//////////////\\\\\\\\\\\\\\\\\\\\\\\\\\\\\n"
#define SLASH2 "\t\\\\\\\\\\\\\\\\\\\\\\\\\\\//////////////\n"
#define CONT "\tPress any key to continue...\n\n"
#define PERC "\t%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%\n"

//Function List
void output1 (void);
void output2 (void);
char getclass (const int ip);
void Menu (void);
void output3 (void);
void output4 (void);
void output5 (void);
//void output44 (void);


char ipname1[25];
char ipname2[25];
char ipname3[25];
char IPClassA;
char IPClassB;
char IPClassC;
int IP1[4];
int IP2[4];
int IP3[4];
//int sum1,sum2,sum3;
//float mean1,mean2,mean3;



int main (void)
{

output1();
output2();
Menu();

return 0;
}

//Libs
#include <stdio.h>
#include <conio.h>
#include <iostream>



void output1 (void)
{
system("cls");
printf("\tInternet Protocol Address Program\n");
printf("\tProgrammer Kenneth\n");
printf("\tStage 1.0\n");
printf(STARS);
printf("\tThis program records and analyses \n\tIP Address details entered by the user\n");
printf(STARS);
printf(CONT);
getch();
}

void output2 (void)
{
int ipcheck;
int loopredo;
loopredo = 1;



system("cls");
printf(PROTO);
printf(EQUAL);
do
{

ipcheck=0;


while (ipcheck == 0)
{
printf("Enter Ip Name:");
scanf("%s",ipname1);
printf("Input IP Address:");
scanf("%d.%d.%d.%d",&IP1[0],&IP1[1],&IP1[2],&IP1[3]);

if ((IP1[0] >=0) && (IP1[0] <=255) && (IP1[1] >=0) && (IP1[1] <=255) && (IP1[2] >=0) && (IP1[2] <=255) && (IP1[3] >=0) && (IP1[3] <=255))
{
ipcheck = 1;
}
else
{
printf("ERROR:Invalid IP");
getch();
ipcheck = 0;
}
printf("Enter Ip Name:");
scanf("%s",ipname2);
printf("Input Second IP Address:");
scanf("%d.%d.%d.%d",&IP2[0],&IP2[1],&IP2[2],&IP2[3]);

if ((IP2[0] >=0) && (IP2[0] <=255) && (IP2[1] >=0) && (IP2[1] <=255) && (IP2[2] >=0) && (IP2[2] <=255) && (IP2[3] >=0) && (IP2[3] <=255))
{
ipcheck = 1;
}
else
{
printf("ERROR:Invalid IP");
getch();
ipcheck = 0;
}
printf("Enter Ip Name:");
scanf("%s",ipname3);
printf("Input Third IP Address:");
scanf("%d.%d.%d.%d",&IP3[0],&IP3[1],&IP3[2],&IP3[3]);

if ((IP3[0] >=0) && (IP3[0] <=255) && (IP3[1] >=0) && (IP3[1] <=255) && (IP3[2] >=0) && (IP3[2] <=255) && (IP3[3] >=0) && (IP3[3] <=255))
{
ipcheck = 1;
}
else
{
printf("ERROR:Invalid IP");
getch();
ipcheck = 0;

}

}

system("cls");
printf("To Exit the loop press [Q] to re-enter the ip address's press [R]");

switch(toupper(getch()))
{
case 'Q' :
loopredo = 0;
break;

case 'R' :
loopredo = 1;
break;
default: printf("Invalid Menu Selection\n");
}

}while(loopredo == 1);



IPClassA = getclass (IP1[0]);
IPClassB = getclass (IP2[0]);
IPClassC = getclass (IP3[0]);

system("cls");
printf ("\tIP1==>> %d.%d.%d.%d \n", IP1[0],IP1[1],IP1[2],IP1[3]);
printf ("\tName ==>> %s \n",ipname1);
getch();
printf ("\tIP2==>> %d.%d.%d.%d \n", IP2[0],IP2[1],IP2[2],IP2[3]);
printf ("\tName ==>> %s \n",ipname2);
getch();
printf ("\tIP3==>> %d.%d.%d.%d \n", IP3[0],IP3[1],IP3[2],IP3[3]);
printf ("\tName ==>> %s \n",ipname3);
printf ("\t %s \n",EQUAL);
printf ("\t %s ",CONT);
getch();
}


void output3 (void)
{
system("cls");
printf("\tInternet Protocol Address Program\n");
printf(SLASH);
printf("\tThe recorded IP Addresses are -\n");
printf("\t%d.%d.%d.%d\t%s\n", IP1[0],IP1[1],IP1[2],IP1[3],ipname1);
printf("\t%d.%d.%d.%d\t%s\n", IP2[0],IP2[1],IP2[2],IP2[3],ipname2);
printf("\t%d.%d.%d.%d\t%s\n", IP3[0],IP3[1],IP3[2],IP3[3],ipname3);
printf(SLASH2);
printf(CONT);
getch();
}


void output4 (void)
{
int SUMIP1;

system("cls");
printf ("\n\n\tINTERNET PROTOCOL ADDRESS PROGRAM");
printf ("\t\n%%%%%%%%%%%%%%%%%%%% Analysis %%%%%%%%%%%%%%%%%%%%%%%%%%%%\n");
printf ("\tIP Address Name Class\n");
printf ("\t=============== =====\n");
printf ("\t1. %d.%d.%d.%d\t\t %c\n" ,IP1[0],IP1[1],IP1[2],IP1[3],IPClassA);
printf ("\t1. %d.%d.%d.%d\t\t %c\n" ,IP2[0],IP2[1],IP2[2],IP2[3],IPClassB);
printf ("\t1. %d.%d.%d.%d\t\t %c\n" ,IP3[0],IP3[1],IP3[2],IP3[3],IPClassC);
printf (" %s \n",PERC);

SUMIP1 = IP1[0] + IP1[1] + IP1[2] + IP1[3]+ IP2[0] + IP2[1] + IP2[2] + IP2[3] + IP3[0] + IP3[1] + IP3[2] + IP3[3];
printf ("\tThe sum of all IP address is: %d", SUMIP1);
printf ("\n\t %s \n",CONT);
getch();
}

void output5 (void)
{
system("cls");
printf("\tInternet Protocol Address Program\n");
printf("\tThis program has finished\n");
printf("\t\tKenneth\n");
getch();
}

char getclass (const int ip)
{

if (ip < 128 )
return 'A';

else if (ip < 192 )
return 'B';

else if (ip < 224 )
return 'C';

else if (ip < 240 )
return 'D';
else
return 'E';
}




void Menu (void)
{
int menuloop;
menuloop = 0;

system("cls");

do
{

system("cls");
printf("\tA=>> Display IP Address and Names\n");
printf("\tC=>> Display IP Classes and Names\n");
printf("\tQ=>> Quit Program\n");

switch(toupper(getch()))
{
case 'A' :{
output3();
menuloop = 0;
break;
}

case 'C' :{
output4();
menuloop = 0;
break;
}

case 'Q' :{
output5();
menuloop = 1;
break;
}

printf("Enter selection ==>>\n");
system("cls");
}
}while (menuloop == 0);
}

[ResidentBiscuit]

Posting the same thing twice in 5 minutes won't get you help any faster.

[kisukey]

er... if u look at them closely they are differnt i need help with both of them

[MrHutch]

Compiled. Works fine. Lots of warnings though. Using VS2010 with standard VS compiler.

[kisukey]

yeh i know it works fine but after input ip and ip name
it will say press Q or R
when i press R it just freezes and doesnt repeat the process
i want to repeat it with the loops i added into the script

[MrHutch]

I meant it works fine when I press R.

Loops back to the start.

[kisukey]

oh does it?
thank you i dunno it may be my program
im using microsoft developer studio and it just freezes when i press R

[TheIdeasMan]

er... if u look at them closely they are differnt i need help with both of them

Well, you need to put better titles for your threads. ERROR or HELP!!! URGENT aren't good, put something more descriptive to attract the attention you need.

Now some style points:

If you read some of my other posts, you will see that I HATE do while loops!!

They can almost always be written as a while or for loop.

The only real time you need a do-while loop is when you have to test something that can only be set at the end of the body of the loop. This is fairly rare.

bool MyTest;
do {

// do a whole lot of stuff
MyTest = true;   //this has to go here for a valid reason
} while(MyTest==true);

[kisukey]

i got my friend to help me
but i think the loops he did was to check if it works
and if it did it proceeds to the next step otherwise display error
is there a better way other then writing loop = 0 loop = 1?

[TheIdeasMan]

A while loop looks like this:

while(test-expression)  {
       //this code is executed if test-expression is true


}

So it's easy to change a do-while into a while, they are very similar.

i

s there a better way other then writing loop = 0 loop = 1?

bool MenuLoop = true;  //declaration and initialisation

MenuLoop = false;  //assignment in your code

if(MenuLoop == true)    //testing it
{
     //do this code if true
}
else 
{
    //do this code if false

}

[BHX]

do{}while(); is fine if you are wanting the code to execute at least once before testing the condition. The only difference between do{}while(); and while(){} is that the first guarantees the loop will execute once before testing the condition where the other will test the condition first and then run the loop if the condition is true. I think it depends on program demands and personal preference as I know some programmers that do their code just so that they have do while loops instead of while loops.

[TheIdeasMan]

The only difference between do{}while(); and while(){} is that the first guarantees the loop will execute once before testing the condition where the other will test the condition first and then run the loop if the condition is true.

That's right, but one can nearly always still write it as a while loop that will execute at least once.
It's not so bad if the body of the loop is a function call, but when the while condition is down 50 lines, it can cause confusion. Having lots of code in a loop is bad style in it's self.

The other thing that has happened on this forum ( read the Loops thread by SGM) is this:

A post was made that looked like this:

while (test expression) ;

It caused some confusion and debate, but it turned out that it was the while expression of the do while ! The while expression wasn't on the same line as the closing brace of the do, which made it look like a while with a null statement !!!

When I said that do-whiles are rarely necessary, I remember that came from Kernighan & Ritchie C programming.

The other thing is that novice coders might write a do while, out of habit, then discover they have problems with the logic, with the solution being they needed a while loop, that may not execute at all.

It's interesting to read some of the other posts about this, sometimes the advice given isn't right.

#include <iostream>
using namespace std;
int main()
{
       int num;
       cout<<"Enter the number of Stars: "<<endl;
       cin>>num;

    do {
             for(int i=0; i<num;i++)
                 {
                      cout <<" * ";
                 }

         num=num-1;
		 cout<<endl;
       
     } while( num >= 1 );


          return 0;
}

The purpose was to print

***
**
*

So this guy has a do while with a for loop inside, when it could have been just a for loop.

As I have said above there are some situations where a do while is necessary, but they are rare.

[BHX]

Yeah, Bjarne Stroustrup even says that he avoids do while loops. He only mentions it on two pages in The C++ Programming Language Special Edition (114, and 137). This is his excerpt from page 137:

Bjarne Stroustrup wrote:

In my experience, the do-statement is a source of errors and confusion. The reason is that its body is always executed once before the condition is evaluated. However, for the body to work correctly, something very much like the condition must hold even the first time through. More often then a would have guessed, I have found that condition not to hold as expected either when the program was first written and tested or later after the code preceding it has been modified. I also prefer the condition "up front where I can see it." Consequently, I tend to avoid do-statements.

I use do while loops once in a while just for my goof apps, but if I'm doing something serious I use while loops.

[Athar]

You use a do-while loop when it makes sense and that does not depend on the type of application you're making. do-while loops are very rarely needed, but it is pointless to use a different loop "just because".

That's right, but one can nearly always still write it as a while loop that will execute at least once.

You can almost always write it using goto as well, but that does not automatically mean you should do it.

[TheIdeasMan]

Yeah, Bjarne Stroustrup even says that he avoids do while loops.

In my experience, the do-statement is a source of errors and confusion.

I also prefer the condition "up front where I can see it." Consequently, I tend to avoid do-statements.

Well I think I would go with Bjarne Stroustrup's observations, yes?

but it is pointless to use a different loop "just because".

I was trying to point people towards good programming practice, it's not "just because", because of the reasons I mentioned above and elsewhere on this forum. Obviously goto's are very bad practice, but for and while loops are good practice.

[ResidentBiscuit]

A do while loop is not bad practice. It has it's places, they just happen to be much more limited than others.