Random number generator always generates 42?

[Konichua]

Help! Here is my code:

//
// Danny's dice simulator
// Change the sides of the dice to get
// a random number out of your number
//
#include <cstdlib>
#include <iostream>

using namespace std;
int main(int nNumberofArgs, char* pszArgs[])
{
// How many sides does your dice have?
int sides;
cout << "How many sides does your dice have?";
cin >> sides;
// Randomise out of users number
int n;
n = rand() % sides + 1;
// n is the resulting number
cout << "Your random number out of ";
cout << sides;
cout << " is:";
cout << n << endl;
// Press any key to continue
system("PAUSE");
return 0;
}

If your number of sides is less than 42, then your answer is always the number of sides.
If your number of sides is more than 42, then the answer is always 42. Help please! :(

[Disch]

You need to seed the random number generator by calling srand.

Call srand at the very start of your program (beginning of main). But only call it once, do not call it for each random number you want to generate.

srand( time(0) );

[atropos]

This is because rand() doesn't really produce random numbers; it produces numbers based on a (complex) mathematical formula.

Add the line srand(time(0)); to your code

[Konichua]

Got an error?

K:\CodeBlocks\Projects\dannys-dice\main.cpp:10: error: expected constructor, destructor, or type conversion before '(' token

Bear in mind I know almost nothing about c++, and error reports make no sense to me XD
I added srand( time(0) ); in between using namespace std; and int main;.

[atropos]

To use time(), you need to #include <ctime>

Sorry, I forgot to mention that before

[Disch]

the srand call needs to go inside of main. At the start of it.

[Konichua]

Thank-you. I have implemented both of your fixes and have fixed the program. Thanks for your time :)