program crashes in the end

[ortymd]

Hi everyone.
Program seems to work fine, but crashes in the end, after the destructors are called. Why???

#include "Furniture.h"
#include <fstream>
using namespace std;

void main (int argc, char *argv[])
{
	string FileName = "TheFurniture";
	cout << argv[0] << "\nRunning" << endl;
	ofstream FileOut;
	FileOut.open(FileName, ios::binary);
	Furniture Table ("Baroc", 78);
	FileOut.write((char*) &Table, sizeof Table);
	FileOut.close();

	ifstream FileIn (FileName, ios::binary);
	Furniture Table1 ("Ancient", 99);
	Table1.getInfo();
	FileIn.read((char*) &Table1, sizeof Table1);
	Table1.getInfo();
	FileIn.close();

[coder777]

You shouldn't write/read a class like that.

Why it actually crashes depends on the Furniture class. If it contains virtual functions or other pointer then yes it will crash.

[ortymd]

"You shouldn't write/read a class like that."
Please give an example of better code.

Here is the Furniture.h. No virtual functions, neither pointers.

#include <iostream>
#include <string>
using namespace std;

class Furniture
{
public:
	Furniture() {cout << "Furniture default constructor\n";}
	Furniture (string Model, int Number ):itsModel(Model),itsNumber(Number) {}
	~Furniture() {cout << "Furniture default destructor\n";}
	
	void getInfo() const;
private:
	string itsModel;
	int itsNumber;
};

void Furniture::getInfo() const
{
	cout << "This is " << this -> itsModel << " furniture\n";
	cout << "It's Number is " << this -> itsNumber << endl;
}

[coder777]

neither pointers

not obvious, but there is. string uses pointer.

Please give an example of better code.

Use the stream operators. Like so:

out: FileOut << Table.itsModel << " " << Table.itsNumber;
in: FileIn >> Table.itsModel >> Table.itsNumber;

[ortymd]

Thanks for the example.

if string uses pointer, I should delete it ?
As I understand, this creates a memory leak and causes the program to crash.

[Moschops]

I should delete it ?

No, you should delete anything that you created using new. Do not delete something just because you've got a pointer to it.