Caesar Cipher, yes homework

[curtisschlepp]

I'll start simple how do I post in here so it shows my code lines?

[Athar]

By adding code tags:
[code]code here[/code]

[curtisschlepp]

my problem is between lines 116 and 130 (specifically with line 127)

I am trying to create a function that returns the most counted letter so I can create other functions too factor in the shift of the cipher. currently the program gives an error making me think the array is going out of bounds. if I put line 127 outside the if statement it then returns a null value.

any help is appreciated

#include  <iostream>
#include <fstream>
#include <cctype>
#include <string>

using namespace std;



void initialize (int& lc, int list[]);

void copyText (ifstream& intext, ofstream& outtext, char ch, int list []);

void characterCount ( char ch, int list[]);

void writeTotal (ofstream& outtext, int lc, int list[]);

int largestLetter (int list[]); // takes the list INDEX and returns the most often counted letter
int main ()
{
	int lineCount;
	int letterCount [26];
	char ch;
	char LARGEST;
	string inputFileName;

	ifstream infile;
	ofstream outfile;
	
	cout << "please enter the file name";
	getline (cin, inputFileName);
	infile.open (inputFileName);
	
	if (!infile)
	{
	cout << "cannot open the file" << endl;
	return 1;

	}
	
	outfile.open ("encryptedout.txt");
	
	initialize(lineCount, letterCount);

	infile.get(ch);

	while (infile)
	{
		copyText (infile, outfile, ch, letterCount);
		lineCount ++;
		infile.get(ch);
		
	}

	cout << endl << endl<< "was the encrypted text"<< endl;
	


	writeTotal(outfile, lineCount, letterCount);

	LARGEST = largestLetter(letterCount);
	
	cout <<"the largest count was " << LARGEST;
	infile.close();
	outfile.close();

return 0;

}


void initialize (int& lc, int list [])
{
	int j;
	lc = 0;
	for (j=0; j<26; j++)
		list[j]= 0;
}

void copyText (ifstream& intext, ofstream& outtext, char ch, int list [])
{
	while (ch != '\n')
	{
		outtext<< ch;

		characterCount (ch, list);
		intext.get(ch);
		cout << ch; // echos out the encrypted text
	}
	outtext<<ch;
	
}

void characterCount (char ch, int list [])
{
	int index;
	ch = toupper(ch);
	
	index = static_cast<int>(ch) -static_cast <int> ('A');
	if (0 <=index && index <26)
		list[index]++;
}

 void writeTotal (ofstream& outtext, int lc, int list[])
 {
	 int index;

	 outtext<< endl<< endl;
	 outtext << "The number of lines = " << lc << endl;
	for (index = 0; index < 26; index++)
		 outtext << static_cast<char>(index +static_cast<int>('A')) << " count " << list[index] << endl;

 }

 
int largestLetter (int list[])
{
	int index = 1;
	int maxIndex =0;
	int largest= 0;

		for (index =1; index <26; index++)
		{
			if (list[index] > list[maxIndex]);
			maxIndex = list[index];
		
			largest = list[maxIndex];
		}
	return largest;
}

[blueberry]

int largestLetter (int list[])
{
	int index = 1;
	int maxIndex =0;
	int largest= 0;

		for (index =1; index <26; index++)
		{
			if (list[index] > list[maxIndex]);//this if statment doesnt do anything
			maxIndex = list[index];//<-- may i ask what your trying to do here?
			largest = list[maxIndex];//maxindex here is the amount of charactors at list[index]
		}
	return largest;
}

what are you trying to do there?

edit: tried to be more constructive...i also tryed to fix that function
fixed:

int largestLetter (int list[])
{
	int index = 1;
	int maxIndex =0;
	int largest= 0;

		for (index =0; index <26; index++)//fixed here too
		{
			if (list[index] > list[maxIndex])
			      maxIndex = index;//this should make it work..
			largest = list[maxIndex];
                }
	return largest;
}

I would do it like this:

int largestLetter (int list[])
{
	int largest= 0;

		for (int index =0; index <26; index++)
		{
			if (list[index] > largest)
			     largest=list[index];
                }
	return largest;
}