switch case not working

Hi all, i would like to find out why my nested switch case does not work. It just hangs when i key in 1 in case 4.
As you can see in case 4, i am doing a nested switch case. However, when i key in 1, the program just hangs. May i know what is the reason behind this?

#include <algorithm>
#include <sstream>
#include <fstream>
#include <functional>
#include <iostream>
#include <string>
#include "ShapeTwoD.h"
#include "Cross.h"
#include "Square.h"
#include "Rectangle.h"
using namespace std;


string arrayOfShapes[100];


struct my_function  // boolean function that was used in the sort function on line 175
{
    bool operator() ( const string& a, const string& b ) const
   {
        float convertA = 0, convertB = 0 ;
        std::stringstream(a) >> convertA ;
        std::stringstream(b) >> convertB ;
        return convertA  > convertB ;
   }
};


void showProgram()
{
      
      cout<<"Welcome to Assn2 program!"<<endl<<
   
      "1)Input sensor data."<<endl<<
      "2)Compute area (for all records)"<<endl<<
      "3)Print shapes report."<<endl<<   		
      "4)Sort shape data."<<endl;
       


}

int main()
{
	string crossCord,squareCord,rectCord,data;
	string shape,type;
	int choice,sortChoice=0;
	
	int counter=0;
	ShapeTwoD shape2D;
	Cross cross;
	Square square;
	Rectangle rect;
	ShapeTwoD *Cross = &cross;
	ShapeTwoD *Square = &square;
	ShapeTwoD *Rectangle = &rect;


        
	
	do
	{
	showProgram();
	cout<<"Please select your choice :";
	cin>>choice;
	


	switch(choice)
	{

	case 1 : 
		{
		 cout<<endl;
		 cout<<"[Input sensor data]"<<endl;
		 cout<<"Please enter name of shape :"<<endl;
		 cin>>shape;
		 shape2D.setName(shape);
		 cout<<"Please enter special type :"<<endl;
		 cin>>type;
		 shape2D.setWarpSpace(type);
		 cout<<shape2D.getName();
		 string shape=shape2D.getName()+","+shape2D.getWarpSpace()+",";	
		 if(shape2D.getName()=="Cross"||shape2D.getName()=="cross")
		 {
			
			cross.setCord(shape);
		        crossCord=cross.getCrossCord();
			
			
			
		 }else if(shape2D.getName()=="square" || shape2D.getName()=="Square")
		
		{
			
			square.setCord(shape);
			crossCord=square.getSquareCord();
					
		}
		else if(shape2D.getName()=="rectangle" || shape2D.getName()=="Rectangle")
		{
			
			rect.setCord(shape);
			crossCord=rect.getRectCord();
			

		}
		
		


		data=crossCord;
		
		arrayOfShapes[counter]=data;
		counter++;
		
		
		

		
		
		
		
		

		

		 cout<<"Record successfully stored. Going back to main menu...."<<endl;

		 break;
		 }	

	case 2:  //compute method
		 for(int i=0;i<counter;i++)
		 {
			
					
			
			//rect.setData(data);
			//cross.setData(data);
			//square.setData(data);
			stringstream area;
			float getArea;
		        stringstream toString(arrayOfShapes[i]);
			string shapeName;
			getline(toString,shapeName,',');
			

			if(shapeName == "Cross" || shapeName == "cross")
			{
			  
			  cross.setData(arrayOfShapes[i]);
			  getArea=cross.computeArea();
			  
			}
		       else if(shapeName == "Square" || shapeName =="square")
			{
			square.setData(arrayOfShapes[i]);
			getArea=square.computeArea();
			

			}
			
			else if(shapeName == "Rectangle" || shapeName == "rectangle")
			{
			  rect.setData(arrayOfShapes[i]);
			  getArea=rect.computeArea();
			}
			
			
			area<<getArea;
			arrayOfShapes[i]=area.str()+","+arrayOfShapes[i];
			cout<<arrayOfShapes[i]<<endl;	

		 }
		 
		 
		
		 	
		 cout<<"Computation completed!"<<endl;
		 break;


	case 3 :   cout<<"Total No. of Records avaliable = "<<counter<<endl;
		   
		for(int i=0;i<counter;i++)
		{
		string shapeName,warpSpace,point,area;
		stringstream toString(arrayOfShapes[i]);
		cout<<"Shape ["<<i<<"]"<<endl;
		getline(toString,area,',');
		getline(toString,shapeName,',');
		getline(toString,warpSpace,',');
		
		
		cout<<"Name:"<<shapeName<<endl;
		cout<<"Special Type :"<<warpSpace<<endl;
		cout<<"Area:"<<area<<endl;
		cout<<"Vertices"<<endl;
		
		if(shapeName=="Cross"||shapeName=="cross")
		{
		for(int b=0;b<12;b++)
		{
			
		getline(toString,point,'@');
		cout<<"Point["<<b<<"]"<<point<<endl;
		}
		   }
		else if(shapeName=="Square"||shapeName=="square")
		{
		for(int a=0;a<4;a++)
			{
		getline(toString,point,'@');
		cout<<"Point["<<a<<"]"<<point<<endl;
			}	
		}
		else if(shapeName=="Rectangle"||shapeName=="rectangle")
			{
				for(int c=0;c<4;c++)
				{
				getline(toString,point,'@');
				cout<<"Point["<<c<<"]"<<point<<endl;
				}
			}
		
		}

		break;


	case 4:  cout<<"1)	Sort by area (ascending)"<<endl;
		 cout<<"2)	Sort by area (descending)"<<endl;
		 cout<<"3)	SOrt by special type and area"<<endl;
		 cout<<"Please select sort option ('q' to go back to main menu) :";
		 cin>>sortChoice;
		do{
		switch (sortChoice)
		{

		case  1 :  sort(arrayOfShapes,arrayOfShapes+100);
			    for(int i=0;i<counter;i++)
			    {
				/*string shapeName,warpSpace,point,area;
				stringstream toString(arrayOfShapes[i]);
				cout<<"Shape ["<<i<<"]"<<endl;
				getline(toString,area,',');
				getline(toString,shapeName,',');
				getline(toString,warpSpace,',');
		
		
				cout<<"Name:"<<shapeName<<endl;
				cout<<"Special Type :"<<warpSpace<<endl;
				cout<<"Area:"<<area<<endl;
				cout<<"Vertices"<<endl;*/

				cout<<arrayOfShapes[i];
		

			    }
			  break;






		}
		 


		   }while(sortChoice !='q');

	}

	}while(choice !=5);




	return 0;


}

MrHutch (1822)

do
{
   // Your code
} while (sortChoice != 'q');

This is an infinite loop because there's nothing inside of the loop that can change the condition to prevent it from looping again.

sortChoice needs to change inside of that loop at some point, to stop it from looping.

CLearner88 (123)

@iHutch105
i have declared a case 'q' to break out of the loop.
However, the same thing happens. the switch case just hangs
when i keyed in 1 at line 232. It shows nothing when i asked the
program to print out the arrays

whitenite1 (1785)

You are checking for integers, while inputting chars. So the 1, comes out as value 49. Add single quotes around the '1', and, of course, the rest of the cases in that section, when you write it.

CLearner88 (123)

@whitenite1
i have changed my selection cases
to 'a','b','c'

however, i tried a cout<<"hello word"<<endl;

the command prompt just repeats hello world in an infinite loop.

Could it be that i cannot have a nested do-while loop?

it puzzles me

edit: the loop occurs when i select choice 'a'

Last edited on

whitenite1 (1785)

@CLearner88

Make one small change to your do/while. You have this..

cout<<"Please select sort option ('q' to go back to main menu) :";
		 cin>>sortChoice;
		do{
		switch (sortChoice)
		{

Change it to this.

 do{
    cout<<"Please select sort option ('q' to go back to main menu) :"; // Move line to here
    cin>>sortChoice; // and move this cin line, to here
        switch (sortChoice)

CLearner88 (123)

Oh it works, thank you so much! =)

whitenite1 (1785)

Glad I could help.

Topic archived. No new replies allowed.

C++

Forum

switch case not working