Battleships problem!!

[bulbadude]

I've been trying to build a battleships game for a course I'm doing at the moment, but I have hit a road block. My code works smoothly, but I don't know if I have structured it right so far, as I am not able to figure out how to place my ships on the board. Would anyone be able to give me a hand, or some insightful wisdom?

Thanks!!

Here's what I have so far:
It runs fine if you want to compile it on your computers

#include <iostream>
#include <string>
#include <cstdlib>
#include <ctime>
#include <windows.h>

using namespace std;

int Menu(); 
int Instructions(); 
void GameBoard(); 
char CoordEnterLetter();
int CoordEnterNumber();
char DirecCoord(); 
void AirCPlacement(); 
void BShipPlacement(); 
void DestPlacement(); 
void SubPlacement(); 
void PTBoatPlacement(); 


int main()
{
	//Characters for the different ships
	char AirCarrier = 'A';
	char Battleship = 'B';
	char Destroy = 'D';
	char Sub = 'S';
	char PtBoat = 'P';

	//Calls the menu function, which in turn, calls all the other functions
	Menu();

    int iTemp;
    cin >> iTemp;

    return 0;
}

void GameBoard()
{
	//Generates the game board
    const int ROWS = 12;
    const int COLUMNS = 12;
	bool bValue = false;

    char cBoard[ROWS][COLUMNS] = { { ' ', ' ', 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J'},
                                    { ' ', '1', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' '},
                                    { ' ', '2', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' '},
                                    { ' ', '3', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' '},
                                    { ' ', '4', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' '},
                                    { ' ', '5', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' '},
                                    { ' ', '6', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' '},
                                    { ' ', '7', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' '},
                                    { ' ', '8', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' '},
                                    { ' ', '9', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' '},
                                    { '1', '0', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' '} };

	
    for (int i = 0; i < ROWS; ++i)
    {
        for (int j = 0; j < COLUMNS; ++j)
        {
            cout << cBoard[i][j];
        }
		
		cout << endl;

	//Calls the ship placement functions, asking where the user would like those ships to be placed
	

	}

}

char CoordEnterLetter()
{
	
	char cLetter = 'a';
	bool bValue = false;
	
	//While loop for entering a letter coordinate
	while (bValue == false)
	{
		cout << "Please enter a letter between A-J: ";
		cin >> cLetter;
		cout << endl;

		if (cLetter >= 0 && cLetter <= 64)
		{
			cout << "Invalid Input, please enter a letter between A-J" << endl;
			cout << endl;
		}
		else if (cLetter >= 75 && cLetter <= 96)
		{
			cout << "Invalid Input, please enter a letter between A-J" << endl;
			cout << endl;
		}
		else if (cLetter >= 107 && cLetter <= 256)
		{
			cout << "Invalid Input, please enter a letter between A-J" << endl;
			cout << endl;
		}
		else
		{
			break;
		}
	}



return cLetter;

}

int CoordEnterNumber()
{
	//While loop for entering a number coordinate
	int iNumber;
	bool bValue = false;

	while (bValue == false)
	{
		cout << "Please enter a number between 1-10: ";
		cin >> iNumber;
		cout << endl;

		if (iNumber == 0 || iNumber > 10)
		{
			cout << "Invalid Input, please enter a number between 1-10" << endl;
			cout << endl;
		}
		else 
		{
			break;
		}
	}

	return iNumber;
}

char DirecCoord()
{
	char cDirection = 'a';
	bool bValue = false;

	//While loop for selecting which direction the ship should be facing
	while (bValue == false)
	{
		cout << endl;
		cout << "Please enter a direction for your ship to face: " << endl;
		cout << "Up (U)" << endl;
		cout << "Down (D)" << endl;
		cout << "Left (L)" << endl;
		cout << "Right (R)" << endl;
		cout << "Enter here: ";
		cin >> cDirection;
		cout << endl;

		if ( cDirection == 68 || cDirection == 100)
		{
			cout << "You selected Down." << endl;
			cout << endl;
			break;
		}
		else if ( cDirection == 76 || cDirection == 108)
		{
			cout << "You selected Left." << endl;
			cout << endl;
			break;
		}
		else if ( cDirection == 82 || cDirection == 114)
		{
			cout << "You selected Right." << endl;
			cout << endl;
			break;
		}
		else if (cDirection == 85 || cDirection == 117)
		{
			cout << "You selected Up." << endl;
			cout << endl;
			break;
		}
		else
		{
			cout << "Invalid Input, please enter a new direction." << endl;
			cout << endl;
		}

	}

		return cDirection;
}


int Menu()
{
	//The Menu function
	char cMenu = 'a';
	bool bValue = false;

	cout << "Welcome To Battleships!!" << endl;
	cout << endl;
	
	while (bValue == false)
	{
		cout << "1: Play Game." << endl;
		cout << "2: Instructions." << endl;
		cout << "3: Exit Game." << endl;

		//The player can choose one of three options:
		//1) Play the game
		//2) View instructions
		//3) Exit the game
		cout << "What do you want to do? ";
		cin >> cMenu;
		cout << endl;

		if (cMenu == 49)
		{
			cout << "Prepare For Battle!!!" << endl;
			cout << endl;
			AirCPlacement();
			BShipPlacement();
			DestPlacement();
			SubPlacement();
			PTBoatPlacement();
		}
		else if (cMenu == 50)
		{
			Instructions();
		}
		else if (cMenu == 51)
		{
			cout << "Exiting." << endl;
			return 0;
		}
		else
		{
			cout << "Invalid Input, please enter a new number." << endl;
			cout << endl;
		}
	}

	return cMenu;
}

int Instructions()
{
	//The instructions function.
	//Pretty basic, just giving instructions so any new player knows how to play the game
	//Provided a board, with a key showing the different ships
	char cReturn = 'a';
	bool bValue = false;

	cout << "Instructions: " << endl;
	cout << endl;

	cout << "This game is set on two 10x10 grids, one for you, and one for your opponent." << endl;
	cout << "You set your ships on the grid either manually or randomly."  << endl;
	cout << "Once the ships have been set you enter a coordinate, one letter between A-J" << endl;
	cout << "and one number between 1-10" << endl;
	cout << "You will either register a hit 'X' or a miss 'O' depending on where your" << endl;
	cout << "opponent placed their boats." << endl;
	cout << "Your opponent will then have their turn, and try and hit one of your ships." << endl;
	cout << "You will continue to alternate turns until either you, or your opponent" << endl;
	cout << "has hit and sunk all of the ships on their opposing board." << endl;
	cout << endl;
	cout << endl;
	
	//Providing the option to return to the menu, or exit the game completely
	while (bValue == false)
	{
		cout << "Do you wish to: " << endl;
		cout << "1) Return to the menu: ";
		cin >> cReturn;
		cout << endl;

		if (cReturn == 49)
		{
			cout << "You have chosen to return to the menu." << endl;
			Menu();
		}
		else
		{
			cout << "Invalid Input, please enter a new number." << endl;
			cout << endl;
		}
	}

	return cReturn;

}

void AirCPlacement()
{

	cout << "Please enter coordinates for the Aircraft Carrier: " << endl;

	 char cGridLetter = CoordEnterLetter();
	 int iGridNumber = CoordEnterNumber();

	 cout << cGridLetter;
	 cout << iGridNumber << endl;

	char cCoordDirection = DirecCoord();
	GameBoard();

}

void BShipPlacement()
{
	
	cout << "Please enter coordinates for the Battleship: " << endl;

	 char cGridLetter = CoordEnterLetter();
	 int iGridNumber = CoordEnterNumber();

	 cout << cGridLetter;
	 cout << iGridNumber << endl;

	char cCoordDirection = DirecCoord();
	GameBoard();
}

void DestPlacement()
{
	cout << "Please enter coordinates for the Destroyer: " << endl;

	 char cGridLetter = CoordEnterLetter();
	 int iGridNumber = CoordEnterNumber();

	 cout << cGridLetter;
	 cout << iGridNumber << endl;

	char cCoordDirection = DirecCoord();
	GameBoard();
}

void SubPlacement()
{
	cout << "Please enter coordinates for the Submarine: " << endl;

	 char cGridLetter = CoordEnterLetter();
	 int iGridNumber = CoordEnterNumber();

	 cout << cGridLetter;
	 cout << iGridNumber << endl;

	char cCoordDirection = DirecCoord();
	GameBoard();
}

void PTBoatPlacement()
{
	cout << "Please enter coordinates for the Patrol Boat: " << endl;

	 char cGridLetter = CoordEnterLetter();
	 int iGridNumber = CoordEnterNumber();

	 cout << cGridLetter;
	 cout << iGridNumber << endl;

	char cCoordDirection = DirecCoord();
	GameBoard();

}

[kong288]

Maybe you should start practicing with a file system and/or classes? That'd make it easier on you for managing code/finding things faster.

[blueberry]

Bad way of programming! (in my opinion)

You methods are not meant to be used like that, you should not have functions that call other functions in chains like that. It makes the code almost impossible to follow when programs get larger. Control of the program should be kept within main, this way it makes it easier to add new functionality. Also, are you familiar with argument passing? I think it would make it much easier for you.

-Blueberry

[Ghost66]

teste

[bulbadude]

Yeah I know its pretty bad programming, which is why I need you guys to tell me whats wrong!!

We have covered argument passing in class, but I still haven't fully grasped it. Having the basics of C++ crammed into my head in 3 weeks means some pretty important bits have slipped through the figurative cracks.

kong 288, we haven't learnt either of those in class yet, so chucking them into my code may look a bit suspect.

But thanks for the advice!! I'll start changing my code, certainly going to changing my functions around.